All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/2] package/webkitgtk: disable JSC JIT for MIPSr6
@ 2020-02-11 20:44 Adrian Perez de Castro
  2020-02-11 20:44 ` [Buildroot] [PATCH 2/2] package/wpewebkit: " Adrian Perez de Castro
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Adrian Perez de Castro @ 2020-02-11 20:44 UTC (permalink / raw)
  To: buildroot

Forcibly disable the JavaScriptCore JIT compilation support
for MIPSr6 processors, which are unsupported.

Fixes: http://autobuild.buildroot.net/results/3d21d3c3460cd85a4c828dd197929cdf17aaf4e0

Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
 package/webkitgtk/webkitgtk.mk | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
index e5d591fcd2..cbd9003071 100644
--- a/package/webkitgtk/webkitgtk.mk
+++ b/package/webkitgtk/webkitgtk.mk
@@ -104,4 +104,13 @@ else
 WEBKITGTK_CONF_OPTS += -DUSE_GSTREAMER_GL=OFF
 endif
 
+# JIT is not supported for MIPS r6, but the WebKit build system does not
+# have a check for these processors. Disable JIT forcibly here and use
+# the CLoop interpreter instead.
+#
+# Upstream bug: https://bugs.webkit.org/show_bug.cgi?id=191258
+ifeq ($(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6),y)
+WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF -DENABLE_C_LOOP=ON
+endif
+
 $(eval $(cmake-package))
-- 
2.25.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 2/2] package/wpewebkit: disable JSC JIT for MIPSr6
  2020-02-11 20:44 [Buildroot] [PATCH 1/2] package/webkitgtk: disable JSC JIT for MIPSr6 Adrian Perez de Castro
@ 2020-02-11 20:44 ` Adrian Perez de Castro
  2020-02-11 22:34   ` Peter Korsgaard
  2020-03-07 11:12   ` Peter Korsgaard
  2020-02-11 22:33 ` [Buildroot] [PATCH 1/2] package/webkitgtk: " Peter Korsgaard
  2020-03-07 11:12 ` Peter Korsgaard
  2 siblings, 2 replies; 6+ messages in thread
From: Adrian Perez de Castro @ 2020-02-11 20:44 UTC (permalink / raw)
  To: buildroot

Forcibly disable the JavaScriptCore JIT compilation support
for MIPSr6 processors, which are unsupported.

Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>
---
 package/wpewebkit/wpewebkit.mk | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
index cf45b68943..8b890301b7 100644
--- a/package/wpewebkit/wpewebkit.mk
+++ b/package/wpewebkit/wpewebkit.mk
@@ -63,4 +63,13 @@ else
 WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=OFF
 endif
 
+# JIT is not supported for MIPS r6, but the WebKit build system does not
+# have a check for these processors. Disable JIT forcibly here and use
+# the CLoop interpreter instead.
+#
+# Upstream bug: https://bugs.webkit.org/show_bug.cgi?id=191258
+ifeq ($(BR2_MIPS_CPU_MIPS32R6)$(BR2_MIPS_CPU_MIPS64R6),y)
+WPEWEBKIT_CONF_OPTS += -DENABLE_JIT=OFF -DENABLE_C_LOOP=ON
+endif
+
 $(eval $(cmake-package))
-- 
2.25.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/2] package/webkitgtk: disable JSC JIT for MIPSr6
  2020-02-11 20:44 [Buildroot] [PATCH 1/2] package/webkitgtk: disable JSC JIT for MIPSr6 Adrian Perez de Castro
  2020-02-11 20:44 ` [Buildroot] [PATCH 2/2] package/wpewebkit: " Adrian Perez de Castro
@ 2020-02-11 22:33 ` Peter Korsgaard
  2020-03-07 11:12 ` Peter Korsgaard
  2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-02-11 22:33 UTC (permalink / raw)
  To: buildroot

>>>>> "Adrian" == Adrian Perez de Castro <aperez@igalia.com> writes:

 > Forcibly disable the JavaScriptCore JIT compilation support
 > for MIPSr6 processors, which are unsupported.

 > Fixes: http://autobuild.buildroot.net/results/3d21d3c3460cd85a4c828dd197929cdf17aaf4e0

 > Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 2/2] package/wpewebkit: disable JSC JIT for MIPSr6
  2020-02-11 20:44 ` [Buildroot] [PATCH 2/2] package/wpewebkit: " Adrian Perez de Castro
@ 2020-02-11 22:34   ` Peter Korsgaard
  2020-03-07 11:12   ` Peter Korsgaard
  1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-02-11 22:34 UTC (permalink / raw)
  To: buildroot

>>>>> "Adrian" == Adrian Perez de Castro <aperez@igalia.com> writes:

 > Forcibly disable the JavaScriptCore JIT compilation support
 > for MIPSr6 processors, which are unsupported.

 > Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/2] package/webkitgtk: disable JSC JIT for MIPSr6
  2020-02-11 20:44 [Buildroot] [PATCH 1/2] package/webkitgtk: disable JSC JIT for MIPSr6 Adrian Perez de Castro
  2020-02-11 20:44 ` [Buildroot] [PATCH 2/2] package/wpewebkit: " Adrian Perez de Castro
  2020-02-11 22:33 ` [Buildroot] [PATCH 1/2] package/webkitgtk: " Peter Korsgaard
@ 2020-03-07 11:12 ` Peter Korsgaard
  2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-03-07 11:12 UTC (permalink / raw)
  To: buildroot

>>>>> "Adrian" == Adrian Perez de Castro <aperez@igalia.com> writes:

 > Forcibly disable the JavaScriptCore JIT compilation support
 > for MIPSr6 processors, which are unsupported.

 > Fixes: http://autobuild.buildroot.net/results/3d21d3c3460cd85a4c828dd197929cdf17aaf4e0

 > Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>

Committed to 2019.02.x and 2019.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 2/2] package/wpewebkit: disable JSC JIT for MIPSr6
  2020-02-11 20:44 ` [Buildroot] [PATCH 2/2] package/wpewebkit: " Adrian Perez de Castro
  2020-02-11 22:34   ` Peter Korsgaard
@ 2020-03-07 11:12   ` Peter Korsgaard
  1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2020-03-07 11:12 UTC (permalink / raw)
  To: buildroot

>>>>> "Adrian" == Adrian Perez de Castro <aperez@igalia.com> writes:

 > Forcibly disable the JavaScriptCore JIT compilation support
 > for MIPSr6 processors, which are unsupported.

 > Signed-off-by: Adrian Perez de Castro <aperez@igalia.com>

Committed to 2019.11.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-03-07 11:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 20:44 [Buildroot] [PATCH 1/2] package/webkitgtk: disable JSC JIT for MIPSr6 Adrian Perez de Castro
2020-02-11 20:44 ` [Buildroot] [PATCH 2/2] package/wpewebkit: " Adrian Perez de Castro
2020-02-11 22:34   ` Peter Korsgaard
2020-03-07 11:12   ` Peter Korsgaard
2020-02-11 22:33 ` [Buildroot] [PATCH 1/2] package/webkitgtk: " Peter Korsgaard
2020-03-07 11:12 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.