* [Buildroot] [PATCH] package/docker-containerd: add missing dependency on host-pkgconf
@ 2018-12-28 15:07 Thomas Petazzoni
2018-12-29 4:46 ` Christian Stewart
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2018-12-28 15:07 UTC (permalink / raw)
To: buildroot
When libsseccomp support is enabled, docker-containerd uses pkg-config
to find libsseccomp, so we must depend on host-pkconf.
Fixes the following build issue, detected with per-package directory
support:
pkg-config: exec: "pkg-config": executable file not found in $PATH
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/docker-containerd/docker-containerd.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/docker-containerd/docker-containerd.mk b/package/docker-containerd/docker-containerd.mk
index 121ef0939e..71bcfcca32 100644
--- a/package/docker-containerd/docker-containerd.mk
+++ b/package/docker-containerd/docker-containerd.mk
@@ -19,7 +19,7 @@ DOCKER_CONTAINERD_BUILD_TARGETS = cmd/ctr cmd/containerd cmd/containerd-shim
DOCKER_CONTAINERD_INSTALL_BINS = containerd containerd-shim
ifeq ($(BR2_PACKAGE_LIBSECCOMP),y)
-DOCKER_CONTAINERD_DEPENDENCIES += libseccomp
+DOCKER_CONTAINERD_DEPENDENCIES += libseccomp host-pkgconf
DOCKER_CONTAINERD_TAGS += seccomp
endif
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] package/docker-containerd: add missing dependency on host-pkgconf
2018-12-28 15:07 [Buildroot] [PATCH] package/docker-containerd: add missing dependency on host-pkgconf Thomas Petazzoni
@ 2018-12-29 4:46 ` Christian Stewart
2018-12-29 9:44 ` Thomas Petazzoni
2018-12-29 10:29 ` Yann E. MORIN
2018-12-30 15:57 ` Thomas Petazzoni
2019-01-18 15:00 ` Peter Korsgaard
2 siblings, 2 replies; 7+ messages in thread
From: Christian Stewart @ 2018-12-29 4:46 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Fri, Dec 28, 2018 at 7:07 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
> When libsseccomp support is enabled, docker-containerd uses pkg-config
> to find libsseccomp, so we must depend on host-pkconf.
> +DOCKER_CONTAINERD_DEPENDENCIES += libseccomp host-pkgconf
LGTM.
Signed-off-by: Christian Stewart <christian@paral.in>
- I hope signed-off-by is appropriate here.
Best,
Christian
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] package/docker-containerd: add missing dependency on host-pkgconf
2018-12-29 4:46 ` Christian Stewart
@ 2018-12-29 9:44 ` Thomas Petazzoni
2018-12-29 10:29 ` Yann E. MORIN
1 sibling, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2018-12-29 9:44 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 28 Dec 2018 20:46:50 -0800, Christian Stewart wrote:
> On Fri, Dec 28, 2018 at 7:07 AM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> > When libsseccomp support is enabled, docker-containerd uses pkg-config
> > to find libsseccomp, so we must depend on host-pkconf.
> > +DOCKER_CONTAINERD_DEPENDENCIES += libseccomp host-pkgconf
>
> LGTM.
Thanks for the review.
> Signed-off-by: Christian Stewart <christian@paral.in>
>
> - I hope signed-off-by is appropriate here.
Signed-off-by is when you're the author, or in the chain of
developers/maintainers that carry the patch all the way to upstream.
In this case, what you should ideally have used is a Acked-by or
Reviewed-by. See also
https://buildroot.org/downloads/manual/manual.html#_reviewing_and_testing_patches.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] package/docker-containerd: add missing dependency on host-pkgconf
2018-12-29 4:46 ` Christian Stewart
2018-12-29 9:44 ` Thomas Petazzoni
@ 2018-12-29 10:29 ` Yann E. MORIN
2018-12-29 10:43 ` Christian Stewart
1 sibling, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2018-12-29 10:29 UTC (permalink / raw)
To: buildroot
Christian, All,
On 2018-12-28 20:46 -0800, Christian Stewart spake thusly:
> On Fri, Dec 28, 2018 at 7:07 AM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> > When libsseccomp support is enabled, docker-containerd uses pkg-config
> > to find libsseccomp, so we must depend on host-pkconf.
> > +DOCKER_CONTAINERD_DEPENDENCIES += libseccomp host-pkgconf
>
> LGTM.
>
> Signed-off-by: Christian Stewart <christian@paral.in>
>
> - I hope signed-off-by is appropriate here.
No, it's not. A SoB line means that you were part of the chain that got
a patch to the list (and eventuakky, the repository), i.e. the author of
the patch, or any one taking it from the author up until it's comitted.
Here, you're saying that you looked at the patch, and that it looks OK
to you. This is a review, and is denoted by a Reviewed-by tag.
See the manual for more tags:
https://buildroot.org/downloads/manual/manual.html#_reviewing_and_testing_patches
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] package/docker-containerd: add missing dependency on host-pkgconf
2018-12-29 10:29 ` Yann E. MORIN
@ 2018-12-29 10:43 ` Christian Stewart
0 siblings, 0 replies; 7+ messages in thread
From: Christian Stewart @ 2018-12-29 10:43 UTC (permalink / raw)
To: buildroot
Yann, Thomas,
"Yann E. MORIN" <yann.morin.1998@free.fr> writes:
> No, it's not. A SoB line means that you were part of the chain that got
> a patch to the list (and eventuakky, the repository), i.e. the author of
> the patch, or any one taking it from the author up until it's comitted.
>
> Here, you're saying that you looked at the patch, and that it looks OK
> to you. This is a review, and is denoted by a Reviewed-by tag.
>
> See the manual for more tags:
> https://buildroot.org/downloads/manual/manual.html#_reviewing_and_testing_patches
Appreciated, I will mark these in my notes.
Best regards,
Christian
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] package/docker-containerd: add missing dependency on host-pkgconf
2018-12-28 15:07 [Buildroot] [PATCH] package/docker-containerd: add missing dependency on host-pkgconf Thomas Petazzoni
2018-12-29 4:46 ` Christian Stewart
@ 2018-12-30 15:57 ` Thomas Petazzoni
2019-01-18 15:00 ` Peter Korsgaard
2 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2018-12-30 15:57 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 28 Dec 2018 16:07:40 +0100, Thomas Petazzoni wrote:
> When libsseccomp support is enabled, docker-containerd uses pkg-config
> to find libsseccomp, so we must depend on host-pkconf.
>
> Fixes the following build issue, detected with per-package directory
> support:
>
> pkg-config: exec: "pkg-config": executable file not found in $PATH
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> package/docker-containerd/docker-containerd.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] package/docker-containerd: add missing dependency on host-pkgconf
2018-12-28 15:07 [Buildroot] [PATCH] package/docker-containerd: add missing dependency on host-pkgconf Thomas Petazzoni
2018-12-29 4:46 ` Christian Stewart
2018-12-30 15:57 ` Thomas Petazzoni
@ 2019-01-18 15:00 ` Peter Korsgaard
2 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2019-01-18 15:00 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> When libsseccomp support is enabled, docker-containerd uses pkg-config
> to find libsseccomp, so we must depend on host-pkconf.
> Fixes the following build issue, detected with per-package directory
> support:
> pkg-config: exec: "pkg-config": executable file not found in $PATH
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2018.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-01-18 15:00 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-28 15:07 [Buildroot] [PATCH] package/docker-containerd: add missing dependency on host-pkgconf Thomas Petazzoni
2018-12-29 4:46 ` Christian Stewart
2018-12-29 9:44 ` Thomas Petazzoni
2018-12-29 10:29 ` Yann E. MORIN
2018-12-29 10:43 ` Christian Stewart
2018-12-30 15:57 ` Thomas Petazzoni
2019-01-18 15:00 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.