* [Qemu-devel] [PATCH] MAINTAINERS: Fix F: patterns that don't match anything
@ 2018-08-10 11:55 Markus Armbruster
2018-08-10 14:39 ` Eric Blake
2018-08-13 7:54 ` Thomas Huth
0 siblings, 2 replies; 4+ messages in thread
From: Markus Armbruster @ 2018-08-10 11:55 UTC (permalink / raw)
To: qemu-devel
Commit ba51ef25571 moved hw/dma/sun4m_iommu.c to
hw/sparc/sun4m_iommu.c without updating MAINTAINERS.
Commit f5980f757c0 deleted include/hw/sparc/sun4m.h without updating
MAINTAINERS.
Commit 0bcc8e5bd8d fat-fingered tests/check-block-qdict.c.
Commit 33e9e9bd62d fat-fingered include/qemu/job.h.
Commit eb815e248f5 moved qapi-schema.json to qapi/ without updating
MAINTAINERS.
Commit 2e3c8f8dbdd converted docs/devel/migration.txt to
docs/devel/migration.rst without updating MAINTAINERS.
Offenders tracked down with the following shell loop:
shopt -s nullglob
for i in `sed -n 's/^F: //p' <MAINTAINERS `
do
glob="`echo $i`"
if [ "$glob" = "$i" ]
then [ ! -e $i ]
else [ -z "$glob" ]
fi && echo "$i"
done
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
MAINTAINERS | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 666e936812..01a2f20718 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -873,12 +873,11 @@ Sun4m
M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
S: Maintained
F: hw/sparc/sun4m.c
+F: hw/sparc/sun4m_iommu.c
F: hw/dma/sparc32_dma.c
-F: hw/dma/sun4m_iommu.c
F: hw/misc/eccmemctl.c
F: hw/misc/slavio_misc.c
F: include/hw/sparc/sparc32_dma.h
-F: include/hw/sparc/sun4m.h
F: pc-bios/openbios-sparc32
Sun4u
@@ -1399,7 +1398,7 @@ F: qemu-io*
F: tests/qemu-iotests/
F: util/qemu-progress.c
F: qobject/block-qdict.c
-F: test/check-block-qdict.c
+F: tests/check-block-qdict.c
T: git git://repo.or.cz/qemu/kevin.git block
Block I/O path
@@ -1432,7 +1431,7 @@ F: blockjob.c
F: include/block/blockjob.h
F: job.c
F: job-qmp.c
-F: include/block/job.h
+F: include/qemu/job.h
F: block/backup.c
F: block/commit.c
F: block/stream.c
@@ -1647,7 +1646,6 @@ QAPI Schema
M: Eric Blake <eblake@redhat.com>
M: Markus Armbruster <armbru@redhat.com>
S: Supported
-F: qapi-schema.json
F: qapi/*.json
T: git git://repo.or.cz/qemu/armbru.git qapi-next
@@ -1756,7 +1754,7 @@ F: migration/
F: scripts/vmstate-static-checker.py
F: tests/vmstate-static-checker-data/
F: tests/migration-test.c
-F: docs/devel/migration.txt
+F: docs/devel/migration.rst
F: qapi/migration.json
Seccomp
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix F: patterns that don't match anything
2018-08-10 11:55 [Qemu-devel] [PATCH] MAINTAINERS: Fix F: patterns that don't match anything Markus Armbruster
@ 2018-08-10 14:39 ` Eric Blake
2018-08-10 15:06 ` Markus Armbruster
2018-08-13 7:54 ` Thomas Huth
1 sibling, 1 reply; 4+ messages in thread
From: Eric Blake @ 2018-08-10 14:39 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel
On 08/10/2018 06:55 AM, Markus Armbruster wrote:
> Commit ba51ef25571 moved hw/dma/sun4m_iommu.c to
> hw/sparc/sun4m_iommu.c without updating MAINTAINERS.
>
> Commit f5980f757c0 deleted include/hw/sparc/sun4m.h without updating
> MAINTAINERS.
>
> Commit 0bcc8e5bd8d fat-fingered tests/check-block-qdict.c.
>
> Commit 33e9e9bd62d fat-fingered include/qemu/job.h.
>
> Commit eb815e248f5 moved qapi-schema.json to qapi/ without updating
> MAINTAINERS.
>
> Commit 2e3c8f8dbdd converted docs/devel/migration.txt to
> docs/devel/migration.rst without updating MAINTAINERS.
>
> Offenders tracked down with the following shell loop:
>
> shopt -s nullglob
> for i in `sed -n 's/^F: //p' <MAINTAINERS `
> do
> glob="`echo $i`"
> if [ "$glob" = "$i" ]
> then [ ! -e $i ]
> else [ -z "$glob" ]
> fi && echo "$i"
> done
Clever. The bulk of the time spent on this patch was chasing down the
faulty commits for the nice archaeology given above.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> MAINTAINERS | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix F: patterns that don't match anything
2018-08-10 14:39 ` Eric Blake
@ 2018-08-10 15:06 ` Markus Armbruster
0 siblings, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2018-08-10 15:06 UTC (permalink / raw)
To: Eric Blake; +Cc: Markus Armbruster, qemu-devel
Eric Blake <eblake@redhat.com> writes:
> On 08/10/2018 06:55 AM, Markus Armbruster wrote:
>> Commit ba51ef25571 moved hw/dma/sun4m_iommu.c to
>> hw/sparc/sun4m_iommu.c without updating MAINTAINERS.
>>
>> Commit f5980f757c0 deleted include/hw/sparc/sun4m.h without updating
>> MAINTAINERS.
>>
>> Commit 0bcc8e5bd8d fat-fingered tests/check-block-qdict.c.
>>
>> Commit 33e9e9bd62d fat-fingered include/qemu/job.h.
>>
>> Commit eb815e248f5 moved qapi-schema.json to qapi/ without updating
>> MAINTAINERS.
>>
>> Commit 2e3c8f8dbdd converted docs/devel/migration.txt to
>> docs/devel/migration.rst without updating MAINTAINERS.
>>
>> Offenders tracked down with the following shell loop:
>>
>> shopt -s nullglob
>> for i in `sed -n 's/^F: //p' <MAINTAINERS `
>> do
>> glob="`echo $i`"
>> if [ "$glob" = "$i" ]
>> then [ ! -e $i ]
>> else [ -z "$glob" ]
>> fi && echo "$i"
>> done
>
> Clever. The bulk of the time spent on this patch was chasing down the
> faulty commits for the nice archaeology given above.
I admit to having a weakness for git archeology.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> MAINTAINERS | 10 ++++------
>> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix F: patterns that don't match anything
2018-08-10 11:55 [Qemu-devel] [PATCH] MAINTAINERS: Fix F: patterns that don't match anything Markus Armbruster
2018-08-10 14:39 ` Eric Blake
@ 2018-08-13 7:54 ` Thomas Huth
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2018-08-13 7:54 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: Fam Zheng, Paolo Bonzini
On 08/10/2018 01:55 PM, Markus Armbruster wrote:
> Commit ba51ef25571 moved hw/dma/sun4m_iommu.c to
> hw/sparc/sun4m_iommu.c without updating MAINTAINERS.
>
> Commit f5980f757c0 deleted include/hw/sparc/sun4m.h without updating
> MAINTAINERS.
>
> Commit 0bcc8e5bd8d fat-fingered tests/check-block-qdict.c.
>
> Commit 33e9e9bd62d fat-fingered include/qemu/job.h.
>
> Commit eb815e248f5 moved qapi-schema.json to qapi/ without updating
> MAINTAINERS.
>
> Commit 2e3c8f8dbdd converted docs/devel/migration.txt to
> docs/devel/migration.rst without updating MAINTAINERS.
>
> Offenders tracked down with the following shell loop:
>
> shopt -s nullglob
> for i in `sed -n 's/^F: //p' <MAINTAINERS `
> do
> glob="`echo $i`"
> if [ "$glob" = "$i" ]
> then [ ! -e $i ]
> else [ -z "$glob" ]
> fi && echo "$i"
> done
Maybe we could check something like this with patchew automatically one day?
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> MAINTAINERS | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-13 7:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-10 11:55 [Qemu-devel] [PATCH] MAINTAINERS: Fix F: patterns that don't match anything Markus Armbruster
2018-08-10 14:39 ` Eric Blake
2018-08-10 15:06 ` Markus Armbruster
2018-08-13 7:54 ` Thomas Huth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.