* [igt-dev] [PATCH i-g-t] tools/intel_gpu_frequency: fix usage and examples
@ 2018-06-12 14:05 Jani Nikula
2018-06-12 14:27 ` Szwichtenberg, Radoslaw
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jani Nikula @ 2018-06-12 14:05 UTC (permalink / raw)
To: igt-dev; +Cc: jani.nikula
The cited commit removed --get suboptions but failed to update the usage
and examples. Remove the duplicated examples from the comments in the
interest of if not single but at least fewer points of truth.
Fixes: 20d6e0f41b3b ("tools/intel_gpu_frequency: remove use of getsubopt")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99492
Reported-by: Andreas Reis <andreas.reis@gmail.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
tools/intel_gpu_frequency.c | 37 ++++++-------------------------------
1 file changed, 6 insertions(+), 31 deletions(-)
diff --git a/tools/intel_gpu_frequency.c b/tools/intel_gpu_frequency.c
index 5c439b036a16..80786ad91570 100644
--- a/tools/intel_gpu_frequency.c
+++ b/tools/intel_gpu_frequency.c
@@ -1,5 +1,5 @@
/*
- * Copyright © 2015 Intel Corporation
+ * Copyright © 2015,2018 Intel Corporation
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
@@ -19,31 +19,6 @@
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
* DEALINGS IN THE SOFTWARE.
- *
- * Example:
- * Get all frequencies:
- * intel_gpu_frequency --get
- *
- * Same as above:
- * intel_gpu_frequency -g
- *
- * Lock the GPU frequency to 300MHz:
- * intel_gpu_frequency --set 300
- *
- * Set the maximum frequency to 900MHz:
- * intel_gpu_frequency --custom max=900
- *
- * Lock the GPU frequency to its maximum frequency:
- * intel_gpu_frequency --max
- *
- * Lock the GPU frequency to its most efficient frequency:
- * intel_gpu_frequency -e
- *
- * Lock The GPU frequency to its minimum frequency:
- * intel_gpu_frequency --min
- *
- * Reset the GPU to hardware defaults
- * intel_gpu_frequency -d
*/
#include <assert.h>
@@ -145,7 +120,7 @@ static void __attribute__((noreturn))
usage(const char *prog)
{
printf("%s A program to manipulate Intel GPU frequencies.\n\n", prog);
- printf("Usage: %s [-e] [--min | --max] [-g (min|max|efficient)] [-s frequency_mhz]\n\n", prog);
+ printf("Usage: %s [-e] [--min | --max] [--get] [--set frequency_mhz]\n\n", prog);
printf("Options: \n");
printf(" -e Lock frequency to the most efficient frequency\n");
printf(" -g, --get Get all the frequency settings\n");
@@ -158,9 +133,9 @@ usage(const char *prog)
printf(" -v --version Version\n");
printf("\n");
printf("Examples:\n");
- printf(" intel_gpu_frequency -gmin,cur\tGet the current and minimum frequency\n");
- printf(" intel_gpu_frequency -s 400\tLock frequency to 400Mhz\n");
- printf(" intel_gpu_frequency -c max=750\tSet the max frequency to 750MHz\n");
+ printf(" intel_gpu_frequency --get\t\tGet the current and minimum frequency\n");
+ printf(" intel_gpu_frequency --set 400\tLock frequency to 400Mhz\n");
+ printf(" intel_gpu_frequency --custom max=750\tSet the max frequency to 750MHz\n");
printf("\n");
printf("Report bugs to <bugs.freedesktop.org>\n");
exit(EXIT_FAILURE);
@@ -170,7 +145,7 @@ static void
version(const char *prog)
{
printf("%s: %s\n", prog, VERSION);
- printf("Copyright © 2015 Intel Corporation\n");
+ printf("Copyright © 2015,2018 Intel Corporation\n");
}
/* Returns read or write operation */
--
2.11.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tools/intel_gpu_frequency: fix usage and examples
2018-06-12 14:05 [igt-dev] [PATCH i-g-t] tools/intel_gpu_frequency: fix usage and examples Jani Nikula
@ 2018-06-12 14:27 ` Szwichtenberg, Radoslaw
2018-06-12 14:30 ` Jani Nikula
2018-06-12 14:39 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-06-12 19:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Szwichtenberg, Radoslaw @ 2018-06-12 14:27 UTC (permalink / raw)
To: igt-dev, Nikula, Jani
On Tue, 2018-06-12 at 17:05 +0300, Jani Nikula wrote:
> The cited commit removed --get suboptions but failed to update the usage
> and examples. Remove the duplicated examples from the comments in the
> interest of if not single but at least fewer points of truth.
>
> Fixes: 20d6e0f41b3b ("tools/intel_gpu_frequency: remove use of getsubopt")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99492
> Reported-by: Andreas Reis <andreas.reis@gmail.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tools/intel_gpu_frequency: fix usage and examples
2018-06-12 14:27 ` Szwichtenberg, Radoslaw
@ 2018-06-12 14:30 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2018-06-12 14:30 UTC (permalink / raw)
To: Szwichtenberg, Radoslaw, igt-dev
On Tue, 12 Jun 2018, "Szwichtenberg, Radoslaw" <radoslaw.szwichtenberg@intel.com> wrote:
> On Tue, 2018-06-12 at 17:05 +0300, Jani Nikula wrote:
>> The cited commit removed --get suboptions but failed to update the usage
>> and examples. Remove the duplicated examples from the comments in the
>> interest of if not single but at least fewer points of truth.
>>
>> Fixes: 20d6e0f41b3b ("tools/intel_gpu_frequency: remove use of getsubopt")
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99492
>> Reported-by: Andreas Reis <andreas.reis@gmail.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Reviewed-by: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com>
Thanks for the review, pushed.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tools/intel_gpu_frequency: fix usage and examples
2018-06-12 14:05 [igt-dev] [PATCH i-g-t] tools/intel_gpu_frequency: fix usage and examples Jani Nikula
2018-06-12 14:27 ` Szwichtenberg, Radoslaw
@ 2018-06-12 14:39 ` Patchwork
2018-06-12 19:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-06-12 14:39 UTC (permalink / raw)
To: Jani Nikula; +Cc: igt-dev
== Series Details ==
Series: tools/intel_gpu_frequency: fix usage and examples
URL : https://patchwork.freedesktop.org/series/44633/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4302 -> IGTPW_1450 =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1450 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1450, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/44633/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1450:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_gttfill@basic:
fi-pnv-d510: SKIP -> PASS
igt@gem_mmap_gtt@basic-small-bo-tiledy:
fi-gdg-551: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_1450 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: PASS -> DMESG-WARN (fdo#105128)
igt@kms_flip@basic-flip-vs-modeset:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106000)
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-cnl-psr: PASS -> FAIL (fdo#100368, fdo#103928)
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: PASS -> DMESG-FAIL (fdo#102614, fdo#106103)
==== Possible fixes ====
igt@gem_mmap_gtt@basic-small-bo-tiledx:
fi-gdg-551: FAIL (fdo#102575) -> SKIP
igt@kms_pipe_crc_basic@read-crc-pipe-c:
fi-glk-j4005: DMESG-WARN (fdo#106097, fdo#106000) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-cnl-psr: DMESG-WARN (fdo#104951) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#104951 https://bugs.freedesktop.org/show_bug.cgi?id=104951
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
== Participating hosts (41 -> 37) ==
Additional (2): fi-bdw-gvtdvm fi-skl-gvtdvm
Missing (6): fi-ilk-m540 fi-byt-j1900 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-skl-6700hq
== Build changes ==
* IGT: IGT_4513 -> IGTPW_1450
CI_DRM_4302: ef129f260b2bd362959651fe8e20e369bf3c977e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1450: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1450/
IGT_4513: 7b6838781441cfbc7f6c18f421f127dfb02b44cf @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1450/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tools/intel_gpu_frequency: fix usage and examples
2018-06-12 14:05 [igt-dev] [PATCH i-g-t] tools/intel_gpu_frequency: fix usage and examples Jani Nikula
2018-06-12 14:27 ` Szwichtenberg, Radoslaw
2018-06-12 14:39 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-06-12 19:18 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2018-06-12 19:18 UTC (permalink / raw)
To: Jani Nikula; +Cc: igt-dev
== Series Details ==
Series: tools/intel_gpu_frequency: fix usage and examples
URL : https://patchwork.freedesktop.org/series/44633/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4513_full -> IGTPW_1450_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1450_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_1450_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/44633/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in IGTPW_1450_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-blt:
shard-kbl: SKIP -> PASS +2
igt@gem_exec_schedule@deep-render:
shard-kbl: PASS -> SKIP
igt@pm_rc6_residency@rc6-accuracy:
shard-snb: PASS -> SKIP
== Known issues ==
Here are the changes found in IGTPW_1450_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_gtt:
shard-kbl: PASS -> INCOMPLETE (fdo#103665) +2
igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
shard-snb: PASS -> INCOMPLETE (fdo#105411)
igt@kms_flip@2x-flip-vs-wf_vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#100368)
igt@kms_flip@modeset-vs-vblank-race:
shard-hsw: PASS -> FAIL (fdo#103060)
igt@kms_flip_tiling@flip-to-y-tiled:
shard-glk: PASS -> FAIL (fdo#104724, fdo#103822)
igt@kms_flip_tiling@flip-y-tiled:
shard-glk: PASS -> FAIL (fdo#104724)
igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
shard-glk: PASS -> FAIL (fdo#104724, fdo#103167)
igt@kms_vblank@pipe-c-accuracy-idle:
shard-hsw: PASS -> FAIL (fdo#102583)
igt@testdisplay:
shard-glk: PASS -> INCOMPLETE (fdo#103359, k.org#198133)
==== Possible fixes ====
igt@drv_selftest@live_gtt:
shard-glk: FAIL (fdo#105347) -> PASS
igt@kms_flip@plain-flip-ts-check:
shard-hsw: FAIL (fdo#100368) -> PASS
igt@kms_rotation_crc@sprite-rotation-180:
shard-snb: FAIL (fdo#103925, fdo#104724) -> PASS
igt@perf@polling:
shard-hsw: FAIL (fdo#102252) -> PASS
==== Warnings ====
igt@gem_eio@suspend:
shard-snb: FAIL (fdo#105957) -> INCOMPLETE (fdo#105411)
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#102583 https://bugs.freedesktop.org/show_bug.cgi?id=102583
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105347 https://bugs.freedesktop.org/show_bug.cgi?id=105347
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105957 https://bugs.freedesktop.org/show_bug.cgi?id=105957
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* IGT: IGT_4513 -> IGTPW_1450
* Linux: CI_DRM_4294 -> CI_DRM_4302
CI_DRM_4294: af0889384edc6de2f91494325d571c66dffea83f @ git://anongit.freedesktop.org/gfx-ci/linux
CI_DRM_4302: ef129f260b2bd362959651fe8e20e369bf3c977e @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_1450: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1450/
IGT_4513: 7b6838781441cfbc7f6c18f421f127dfb02b44cf @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1450/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-06-12 19:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-12 14:05 [igt-dev] [PATCH i-g-t] tools/intel_gpu_frequency: fix usage and examples Jani Nikula
2018-06-12 14:27 ` Szwichtenberg, Radoslaw
2018-06-12 14:30 ` Jani Nikula
2018-06-12 14:39 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-06-12 19:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.