From: Kalle Valo <kvalo@codeaurora.org>
To: "Michael Büsch" <m@bues.ch>
Cc: "Larry Finger" <Larry.Finger@lwfinger.net>,
"Matt Redfearn" <matt.redfearn@mips.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Regression caused by commit 882164a4a928
Date: Mon, 07 May 2018 22:03:58 +0300 [thread overview]
Message-ID: <874ljj2spt.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180507204317.52992b6c@wiggum> ("Michael \=\?utf-8\?Q\?B\=C3\=BCs\?\= \=\?utf-8\?Q\?ch\=22's\?\= message of "Mon, 7 May 2018 20:43:17 +0200")
Michael B=C3=BCsch <m@bues.ch> writes:
> On Mon, 7 May 2018 10:44:34 -0500
> Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
>> Although commit 882164a4a928 ("ssb: Prevent build of PCI host features i=
n=20
>> module") appeared to be harmless, it leads to complete failure of driver=
s b43.=20
>
>> config SSB_DRIVER_PCICORE_POSSIBLE
>> bool
>> - depends on SSB_PCIHOST && SSB =3D y
>> + depends on SSB_PCIHOST && (SSB =3D y || !MIPS)
>> default y
>>=20
>> config SSB_DRIVER_PCICORE
>
>
> https://patchwork.kernel.org/patch/10161131/
>
> Could we _please_ switch to not applying patches to ssb or b43, if
> nobody acked (or better reviewed) a patch?
>
> We had multiple changes to ssb and b43 in the recent past that did not
> have a review at all and broke something. I don't think such software
> quality is acceptable at all.
> So please revert 882164a4a928.
Yes, someone please send a revert so that this can be fixed quickly for
v4.17.
> I'm sorry that this patch slipped through the cracks of my inbox.
> But the reaction to that shall not be to just apply the patch. It
> shall be to resubmit it for review.
The thing is that in general I do not have time to ping people for every
patch, I get enough of emails as is. If there are no review comments I
have to assume the patch is ok to apply.
But as ssb has had two major regressions recently I'm going to
significantly raise the bar for ssb patches, and will refuse to apply
random patches if they have not been tested with b43/b44.
--=20
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: "Michael Büsch" <m@bues.ch>
Cc: "Larry Finger" <Larry.Finger@lwfinger.net>,
"Matt Redfearn" <matt.redfearn@mips.com>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Regression caused by commit 882164a4a928
Date: Mon, 07 May 2018 22:03:58 +0300 [thread overview]
Message-ID: <874ljj2spt.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180507204317.52992b6c@wiggum> ("Michael \=\?utf-8\?Q\?B\=C3\=BCs\?\= \=\?utf-8\?Q\?ch\=22's\?\= message of "Mon, 7 May 2018 20:43:17 +0200")
Michael Büsch <m@bues.ch> writes:
> On Mon, 7 May 2018 10:44:34 -0500
> Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
>> Although commit 882164a4a928 ("ssb: Prevent build of PCI host features in
>> module") appeared to be harmless, it leads to complete failure of drivers b43.
>
>> config SSB_DRIVER_PCICORE_POSSIBLE
>> bool
>> - depends on SSB_PCIHOST && SSB = y
>> + depends on SSB_PCIHOST && (SSB = y || !MIPS)
>> default y
>>
>> config SSB_DRIVER_PCICORE
>
>
> https://patchwork.kernel.org/patch/10161131/
>
> Could we _please_ switch to not applying patches to ssb or b43, if
> nobody acked (or better reviewed) a patch?
>
> We had multiple changes to ssb and b43 in the recent past that did not
> have a review at all and broke something. I don't think such software
> quality is acceptable at all.
> So please revert 882164a4a928.
Yes, someone please send a revert so that this can be fixed quickly for
v4.17.
> I'm sorry that this patch slipped through the cracks of my inbox.
> But the reaction to that shall not be to just apply the patch. It
> shall be to resubmit it for review.
The thing is that in general I do not have time to ping people for every
patch, I get enough of emails as is. If there are no review comments I
have to assume the patch is ok to apply.
But as ssb has had two major regressions recently I'm going to
significantly raise the bar for ssb patches, and will refuse to apply
random patches if they have not been tested with b43/b44.
--
Kalle Valo
next prev parent reply other threads:[~2018-05-07 19:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 15:44 Regression caused by commit 882164a4a928 Larry Finger
2018-05-07 18:43 ` Michael Büsch
2018-05-07 19:03 ` Kalle Valo [this message]
2018-05-07 19:03 ` Kalle Valo
2018-05-07 19:30 ` Michael Büsch
2018-05-09 10:03 ` Kalle Valo
2018-05-09 10:03 ` Kalle Valo
2018-05-09 12:55 ` Matt Redfearn
2018-05-09 16:27 ` Michael Büsch
2018-05-10 10:24 ` Matt Redfearn
2018-05-10 11:09 ` Michael Büsch
2018-05-10 10:41 ` Rafał Miłecki
2018-05-10 10:41 ` Rafał Miłecki
2018-05-10 10:48 ` Rafał Miłecki
2018-05-10 10:48 ` Rafał Miłecki
2018-05-10 10:49 ` Matt Redfearn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ljj2spt.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m@bues.ch \
--cc=matt.redfearn@mips.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.