* [PATCH 0/1] HDMI 2.0 on CNL... not working...
@ 2017-11-10 22:26 Rodrigo Vivi
2017-11-10 22:26 ` [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL Rodrigo Vivi
` (4 more replies)
0 siblings, 5 replies; 16+ messages in thread
From: Rodrigo Vivi @ 2017-11-10 22:26 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
I'm just sending this patch for reference here since
this is the patch that I believe it is the correct one
to get HDMI 2.0 working on CNL.
However I'm just getting a blank screen when trying to use
HDMI at 4k@60Hz here... Maybe it is just my bad old cable
here... maybe I'm missing something... but I couldn't stop
yet to collect logs...
Any feedback, idea, help is very welcome.
Thanks,
Rodrigo.
Rodrigo Vivi (1):
drm/i915/cnl: Extend HDMI 2.0 support to CNL.
drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--
2.13.6
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL. 2017-11-10 22:26 [PATCH 0/1] HDMI 2.0 on CNL... not working Rodrigo Vivi @ 2017-11-10 22:26 ` Rodrigo Vivi 2017-11-10 22:45 ` [PATCH] " Rodrigo Vivi ` (2 more replies) 2017-11-10 22:42 ` ✗ Fi.CI.BAT: failure for HDMI 2.0 on CNL... not working Patchwork ` (3 subsequent siblings) 4 siblings, 3 replies; 16+ messages in thread From: Rodrigo Vivi @ 2017-11-10 22:26 UTC (permalink / raw) To: intel-gfx; +Cc: Paulo Zanoni, Rodrigo Vivi Starting on GLK we support HDMI 2.0. So this patch only extend the work Shashank has made to GLK to CNL. Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> Cc: Shashank Sharma <shashank.sharma@intel.com> Cc: Manasi Navare <manasi.d.navare@intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index 2d95db64cdf2..1b22b587e98c 100644 --- a/drivers/gpu/drm/i915/intel_hdmi.c +++ b/drivers/gpu/drm/i915/intel_hdmi.c @@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder) &dev_priv->vbt.ddi_port_info[encoder->port]; int max_tmds_clock; - if (IS_GEMINILAKE(dev_priv)) + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) max_tmds_clock = 594000; else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) max_tmds_clock = 300000; @@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, pipe_config->lane_count = 4; - if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) { + if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) || + INTEL_GEN(dev_priv) >= 10) { if (scdc->scrambling.low_rates) pipe_config->hdmi_scrambling = true; @@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, connector->doublescan_allowed = 0; connector->stereo_allowed = 1; - if (IS_GEMINILAKE(dev_priv)) + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) connector->ycbcr_420_allowed = true; intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port); -- 2.13.6 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] drm/i915/cnl: Extend HDMI 2.0 support to CNL. 2017-11-10 22:26 ` [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL Rodrigo Vivi @ 2017-11-10 22:45 ` Rodrigo Vivi 2017-11-10 23:50 ` [PATCH 1/1] " Manasi Navare 2017-11-11 9:43 ` Sharma, Shashank 2 siblings, 0 replies; 16+ messages in thread From: Rodrigo Vivi @ 2017-11-10 22:45 UTC (permalink / raw) To: intel-gfx; +Cc: Paulo Zanoni, Rodrigo Vivi Starting on GLK we support HDMI 2.0. So this patch only extend the work Shashank has made to GLK to CNL. v2: The version that compiles :/ Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> Cc: Shashank Sharma <shashank.sharma@intel.com> Cc: Manasi Navare <manasi.d.navare@intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> --- drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index 2d95db64cdf2..96c314a6170a 100644 --- a/drivers/gpu/drm/i915/intel_hdmi.c +++ b/drivers/gpu/drm/i915/intel_hdmi.c @@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder) &dev_priv->vbt.ddi_port_info[encoder->port]; int max_tmds_clock; - if (IS_GEMINILAKE(dev_priv)) + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) max_tmds_clock = 594000; else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) max_tmds_clock = 300000; @@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, pipe_config->lane_count = 4; - if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) { + if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) || + INTEL_GEN(dev_priv) >= 10)) { if (scdc->scrambling.low_rates) pipe_config->hdmi_scrambling = true; @@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, connector->doublescan_allowed = 0; connector->stereo_allowed = 1; - if (IS_GEMINILAKE(dev_priv)) + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) connector->ycbcr_420_allowed = true; intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port); -- 2.13.6 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL. 2017-11-10 22:26 ` [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL Rodrigo Vivi 2017-11-10 22:45 ` [PATCH] " Rodrigo Vivi @ 2017-11-10 23:50 ` Manasi Navare 2017-11-11 0:04 ` Rodrigo Vivi 2017-11-11 9:43 ` Sharma, Shashank 2 siblings, 1 reply; 16+ messages in thread From: Manasi Navare @ 2017-11-10 23:50 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx, Paulo Zanoni Looks good. But are these the only places that need change to support 2.0? Dont we need any changes in voltage swing programming or DDI clocks? Manasi` On Fri, Nov 10, 2017 at 02:26:26PM -0800, Rodrigo Vivi wrote: > Starting on GLK we support HDMI 2.0. So this patch only > extend the work Shashank has made to GLK to CNL. > > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> > Cc: Shashank Sharma <shashank.sharma@intel.com> > Cc: Manasi Navare <manasi.d.navare@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c > index 2d95db64cdf2..1b22b587e98c 100644 > --- a/drivers/gpu/drm/i915/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > @@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder) > &dev_priv->vbt.ddi_port_info[encoder->port]; > int max_tmds_clock; > > - if (IS_GEMINILAKE(dev_priv)) > + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) > max_tmds_clock = 594000; > else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) > max_tmds_clock = 300000; > @@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, > > pipe_config->lane_count = 4; > > - if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) { > + if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) || > + INTEL_GEN(dev_priv) >= 10) { > if (scdc->scrambling.low_rates) > pipe_config->hdmi_scrambling = true; > > @@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, > connector->doublescan_allowed = 0; > connector->stereo_allowed = 1; > > - if (IS_GEMINILAKE(dev_priv)) > + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) > connector->ycbcr_420_allowed = true; > > intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port); > -- > 2.13.6 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL. 2017-11-10 23:50 ` [PATCH 1/1] " Manasi Navare @ 2017-11-11 0:04 ` Rodrigo Vivi 2017-11-11 9:47 ` Sharma, Shashank 0 siblings, 1 reply; 16+ messages in thread From: Rodrigo Vivi @ 2017-11-11 0:04 UTC (permalink / raw) To: Manasi Navare; +Cc: intel-gfx, Paulo Zanoni On Fri, Nov 10, 2017 at 11:50:21PM +0000, Manasi Navare wrote: > Looks good. > But are these the only places that need change to support 2.0? > Dont we need any changes in voltage swing programming or DDI clocks? not that I'm aware of... but that would explain the blank screens... > > Manasi` > > On Fri, Nov 10, 2017 at 02:26:26PM -0800, Rodrigo Vivi wrote: > > Starting on GLK we support HDMI 2.0. So this patch only > > extend the work Shashank has made to GLK to CNL. > > > > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> > > Cc: Shashank Sharma <shashank.sharma@intel.com> > > Cc: Manasi Navare <manasi.d.navare@intel.com> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > --- > > drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c > > index 2d95db64cdf2..1b22b587e98c 100644 > > --- a/drivers/gpu/drm/i915/intel_hdmi.c > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > > @@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder) > > &dev_priv->vbt.ddi_port_info[encoder->port]; > > int max_tmds_clock; > > > > - if (IS_GEMINILAKE(dev_priv)) > > + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) > > max_tmds_clock = 594000; > > else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) > > max_tmds_clock = 300000; > > @@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, > > > > pipe_config->lane_count = 4; > > > > - if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) { > > + if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) || > > + INTEL_GEN(dev_priv) >= 10) { > > if (scdc->scrambling.low_rates) > > pipe_config->hdmi_scrambling = true; > > > > @@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, > > connector->doublescan_allowed = 0; > > connector->stereo_allowed = 1; > > > > - if (IS_GEMINILAKE(dev_priv)) > > + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) > > connector->ycbcr_420_allowed = true; > > > > intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port); > > -- > > 2.13.6 > > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL. 2017-11-11 0:04 ` Rodrigo Vivi @ 2017-11-11 9:47 ` Sharma, Shashank 2017-11-13 18:46 ` Rodrigo Vivi 0 siblings, 1 reply; 16+ messages in thread From: Sharma, Shashank @ 2017-11-11 9:47 UTC (permalink / raw) To: Rodrigo Vivi, Manasi Navare; +Cc: intel-gfx, Paulo Zanoni I am still waiting for the dmesg logs, Rodrigo :P I am pretty sure that you would have picked up if there is a general problem, wit the modeset or HDMI. I just want to check what is following from the mode and monitor combination during blankout: - is the mode YCBCR420 ? - is scrambling enabled ? - does the monitor supports 4k@60 RGB (594Mhz) or its 4k@60 YCBCR420 (300Mhz) - are we in 12 BPC deep color mode ? - is this a CEA 4k@60 mode, or other one ? Regards Shashank On 11/11/2017 5:34 AM, Rodrigo Vivi wrote: > On Fri, Nov 10, 2017 at 11:50:21PM +0000, Manasi Navare wrote: >> Looks good. >> But are these the only places that need change to support 2.0? >> Dont we need any changes in voltage swing programming or DDI clocks? > not that I'm aware of... but that would explain the blank screens... > >> Manasi` >> >> On Fri, Nov 10, 2017 at 02:26:26PM -0800, Rodrigo Vivi wrote: >>> Starting on GLK we support HDMI 2.0. So this patch only >>> extend the work Shashank has made to GLK to CNL. >>> >>> Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> >>> Cc: Shashank Sharma <shashank.sharma@intel.com> >>> Cc: Manasi Navare <manasi.d.navare@intel.com> >>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> >>> --- >>> drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- >>> 1 file changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c >>> index 2d95db64cdf2..1b22b587e98c 100644 >>> --- a/drivers/gpu/drm/i915/intel_hdmi.c >>> +++ b/drivers/gpu/drm/i915/intel_hdmi.c >>> @@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder) >>> &dev_priv->vbt.ddi_port_info[encoder->port]; >>> int max_tmds_clock; >>> >>> - if (IS_GEMINILAKE(dev_priv)) >>> + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) >>> max_tmds_clock = 594000; >>> else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) >>> max_tmds_clock = 300000; >>> @@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, >>> >>> pipe_config->lane_count = 4; >>> >>> - if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) { >>> + if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) || >>> + INTEL_GEN(dev_priv) >= 10) { >>> if (scdc->scrambling.low_rates) >>> pipe_config->hdmi_scrambling = true; >>> >>> @@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, >>> connector->doublescan_allowed = 0; >>> connector->stereo_allowed = 1; >>> >>> - if (IS_GEMINILAKE(dev_priv)) >>> + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) >>> connector->ycbcr_420_allowed = true; >>> >>> intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port); >>> -- >>> 2.13.6 >>> _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL. 2017-11-11 9:47 ` Sharma, Shashank @ 2017-11-13 18:46 ` Rodrigo Vivi 0 siblings, 0 replies; 16+ messages in thread From: Rodrigo Vivi @ 2017-11-13 18:46 UTC (permalink / raw) To: Sharma, Shashank; +Cc: intel-gfx, Paulo Zanoni On Sat, Nov 11, 2017 at 09:47:40AM +0000, Sharma, Shashank wrote: > I am still waiting for the dmesg logs, Rodrigo :P > > I am pretty sure that you would have picked up if there is a general > problem, wit the modeset or HDMI. yep... my bad... sorry... We will provide that soon. > > I just want to check what is following from the mode and monitor combination > during blankout: > > - is the mode YCBCR420 ? > > - is scrambling enabled ? > > - does the monitor supports 4k@60 RGB (594Mhz) or its 4k@60 YCBCR420 > (300Mhz) > > - are we in 12 BPC deep color mode ? > - is this a CEA 4k@60 mode, or other one ? > > Regards > Shashank > On 11/11/2017 5:34 AM, Rodrigo Vivi wrote: > > On Fri, Nov 10, 2017 at 11:50:21PM +0000, Manasi Navare wrote: > > > Looks good. > > > But are these the only places that need change to support 2.0? > > > Dont we need any changes in voltage swing programming or DDI clocks? > > not that I'm aware of... but that would explain the blank screens... > > > > > Manasi` > > > > > > On Fri, Nov 10, 2017 at 02:26:26PM -0800, Rodrigo Vivi wrote: > > > > Starting on GLK we support HDMI 2.0. So this patch only > > > > extend the work Shashank has made to GLK to CNL. > > > > > > > > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> > > > > Cc: Shashank Sharma <shashank.sharma@intel.com> > > > > Cc: Manasi Navare <manasi.d.navare@intel.com> > > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > > --- > > > > drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- > > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c > > > > index 2d95db64cdf2..1b22b587e98c 100644 > > > > --- a/drivers/gpu/drm/i915/intel_hdmi.c > > > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > > > > @@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder) > > > > &dev_priv->vbt.ddi_port_info[encoder->port]; > > > > int max_tmds_clock; > > > > - if (IS_GEMINILAKE(dev_priv)) > > > > + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) > > > > max_tmds_clock = 594000; > > > > else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) > > > > max_tmds_clock = 300000; > > > > @@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, > > > > pipe_config->lane_count = 4; > > > > - if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) { > > > > + if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) || > > > > + INTEL_GEN(dev_priv) >= 10) { > > > > if (scdc->scrambling.low_rates) > > > > pipe_config->hdmi_scrambling = true; > > > > @@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, > > > > connector->doublescan_allowed = 0; > > > > connector->stereo_allowed = 1; > > > > - if (IS_GEMINILAKE(dev_priv)) > > > > + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) > > > > connector->ycbcr_420_allowed = true; > > > > intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port); > > > > -- > > > > 2.13.6 > > > > > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL. 2017-11-10 22:26 ` [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL Rodrigo Vivi 2017-11-10 22:45 ` [PATCH] " Rodrigo Vivi 2017-11-10 23:50 ` [PATCH 1/1] " Manasi Navare @ 2017-11-11 9:43 ` Sharma, Shashank 2017-11-13 18:47 ` Rodrigo Vivi 2 siblings, 1 reply; 16+ messages in thread From: Sharma, Shashank @ 2017-11-11 9:43 UTC (permalink / raw) To: Rodrigo Vivi, intel-gfx; +Cc: Paulo Zanoni Regards Shashank On 11/11/2017 3:56 AM, Rodrigo Vivi wrote: > Starting on GLK we support HDMI 2.0. So this patch only > extend the work Shashank has made to GLK to CNL. > > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> > Cc: Shashank Sharma <shashank.sharma@intel.com> > Cc: Manasi Navare <manasi.d.navare@intel.com> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c > index 2d95db64cdf2..1b22b587e98c 100644 > --- a/drivers/gpu/drm/i915/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > @@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder) > &dev_priv->vbt.ddi_port_info[encoder->port]; > int max_tmds_clock; > > - if (IS_GEMINILAKE(dev_priv)) > + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) Would it be a good idea to create a new macro called IS_HDMI2_SUPPORTED() or a function is_hdmi2_supported() where we keep all the GEN check ? > max_tmds_clock = 594000; > else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) > max_tmds_clock = 300000; > @@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, > > pipe_config->lane_count = 4; > > - if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) { > + if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) || > + INTEL_GEN(dev_priv) >= 10) { > if (scdc->scrambling.low_rates) > pipe_config->hdmi_scrambling = true; > > @@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, > connector->doublescan_allowed = 0; > connector->stereo_allowed = 1; > > - if (IS_GEMINILAKE(dev_priv)) > + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) > connector->ycbcr_420_allowed = true; Looks good otherwise. - Shashank > > intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port); _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL. 2017-11-11 9:43 ` Sharma, Shashank @ 2017-11-13 18:47 ` Rodrigo Vivi 2017-11-15 19:05 ` David Weinehall 0 siblings, 1 reply; 16+ messages in thread From: Rodrigo Vivi @ 2017-11-13 18:47 UTC (permalink / raw) To: Sharma, Shashank; +Cc: intel-gfx, Paulo Zanoni On Sat, Nov 11, 2017 at 09:43:44AM +0000, Sharma, Shashank wrote: > Regards > > Shashank > > > On 11/11/2017 3:56 AM, Rodrigo Vivi wrote: > > Starting on GLK we support HDMI 2.0. So this patch only > > extend the work Shashank has made to GLK to CNL. > > > > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> > > Cc: Shashank Sharma <shashank.sharma@intel.com> > > Cc: Manasi Navare <manasi.d.navare@intel.com> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > --- > > drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c > > index 2d95db64cdf2..1b22b587e98c 100644 > > --- a/drivers/gpu/drm/i915/intel_hdmi.c > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > > @@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder) > > &dev_priv->vbt.ddi_port_info[encoder->port]; > > int max_tmds_clock; > > - if (IS_GEMINILAKE(dev_priv)) > > + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) > Would it be a good idea to create a new macro called IS_HDMI2_SUPPORTED() or > a function is_hdmi2_supported() where we keep all the GEN check ? I asked myself the same question. I believe a IS_HDMI2_SUPPORTED or HAS_HDMI2_SUPPORT is a good idea... > > max_tmds_clock = 594000; > > else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) > > max_tmds_clock = 300000; > > @@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, > > pipe_config->lane_count = 4; > > - if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) { > > + if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) || > > + INTEL_GEN(dev_priv) >= 10) { > > if (scdc->scrambling.low_rates) > > pipe_config->hdmi_scrambling = true; > > @@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, > > connector->doublescan_allowed = 0; > > connector->stereo_allowed = 1; > > - if (IS_GEMINILAKE(dev_priv)) > > + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) > > connector->ycbcr_420_allowed = true; > Looks good otherwise. > - Shashank > > intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port); > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL. 2017-11-13 18:47 ` Rodrigo Vivi @ 2017-11-15 19:05 ` David Weinehall 2017-11-17 13:09 ` Jani Nikula 0 siblings, 1 reply; 16+ messages in thread From: David Weinehall @ 2017-11-15 19:05 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx, Paulo Zanoni On Mon, Nov 13, 2017 at 10:47:44AM -0800, Rodrigo Vivi wrote: > On Sat, Nov 11, 2017 at 09:43:44AM +0000, Sharma, Shashank wrote: > > Regards > > > > Shashank > > > > > > On 11/11/2017 3:56 AM, Rodrigo Vivi wrote: > > > Starting on GLK we support HDMI 2.0. So this patch only > > > extend the work Shashank has made to GLK to CNL. > > > > > > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> > > > Cc: Shashank Sharma <shashank.sharma@intel.com> > > > Cc: Manasi Navare <manasi.d.navare@intel.com> > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > --- > > > drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c > > > index 2d95db64cdf2..1b22b587e98c 100644 > > > --- a/drivers/gpu/drm/i915/intel_hdmi.c > > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c > > > @@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder) > > > &dev_priv->vbt.ddi_port_info[encoder->port]; > > > int max_tmds_clock; > > > - if (IS_GEMINILAKE(dev_priv)) > > > + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) > > Would it be a good idea to create a new macro called IS_HDMI2_SUPPORTED() or > > a function is_hdmi2_supported() where we keep all the GEN check ? > > I asked myself the same question. > I believe a IS_HDMI2_SUPPORTED or HAS_HDMI2_SUPPORT is a good idea... Typically we use HAS_* to check whether a feature is available, and IS_* to identify a platform, or whether the parameter passed is of a certain type. So I believe HAS_HDMI2_SUPPORT would be correct if it's to check whether the platform supports HDMI2. > > > max_tmds_clock = 594000; > > > else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) > > > max_tmds_clock = 300000; > > > @@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, > > > pipe_config->lane_count = 4; > > > - if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) { > > > + if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) || > > > + INTEL_GEN(dev_priv) >= 10) { > > > if (scdc->scrambling.low_rates) > > > pipe_config->hdmi_scrambling = true; > > > @@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, > > > connector->doublescan_allowed = 0; > > > connector->stereo_allowed = 1; > > > - if (IS_GEMINILAKE(dev_priv)) > > > + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) > > > connector->ycbcr_420_allowed = true; > > Looks good otherwise. > > - Shashank > > > intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port); > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL. 2017-11-15 19:05 ` David Weinehall @ 2017-11-17 13:09 ` Jani Nikula 0 siblings, 0 replies; 16+ messages in thread From: Jani Nikula @ 2017-11-17 13:09 UTC (permalink / raw) To: David Weinehall, Rodrigo Vivi; +Cc: intel-gfx, Paulo Zanoni On Wed, 15 Nov 2017, David Weinehall <david.weinehall@linux.intel.com> wrote: > On Mon, Nov 13, 2017 at 10:47:44AM -0800, Rodrigo Vivi wrote: >> On Sat, Nov 11, 2017 at 09:43:44AM +0000, Sharma, Shashank wrote: >> > Regards >> > >> > Shashank >> > >> > >> > On 11/11/2017 3:56 AM, Rodrigo Vivi wrote: >> > > Starting on GLK we support HDMI 2.0. So this patch only >> > > extend the work Shashank has made to GLK to CNL. >> > > >> > > Cc: Paulo Zanoni <paulo.r.zanoni@intel.com> >> > > Cc: Shashank Sharma <shashank.sharma@intel.com> >> > > Cc: Manasi Navare <manasi.d.navare@intel.com> >> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> >> > > --- >> > > drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- >> > > 1 file changed, 4 insertions(+), 3 deletions(-) >> > > >> > > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c >> > > index 2d95db64cdf2..1b22b587e98c 100644 >> > > --- a/drivers/gpu/drm/i915/intel_hdmi.c >> > > +++ b/drivers/gpu/drm/i915/intel_hdmi.c >> > > @@ -1235,7 +1235,7 @@ static int intel_hdmi_source_max_tmds_clock(struct intel_encoder *encoder) >> > > &dev_priv->vbt.ddi_port_info[encoder->port]; >> > > int max_tmds_clock; >> > > - if (IS_GEMINILAKE(dev_priv)) >> > > + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) >> > Would it be a good idea to create a new macro called IS_HDMI2_SUPPORTED() or >> > a function is_hdmi2_supported() where we keep all the GEN check ? >> >> I asked myself the same question. >> I believe a IS_HDMI2_SUPPORTED or HAS_HDMI2_SUPPORT is a good idea... > > Typically we use HAS_* to check whether a feature is available, > and IS_* to identify a platform, or whether the parameter passed is of a certain > type. > > So I believe HAS_HDMI2_SUPPORT would be correct if it's to check whether > the platform supports HDMI2. I'd rather this was more like the DP code. There's none of this "has DP x.y support" kind of thing for the source. Instead, we look at *features* within those specs. "supports hbr2" and so on. And those checks tend to be more limited in scope than an overarching "hdmi 2.0 support". BR, Jani. > >> > > max_tmds_clock = 594000; >> > > else if (INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) >> > > max_tmds_clock = 300000; >> > > @@ -1511,7 +1511,8 @@ bool intel_hdmi_compute_config(struct intel_encoder *encoder, >> > > pipe_config->lane_count = 4; >> > > - if (scdc->scrambling.supported && IS_GEMINILAKE(dev_priv)) { >> > > + if (scdc->scrambling.supported && (IS_GEMINILAKE(dev_priv) || >> > > + INTEL_GEN(dev_priv) >= 10) { >> > > if (scdc->scrambling.low_rates) >> > > pipe_config->hdmi_scrambling = true; >> > > @@ -2033,7 +2034,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port, >> > > connector->doublescan_allowed = 0; >> > > connector->stereo_allowed = 1; >> > > - if (IS_GEMINILAKE(dev_priv)) >> > > + if (IS_GEMINILAKE(dev_priv) || INTEL_GEN(dev_priv) >= 10) >> > > connector->ycbcr_420_allowed = true; >> > Looks good otherwise. >> > - Shashank >> > > intel_hdmi->ddc_bus = intel_hdmi_ddc_pin(dev_priv, port); >> > >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* ✗ Fi.CI.BAT: failure for HDMI 2.0 on CNL... not working... 2017-11-10 22:26 [PATCH 0/1] HDMI 2.0 on CNL... not working Rodrigo Vivi 2017-11-10 22:26 ` [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL Rodrigo Vivi @ 2017-11-10 22:42 ` Patchwork 2017-11-10 23:17 ` ✓ Fi.CI.BAT: success for HDMI 2.0 on CNL... not working... (rev2) Patchwork ` (2 subsequent siblings) 4 siblings, 0 replies; 16+ messages in thread From: Patchwork @ 2017-11-10 22:42 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx == Series Details == Series: HDMI 2.0 on CNL... not working... URL : https://patchwork.freedesktop.org/series/33640/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h CHK include/generated/bounds.h CHK include/generated/timeconst.h CHK include/generated/asm-offsets.h CALL scripts/checksyscalls.sh CHK scripts/mod/devicetable-offsets.h CHK include/generated/compile.h CHK kernel/config_data.h CC [M] drivers/gpu/drm/i915/intel_hdmi.o drivers/gpu/drm/i915/intel_hdmi.c: In function ‘intel_hdmi_compute_config’: drivers/gpu/drm/i915/intel_hdmi.c:1515:36: error: expected ‘)’ before ‘{’ token INTEL_GEN(dev_priv) >= 10) { ^ drivers/gpu/drm/i915/intel_hdmi.c:1526:1: error: expected expression before ‘}’ token } ^ drivers/gpu/drm/i915/intel_hdmi.c:1526:1: error: control reaches end of non-void function [-Werror=return-type] } ^ cc1: all warnings being treated as errors scripts/Makefile.build:314: recipe for target 'drivers/gpu/drm/i915/intel_hdmi.o' failed make[4]: *** [drivers/gpu/drm/i915/intel_hdmi.o] Error 1 scripts/Makefile.build:573: recipe for target 'drivers/gpu/drm/i915' failed make[3]: *** [drivers/gpu/drm/i915] Error 2 scripts/Makefile.build:573: recipe for target 'drivers/gpu/drm' failed make[2]: *** [drivers/gpu/drm] Error 2 scripts/Makefile.build:573: recipe for target 'drivers/gpu' failed make[1]: *** [drivers/gpu] Error 2 Makefile:1024: recipe for target 'drivers' failed make: *** [drivers] Error 2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* ✓ Fi.CI.BAT: success for HDMI 2.0 on CNL... not working... (rev2) 2017-11-10 22:26 [PATCH 0/1] HDMI 2.0 on CNL... not working Rodrigo Vivi 2017-11-10 22:26 ` [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL Rodrigo Vivi 2017-11-10 22:42 ` ✗ Fi.CI.BAT: failure for HDMI 2.0 on CNL... not working Patchwork @ 2017-11-10 23:17 ` Patchwork 2017-11-11 1:13 ` ✗ Fi.CI.IGT: warning " Patchwork 2017-11-12 23:29 ` [PATCH 0/1] HDMI 2.0 on CNL... not working Mike Lothian 4 siblings, 0 replies; 16+ messages in thread From: Patchwork @ 2017-11-10 23:17 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx == Series Details == Series: HDMI 2.0 on CNL... not working... (rev2) URL : https://patchwork.freedesktop.org/series/33640/ State : success == Summary == Series 33640v2 HDMI 2.0 on CNL... not working... https://patchwork.freedesktop.org/api/1.0/series/33640/revisions/2/mbox/ Test gem_exec_reloc: Subgroup basic-gtt-read-active: fail -> PASS (fi-gdg-551) fdo#102582 fdo#102582 https://bugs.freedesktop.org/show_bug.cgi?id=102582 fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:446s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:452s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:383s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:532s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:274s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:500s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:504s fi-byt-j1900 total:289 pass:254 dwarn:0 dfail:0 fail:0 skip:35 time:495s fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:492s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:431s fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:261s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:548s fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:427s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:436s fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:426s fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:467s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:459s fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:489s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:521s fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:478s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:534s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:454s fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:546s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:567s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:521s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:498s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:460s fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:558s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:419s Blacklisted hosts: fi-cfl-s total:289 pass:254 dwarn:3 dfail:0 fail:0 skip:32 time:534s fi-cnl-y total:289 pass:261 dwarn:0 dfail:0 fail:1 skip:27 time:552s fi-glk-dsi total:289 pass:257 dwarn:0 dfail:0 fail:2 skip:30 time:513s 1342299348dec3bd4890284390a2209a00beafce drm-tip: 2017y-11m-10d-18h-11m-22s UTC integration manifest f23baddaee6b drm/i915/cnl: Extend HDMI 2.0 support to CNL. == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7074/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* ✗ Fi.CI.IGT: warning for HDMI 2.0 on CNL... not working... (rev2) 2017-11-10 22:26 [PATCH 0/1] HDMI 2.0 on CNL... not working Rodrigo Vivi ` (2 preceding siblings ...) 2017-11-10 23:17 ` ✓ Fi.CI.BAT: success for HDMI 2.0 on CNL... not working... (rev2) Patchwork @ 2017-11-11 1:13 ` Patchwork 2017-11-12 23:29 ` [PATCH 0/1] HDMI 2.0 on CNL... not working Mike Lothian 4 siblings, 0 replies; 16+ messages in thread From: Patchwork @ 2017-11-11 1:13 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx == Series Details == Series: HDMI 2.0 on CNL... not working... (rev2) URL : https://patchwork.freedesktop.org/series/33640/ State : warning == Summary == Test kms_setmode: Subgroup basic: fail -> PASS (shard-hsw) fdo#99912 Test kms_frontbuffer_tracking: Subgroup fbc-rgb101010-draw-mmap-gtt: pass -> SKIP (shard-hsw) fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912 shard-hsw total:2584 pass:1470 dwarn:4 dfail:2 fail:8 skip:1100 time:9425s Blacklisted hosts: shard-apl total:2584 pass:1622 dwarn:2 dfail:1 fail:23 skip:936 time:13280s shard-kbl total:2565 pass:1692 dwarn:17 dfail:4 fail:23 skip:828 time:10826s shard-snb total:2584 pass:1198 dwarn:3 dfail:2 fail:11 skip:1370 time:7795s == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7074/shards.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/1] HDMI 2.0 on CNL... not working... 2017-11-10 22:26 [PATCH 0/1] HDMI 2.0 on CNL... not working Rodrigo Vivi ` (3 preceding siblings ...) 2017-11-11 1:13 ` ✗ Fi.CI.IGT: warning " Patchwork @ 2017-11-12 23:29 ` Mike Lothian 2017-11-13 18:45 ` Rodrigo Vivi 4 siblings, 1 reply; 16+ messages in thread From: Mike Lothian @ 2017-11-12 23:29 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 913 bytes --] Hi You will need a HDMI 2 cable Regards Mike On Fri, 10 Nov 2017, 10:27 pm Rodrigo Vivi, <rodrigo.vivi@intel.com> wrote: > I'm just sending this patch for reference here since > this is the patch that I believe it is the correct one > to get HDMI 2.0 working on CNL. > > However I'm just getting a blank screen when trying to use > HDMI at 4k@60Hz here... Maybe it is just my bad old cable > here... maybe I'm missing something... but I couldn't stop > yet to collect logs... > > Any feedback, idea, help is very welcome. > > Thanks, > Rodrigo. > > Rodrigo Vivi (1): > drm/i915/cnl: Extend HDMI 2.0 support to CNL. > > drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > -- > 2.13.6 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > [-- Attachment #1.2: Type: text/html, Size: 1485 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/1] HDMI 2.0 on CNL... not working... 2017-11-12 23:29 ` [PATCH 0/1] HDMI 2.0 on CNL... not working Mike Lothian @ 2017-11-13 18:45 ` Rodrigo Vivi 0 siblings, 0 replies; 16+ messages in thread From: Rodrigo Vivi @ 2017-11-13 18:45 UTC (permalink / raw) To: Mike Lothian; +Cc: intel-gfx On Sun, Nov 12, 2017 at 11:29:28PM +0000, Mike Lothian wrote: > Hi > > You will need a HDMI 2 cable Yes, I wonder already if that was the case... So we have a new HDMI cable type? a high-higher-speed? Or the regular high speed should be enough? Anyways we are trying to get a "certified" hdmi 2.0 cable here :/ Thanks, Rodrigo. > > Regards > > Mike > > > On Fri, 10 Nov 2017, 10:27 pm Rodrigo Vivi, <rodrigo.vivi@intel.com> wrote: > > I'm just sending this patch for reference here since > this is the patch that I believe it is the correct one > to get HDMI 2.0 working on CNL. > > However I'm just getting a blank screen when trying to use > HDMI at 4k@60Hz here... Maybe it is just my bad old cable > here... maybe I'm missing something... but I couldn't stop > yet to collect logs... > > Any feedback, idea, help is very welcome. > > Thanks, > Rodrigo. > > Rodrigo Vivi (1): > drm/i915/cnl: Extend HDMI 2.0 support to CNL. > > drivers/gpu/drm/i915/intel_hdmi.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > -- > 2.13.6 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2017-11-17 13:08 UTC | newest] Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-11-10 22:26 [PATCH 0/1] HDMI 2.0 on CNL... not working Rodrigo Vivi 2017-11-10 22:26 ` [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL Rodrigo Vivi 2017-11-10 22:45 ` [PATCH] " Rodrigo Vivi 2017-11-10 23:50 ` [PATCH 1/1] " Manasi Navare 2017-11-11 0:04 ` Rodrigo Vivi 2017-11-11 9:47 ` Sharma, Shashank 2017-11-13 18:46 ` Rodrigo Vivi 2017-11-11 9:43 ` Sharma, Shashank 2017-11-13 18:47 ` Rodrigo Vivi 2017-11-15 19:05 ` David Weinehall 2017-11-17 13:09 ` Jani Nikula 2017-11-10 22:42 ` ✗ Fi.CI.BAT: failure for HDMI 2.0 on CNL... not working Patchwork 2017-11-10 23:17 ` ✓ Fi.CI.BAT: success for HDMI 2.0 on CNL... not working... (rev2) Patchwork 2017-11-11 1:13 ` ✗ Fi.CI.IGT: warning " Patchwork 2017-11-12 23:29 ` [PATCH 0/1] HDMI 2.0 on CNL... not working Mike Lothian 2017-11-13 18:45 ` Rodrigo Vivi
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.