All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: John Youn <John.Youn@synopsys.com>,
	Stefan Wahren <stefan.wahren@i2se.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>John Youn
	<John.Youn@synopsys.com>
Cc: Felipe Balbi <balbi@kernel.org>,
	Stephen Warren <swarren@wwwdotorg.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-rpi-kernel@lists.infradead.org"
	<linux-rpi-kernel@lists.infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 RFC 1/6] usb: dwc2: core: Avoid nonsense error in gadget mode
Date: Tue, 16 Aug 2016 09:22:56 -0700	[thread overview]
Message-ID: <874m6kel9b.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <92280b0f-4dd3-bcf5-57ed-277a9f91653d@synopsys.com>


[-- Attachment #1.1: Type: text/plain, Size: 837 bytes --]

John Youn <John.Youn@synopsys.com> writes:

> On 7/26/2016 11:54 AM, Stefan Wahren wrote:
>> In gadget mode On bcm2835 platform the host tx fifo size could be zero.
>> So add zero to range and avoid such nonsense errors:
>> 
>> dwc2 20980000.usb: 0 invalid for host_nperio_tx_fifo_size.
>> dwc2 20980000.usb: Setting host_nperio_tx_fifo_size to 0
>> dwc2 20980000.usb: 0 invalid for host_perio_tx_fifo_size.
>> dwc2 20980000.usb: Setting host_perio_tx_fifo_size to 0
>
> Hi Stefan,
>
> Are those the power on reset values of GNPTXFSIZ and HPTXFSIZ?
>
> If these values can be 0, I think the patch is ok. But I'm not sure
> about that. I can check with some hardware engineers to see under what
> conditions this is possible.

FWIW, I don't see the firmware software doing any conditional setting of
these registers.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: eric@anholt.net (Eric Anholt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 RFC 1/6] usb: dwc2: core: Avoid nonsense error in gadget mode
Date: Tue, 16 Aug 2016 09:22:56 -0700	[thread overview]
Message-ID: <874m6kel9b.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <92280b0f-4dd3-bcf5-57ed-277a9f91653d@synopsys.com>

John Youn <John.Youn@synopsys.com> writes:

> On 7/26/2016 11:54 AM, Stefan Wahren wrote:
>> In gadget mode On bcm2835 platform the host tx fifo size could be zero.
>> So add zero to range and avoid such nonsense errors:
>> 
>> dwc2 20980000.usb: 0 invalid for host_nperio_tx_fifo_size.
>> dwc2 20980000.usb: Setting host_nperio_tx_fifo_size to 0
>> dwc2 20980000.usb: 0 invalid for host_perio_tx_fifo_size.
>> dwc2 20980000.usb: Setting host_perio_tx_fifo_size to 0
>
> Hi Stefan,
>
> Are those the power on reset values of GNPTXFSIZ and HPTXFSIZ?
>
> If these values can be 0, I think the patch is ok. But I'm not sure
> about that. I can check with some hardware engineers to see under what
> conditions this is possible.

FWIW, I don't see the firmware software doing any conditional setting of
these registers.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160816/1c385e8e/attachment-0001.sig>

  reply	other threads:[~2016-08-16 16:22 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-26 18:53 [PATCH V2 RFC 0/6] ARM: dts: bcm2835: Add Raspberry Pi Zero Stefan Wahren
2016-07-26 18:53 ` Stefan Wahren
     [not found] ` <1469559213-16160-1-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2016-07-26 18:53   ` [PATCH V2 RFC 1/6] usb: dwc2: core: Avoid nonsense error in gadget mode Stefan Wahren
2016-07-26 18:53     ` Stefan Wahren
2016-08-16  1:30     ` John Youn
2016-08-16  1:30       ` John Youn
2016-08-16 16:22       ` Eric Anholt [this message]
2016-08-16 16:22         ` Eric Anholt
2016-08-16 16:44       ` Stefan Wahren
2016-08-16 16:44         ` Stefan Wahren
     [not found]         ` <2008594325.331112.5842a41f-9d6d-4b55-baac-1529d6cae164.open-xchange-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2016-08-16 19:20           ` John Youn
2016-08-16 19:20             ` John Youn
     [not found]             ` <69b9522a-ca23-cc32-ec90-8d59f63e4e03-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-08-16 20:09               ` Stefan Wahren
2016-08-16 20:09                 ` Stefan Wahren
2016-07-26 18:53   ` [PATCH V2 RFC 2/6] usb: dwc2: Add DT properties to specify fifo size in host/otg mode Stefan Wahren
2016-07-26 18:53     ` Stefan Wahren
     [not found]     ` <1469559213-16160-3-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2016-07-29 21:12       ` Rob Herring
2016-07-29 21:12         ` Rob Herring
2016-08-18 18:12     ` John Youn
2016-08-18 18:12       ` John Youn
2016-07-26 18:53   ` [PATCH V2 RFC 3/6] ARM: dts: bcm283x: Add missing usb clock Stefan Wahren
2016-07-26 18:53     ` Stefan Wahren
2016-07-26 18:53   ` [PATCH V2 RFC 4/6] ARM: dts: bcm283x: Add generic USB PHY Stefan Wahren
2016-07-26 18:53     ` Stefan Wahren
2016-07-26 18:53   ` [PATCH V2 RFC 5/6] DT: bindings: bcm: Add Raspberry Pi Zero Stefan Wahren
2016-07-26 18:53     ` Stefan Wahren
     [not found]     ` <1469559213-16160-6-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2016-07-29 21:13       ` Rob Herring
2016-07-29 21:13         ` Rob Herring
2016-07-26 18:53   ` [PATCH V2 RFC 6/6] ARM: dts: bcm2835: " Stefan Wahren
2016-07-26 18:53     ` Stefan Wahren
     [not found]     ` <1469559213-16160-7-git-send-email-stefan.wahren-eS4NqCHxEME@public.gmane.org>
2016-08-02 17:19       ` Stephen Warren
2016-08-02 17:19         ` Stephen Warren
2016-08-02 19:29         ` Stefan Wahren
2016-08-02 19:29           ` Stefan Wahren
     [not found]           ` <1427745143.15570.152fe5dd-527b-4ad6-b2fd-e4b0af6bc2a9.open-xchange-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2016-08-02 20:56             ` Stephen Warren
2016-08-02 20:56               ` Stephen Warren
2016-08-16 19:30       ` John Youn
2016-08-16 19:30         ` John Youn
     [not found]         ` <722dafcb-2f67-88c7-69df-d442c56c058f-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-08-16 19:58           ` Stefan Wahren
2016-08-16 19:58             ` Stefan Wahren
     [not found]             ` <263309088.290419.51598113-17aa-4db0-9dc0-6e58e3fafe07.open-xchange-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2016-08-16 22:07               ` John Youn
2016-08-16 22:07                 ` John Youn
     [not found]                 ` <ac20c0e9-0cab-7e3f-4abf-75223538a816-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-08-17 19:11                   ` Stefan Wahren
2016-08-17 19:11                     ` Stefan Wahren
     [not found]                     ` <1270178266.398560.152fe5dd-527b-4ad6-b2fd-e4b0af6bc2a9.open-xchange-7tX72C7vayboQLBSYMtkGA@public.gmane.org>
2016-08-17 21:21                       ` John Youn
2016-08-17 21:21                         ` John Youn
     [not found]                         ` <badc3aa5-29ac-9b8c-2531-564c44b60030-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-08-17 22:17                           ` Stefan Wahren
2016-08-17 22:17                             ` Stefan Wahren
2016-08-18 18:03                             ` John Youn
2016-08-18 18:03                               ` John Youn
2016-08-18 19:04                               ` Stefan Wahren
2016-08-18 19:04                                 ` Stefan Wahren
2016-08-18 19:34                                 ` John Youn
2016-08-18 19:34                                   ` John Youn
2016-08-18 18:14 ` [PATCH V2 RFC 0/6] " Eric Anholt
2016-08-18 18:14   ` Eric Anholt
2016-08-18 18:57   ` Stefan Wahren
2016-08-18 18:57     ` Stefan Wahren
2016-08-19  0:37     ` Eric Anholt
2016-08-19  0:37       ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874m6kel9b.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=John.Youn@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=stefan.wahren@i2se.com \
    --cc=swarren@wwwdotorg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.