Re: [PATCH 1/4] Drivers: hv: utils: fix memory leak on on_msg() failure

From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@linuxdriverproject.org,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Olaf Hering <olaf@aepfle.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] Drivers: hv: utils: fix memory leak on on_msg() failure
Date: Mon, 16 Nov 2015 18:40:36 +0100	[thread overview]
Message-ID: <874mglx2p7.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20151116155407.GK18797@mwanda> (Dan Carpenter's message of "Mon, 16 Nov 2015 18:54:07 +0300")

Dan Carpenter <dan.carpenter@oracle.com> writes:

> On Thu, Nov 12, 2015 at 12:32:13PM +0100, Vitaly Kuznetsov wrote:
>> @@ -85,10 +86,10 @@ static ssize_t hvt_op_write(struct file *file, const char __user *buf,
>>  		return PTR_ERR(inmsg);
>>  
>>  	if (hvt->on_msg(inmsg, count))
>> -		return -EFAULT;
>> +		ret = -EFAULT;
>
> You fix this leak and then re-introduce it again directly in patch
> 3/4.

Such a shame ... Thanks for noticing!

> Also it might be nice to preserve the error code.
>
> 	ret = hvt->on_msg(inmsg, count);
>
> 	kfree(inmsg);
>
> 	return ret ? ret : count;

It seems on_msg() hooks can only return -EINVAL now but why not
... let's do it in v2.

-- 
  Vitaly