* [Buildroot] [PATCH v2 1/2] rt-tests: disable for uclibc mips
@ 2014-02-22 23:07 Ryan Barnett
2014-02-22 23:07 ` [Buildroot] [PATCH v2 2/2] rt-tests: disable on bfin Ryan Barnett
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ryan Barnett @ 2014-02-22 23:07 UTC (permalink / raw)
To: buildroot
rt-tests is not supported by a uclibc toolchain that does not implement
_pid in struct sigevent. Currently this is all MIPS architectures
in uclibc.
Fixes:
http://autobuild.buildroot.net/results/074/074265602bec4aba6c82d1aee389045e8ad33d4b
Signed-off-by: Ryan Barnett <rjbarnet@rockwellcollins.com>
---
package/rt-tests/Config.in | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/rt-tests/Config.in b/package/rt-tests/Config.in
index 58a88a8..a8cede0 100644
--- a/package/rt-tests/Config.in
+++ b/package/rt-tests/Config.in
@@ -5,6 +5,9 @@ config BR2_PACKAGE_RT_TESTS
depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD
# no NPTL for these archs
depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc
+ # no _tid field in 'struct sigevent'
+ depends on !BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
+ BR2_mips64 || BR2_mips64el)
help
Set of utilities for testing the real-time behaviour of a
Linux system.
@@ -27,3 +30,7 @@ comment "rt-tests needs a toolchain w/ threads"
depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD
depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc
depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "rt-tests needs an (e)glibc toolchain"
+ depends on BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
+ BR2_mips64 || BR2_mips64el)
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 2/2] rt-tests: disable on bfin
2014-02-22 23:07 [Buildroot] [PATCH v2 1/2] rt-tests: disable for uclibc mips Ryan Barnett
@ 2014-02-22 23:07 ` Ryan Barnett
2014-02-23 15:47 ` [Buildroot] [PATCH v2 1/2] rt-tests: disable for uclibc mips Peter Korsgaard
2014-02-23 17:19 ` Yann E. MORIN
2 siblings, 0 replies; 5+ messages in thread
From: Ryan Barnett @ 2014-02-22 23:07 UTC (permalink / raw)
To: buildroot
rt-tests depends on NPTL which is not available on the bfin
architecture.
Fixes:
http://autobuild.buildroot.net/results/ac9/ac95f73b2351d46d9a8c48caae7f6c3ea124e8bc
Signed-off-by: Ryan Barnett <rjbarnet@rockwellcollins.com>
---
package/rt-tests/Config.in | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/package/rt-tests/Config.in b/package/rt-tests/Config.in
index a8cede0..ff4284e 100644
--- a/package/rt-tests/Config.in
+++ b/package/rt-tests/Config.in
@@ -4,7 +4,7 @@ config BR2_PACKAGE_RT_TESTS
# priority-inheritance mutex needs NPTL
depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD
# no NPTL for these archs
- depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc
+ depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc && !BR2_bfin
# no _tid field in 'struct sigevent'
depends on !BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
BR2_mips64 || BR2_mips64el)
@@ -28,7 +28,7 @@ config BR2_PACKAGE_RT_TESTS
comment "rt-tests needs a toolchain w/ threads"
depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD
- depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc
+ depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc && !BR2_bfin
depends on !BR2_TOOLCHAIN_HAS_THREADS
comment "rt-tests needs an (e)glibc toolchain"
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 1/2] rt-tests: disable for uclibc mips
2014-02-22 23:07 [Buildroot] [PATCH v2 1/2] rt-tests: disable for uclibc mips Ryan Barnett
2014-02-22 23:07 ` [Buildroot] [PATCH v2 2/2] rt-tests: disable on bfin Ryan Barnett
@ 2014-02-23 15:47 ` Peter Korsgaard
2014-02-23 17:19 ` Yann E. MORIN
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2014-02-23 15:47 UTC (permalink / raw)
To: buildroot
>>>>> "Ryan" == Ryan Barnett <ryanbarnett3@gmail.com> writes:
> rt-tests is not supported by a uclibc toolchain that does not implement
> _pid in struct sigevent. Currently this is all MIPS architectures
> in uclibc.
> Fixes:
> http://autobuild.buildroot.net/results/074/074265602bec4aba6c82d1aee389045e8ad33d4b
Committed both, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 1/2] rt-tests: disable for uclibc mips
2014-02-22 23:07 [Buildroot] [PATCH v2 1/2] rt-tests: disable for uclibc mips Ryan Barnett
2014-02-22 23:07 ` [Buildroot] [PATCH v2 2/2] rt-tests: disable on bfin Ryan Barnett
2014-02-23 15:47 ` [Buildroot] [PATCH v2 1/2] rt-tests: disable for uclibc mips Peter Korsgaard
@ 2014-02-23 17:19 ` Yann E. MORIN
2014-02-23 17:49 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2014-02-23 17:19 UTC (permalink / raw)
To: buildroot
Ryan, Peter, All,
On 2014-02-23 00:07 +0100, Ryan Barnett spake thusly:
> rt-tests is not supported by a uclibc toolchain that does not implement
> _pid in struct sigevent. Currently this is all MIPS architectures
> in uclibc.
>
> Fixes:
> http://autobuild.buildroot.net/results/074/074265602bec4aba6c82d1aee389045e8ad33d4b
>
> Signed-off-by: Ryan Barnett <rjbarnet@rockwellcollins.com>
> ---
> package/rt-tests/Config.in | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/rt-tests/Config.in b/package/rt-tests/Config.in
> index 58a88a8..a8cede0 100644
> --- a/package/rt-tests/Config.in
> +++ b/package/rt-tests/Config.in
> @@ -5,6 +5,9 @@ config BR2_PACKAGE_RT_TESTS
> depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD
> # no NPTL for these archs
> depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc
> + # no _tid field in 'struct sigevent'
> + depends on !BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
> + BR2_mips64 || BR2_mips64el)
Gah! This is not correct Kconfig syntax and breaks:
$ make menuconfig
[...]
package/rt-tests/Config.in:10: syntax error
package/rt-tests/Config.in:9: invalid option
package/rt-tests/Config.in:36: syntax error
package/rt-tests/Config.in:35: invalid option
make[1]: *** [oldconfig] Error 1
Peter, can we revert this change until we have a proper fix, please?
Ryan, what were you trying to do here? Why can you use something like
(variable abbreviated for clarity):
depends on ! ( UCLIBC && ( mips || mipsel || mips64 || mips64el ) )
> help
> Set of utilities for testing the real-time behaviour of a
> Linux system.
> @@ -27,3 +30,7 @@ comment "rt-tests needs a toolchain w/ threads"
> depends on !BR2_PTHREADS && !BR2_PTHREADS_OLD
> depends on !BR2_avr32 && !BR2_xtensa && !BR2_arc
> depends on !BR2_TOOLCHAIN_HAS_THREADS
> +
> +comment "rt-tests needs an (e)glibc toolchain"
> + depends on BR2_TOOLCHAIN_USES_UCLIBC if (BR2_mips || BR2_mipsel || \
> + BR2_mips64 || BR2_mips64el)
Ditto.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH v2 1/2] rt-tests: disable for uclibc mips
2014-02-23 17:19 ` Yann E. MORIN
@ 2014-02-23 17:49 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2014-02-23 17:49 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Gah! This is not correct Kconfig syntax and breaks:
> $ make menuconfig
> [...]
> package/rt-tests/Config.in:10: syntax error
> package/rt-tests/Config.in:9: invalid option
> package/rt-tests/Config.in:36: syntax error
> package/rt-tests/Config.in:35: invalid option
> make[1]: *** [oldconfig] Error 1
> Peter, can we revert this change until we have a proper fix, please?
Argh, indeed.
> Ryan, what were you trying to do here? Why can you use something like
> (variable abbreviated for clarity):
> depends on ! ( UCLIBC && ( mips || mipsel || mips64 || mips64el ) )
Sorry, my fault. Ryan's first version wasn't correct, so I suggested
something like the 2nd approach (but never tested it).
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-23 17:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-22 23:07 [Buildroot] [PATCH v2 1/2] rt-tests: disable for uclibc mips Ryan Barnett
2014-02-22 23:07 ` [Buildroot] [PATCH v2 2/2] rt-tests: disable on bfin Ryan Barnett
2014-02-23 15:47 ` [Buildroot] [PATCH v2 1/2] rt-tests: disable for uclibc mips Peter Korsgaard
2014-02-23 17:19 ` Yann E. MORIN
2014-02-23 17:49 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.