From: Tyrel Datwyler <tyreld@linux.ibm.com> To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Cc: mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev() Date: Thu, 4 Mar 2021 10:48:56 -0800 [thread overview] Message-ID: <87514c42-eb5a-ee68-ff21-49d08bd42a4e@linux.ibm.com> (raw) In-Reply-To: <1614850124-54111-1-git-send-email-jiapeng.chong@linux.alibaba.com> On 3/4/21 1:28 AM, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/scsi/ibmvscsi/ibmvfc.c:3483:60-61: WARNING opportunity for > kobj_to_dev(). > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com> > --- > drivers/scsi/ibmvscsi/ibmvfc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c > index 755313b..e5f1ca7 100644 > --- a/drivers/scsi/ibmvscsi/ibmvfc.c > +++ b/drivers/scsi/ibmvscsi/ibmvfc.c > @@ -3480,7 +3480,7 @@ static ssize_t ibmvfc_read_trace(struct file *filp, struct kobject *kobj, > struct bin_attribute *bin_attr, > char *buf, loff_t off, size_t count) > { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct Scsi_Host *shost = class_to_shost(dev); > struct ibmvfc_host *vhost = shost_priv(shost); > unsigned long flags = 0; >
WARNING: multiple messages have this Message-ID (diff)
From: Tyrel Datwyler <tyreld@linux.ibm.com> To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, jejb@linux.ibm.com, linux-kernel@vger.kernel.org, paulus@samba.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev() Date: Thu, 4 Mar 2021 10:48:56 -0800 [thread overview] Message-ID: <87514c42-eb5a-ee68-ff21-49d08bd42a4e@linux.ibm.com> (raw) In-Reply-To: <1614850124-54111-1-git-send-email-jiapeng.chong@linux.alibaba.com> On 3/4/21 1:28 AM, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/scsi/ibmvscsi/ibmvfc.c:3483:60-61: WARNING opportunity for > kobj_to_dev(). > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Acked-by: Tyrel Datwyler <tyreld@linux.ibm.com> > --- > drivers/scsi/ibmvscsi/ibmvfc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c > index 755313b..e5f1ca7 100644 > --- a/drivers/scsi/ibmvscsi/ibmvfc.c > +++ b/drivers/scsi/ibmvscsi/ibmvfc.c > @@ -3480,7 +3480,7 @@ static ssize_t ibmvfc_read_trace(struct file *filp, struct kobject *kobj, > struct bin_attribute *bin_attr, > char *buf, loff_t off, size_t count) > { > - struct device *dev = container_of(kobj, struct device, kobj); > + struct device *dev = kobj_to_dev(kobj); > struct Scsi_Host *shost = class_to_shost(dev); > struct ibmvfc_host *vhost = shost_priv(shost); > unsigned long flags = 0; >
next prev parent reply other threads:[~2021-03-04 18:50 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-04 9:28 [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev() Jiapeng Chong 2021-03-04 9:28 ` Jiapeng Chong 2021-03-04 18:48 ` Tyrel Datwyler [this message] 2021-03-04 18:48 ` Tyrel Datwyler 2021-03-16 3:14 ` Martin K. Petersen 2021-03-16 3:14 ` Martin K. Petersen -- strict thread matches above, loose matches on Subject: below -- 2021-02-22 6:47 Yang Li 2021-02-22 6:47 ` Yang Li 2021-03-16 3:15 ` Martin K. Petersen 2021-03-16 3:15 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87514c42-eb5a-ee68-ff21-49d08bd42a4e@linux.ibm.com \ --to=tyreld@linux.ibm.com \ --cc=benh@kernel.crashing.org \ --cc=jejb@linux.ibm.com \ --cc=jiapeng.chong@linux.alibaba.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=martin.petersen@oracle.com \ --cc=mpe@ellerman.id.au \ --cc=paulus@samba.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.