All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
To: Tudor.Ambarus@microchip.com, p.yadav@ti.com, michael@walle.cc,
	miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] mtd: spi-nor: siliconkaiser: add support for sk25lp128
Date: Sun, 7 Aug 2022 01:22:25 +1000	[thread overview]
Message-ID: <8757e6d6-666b-433f-3089-621e7c80cf9e@tom-fitzhenry.me.uk> (raw)
In-Reply-To: <dd516981-4d1b-acdc-c468-cbb14d34f68c@microchip.com>

On 21/7/22 18:08, Tudor.Ambarus@microchip.com wrote:
> Does this flash implement the manufacturer ID continuation codes?
> Can you read more bytes of manufacturer ID and dump them?

I'm not sure how to do this, but from what I can gather, flash chips 
that implement manufacturer ID continuation codes return >3 bytes in 
response to RDID. Is this correct?

To do this, in tools/spi/spidex_fdx.c I set buf[0] = 0x9F, and then 
executed this with a large recvbuf:

$ sudo ./a.out -m 6 /dev/spidev0.0
/dev/spidev0.0: spi mode 0x0, 8 bits per word, 10000000 Hz max
response( 6,  7):  25 70 18 25 70 18

It looks like the 3-byte response has cycled, suggesting this flash chip 
does not implement continuation codes.

> If the flash does not define the continuation codes, we'll need to
> add this flash in a ID collisions driver.

I will do this in v3.

WARNING: multiple messages have this Message-ID (diff)
From: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
To: Tudor.Ambarus@microchip.com, p.yadav@ti.com, michael@walle.cc,
	miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] mtd: spi-nor: siliconkaiser: add support for sk25lp128
Date: Sun, 7 Aug 2022 01:22:25 +1000	[thread overview]
Message-ID: <8757e6d6-666b-433f-3089-621e7c80cf9e@tom-fitzhenry.me.uk> (raw)
In-Reply-To: <dd516981-4d1b-acdc-c468-cbb14d34f68c@microchip.com>

On 21/7/22 18:08, Tudor.Ambarus@microchip.com wrote:
> Does this flash implement the manufacturer ID continuation codes?
> Can you read more bytes of manufacturer ID and dump them?

I'm not sure how to do this, but from what I can gather, flash chips 
that implement manufacturer ID continuation codes return >3 bytes in 
response to RDID. Is this correct?

To do this, in tools/spi/spidex_fdx.c I set buf[0] = 0x9F, and then 
executed this with a large recvbuf:

$ sudo ./a.out -m 6 /dev/spidev0.0
/dev/spidev0.0: spi mode 0x0, 8 bits per word, 10000000 Hz max
response( 6,  7):  25 70 18 25 70 18

It looks like the 3-byte response has cycled, suggesting this flash chip 
does not implement continuation codes.

> If the flash does not define the continuation codes, we'll need to
> add this flash in a ID collisions driver.

I will do this in v3.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2022-08-06 15:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03 14:16 [PATCH v2] mtd: spi-nor: siliconkaiser: add support for sk25lp128 Tom Fitzhenry
2022-06-03 14:16 ` Tom Fitzhenry
2022-07-21  8:08 ` Tudor.Ambarus
2022-07-21  8:08   ` Tudor.Ambarus
2022-08-06 15:22   ` Tom Fitzhenry [this message]
2022-08-06 15:22     ` Tom Fitzhenry
2022-08-07 16:01     ` Tudor.Ambarus
2022-08-07 16:01       ` Tudor.Ambarus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8757e6d6-666b-433f-3089-621e7c80cf9e@tom-fitzhenry.me.uk \
    --to=tom@tom-fitzhenry.me.uk \
    --cc=Tudor.Ambarus@microchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michael@walle.cc \
    --cc=miquel.raynal@bootlin.com \
    --cc=p.yadav@ti.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.