* [PATCH] ath9k: Remove unused variable mismatch
@ 2022-11-04 14:07 Colin Ian King
2022-11-04 18:17 ` Jakub Kicinski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Colin Ian King @ 2022-11-04 14:07 UTC (permalink / raw)
To: Toke Høiland-Jørgensen, Kalle Valo, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, linux-wireless,
netdev
Cc: kernel-janitors, linux-kernel
Variable mismatch is just being incremented and it's never used anywhere
else. The variable and the increment are redundant so remove it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/wireless/ath/ath9k/ar9003_mci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/ar9003_mci.c b/drivers/net/wireless/ath/ath9k/ar9003_mci.c
index 9899661f9a60..8d7efd80d97a 100644
--- a/drivers/net/wireless/ath/ath9k/ar9003_mci.c
+++ b/drivers/net/wireless/ath/ath9k/ar9003_mci.c
@@ -585,7 +585,7 @@ static u32 ar9003_mci_wait_for_gpm(struct ath_hw *ah, u8 gpm_type,
{
struct ath_common *common = ath9k_hw_common(ah);
struct ath9k_hw_mci *mci = &ah->btcoex_hw.mci;
- u32 *p_gpm = NULL, mismatch = 0, more_data;
+ u32 *p_gpm = NULL, more_data;
u32 offset;
u8 recv_type = 0, recv_opcode = 0;
bool b_is_bt_cal_done = (gpm_type == MCI_GPM_BT_CAL_DONE);
@@ -656,7 +656,6 @@ static u32 ar9003_mci_wait_for_gpm(struct ath_hw *ah, u8 gpm_type,
} else {
ath_dbg(common, MCI, "MCI GPM subtype not match 0x%x\n",
*(p_gpm + 1));
- mismatch++;
ar9003_mci_process_gpm_extra(ah, recv_type,
recv_opcode, p_gpm);
}
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ath9k: Remove unused variable mismatch
2022-11-04 14:07 [PATCH] ath9k: Remove unused variable mismatch Colin Ian King
@ 2022-11-04 18:17 ` Jakub Kicinski
2022-11-06 13:41 ` Toke Høiland-Jørgensen
2022-11-09 7:04 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2022-11-04 18:17 UTC (permalink / raw)
To: Colin Ian King
Cc: Toke Høiland-Jørgensen, Kalle Valo, David S . Miller,
Eric Dumazet, Paolo Abeni, linux-wireless, netdev,
kernel-janitors, linux-kernel
On Fri, 4 Nov 2022 14:07:23 +0000 Colin Ian King wrote:
> Variable mismatch is just being incremented and it's never used anywhere
> else. The variable and the increment are redundant so remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Good sir, you don't have to CC netdev on wireless patches.
Especially trivial ones. I'm saying this because you're a
major contributor and I presume you send patches based on
some scripted integration with get_maintainer so I hope
this could nudge you to improve get_maintainer itself? :)
Perhaps any entry which has a tree specified should mask
off entries higher up?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath9k: Remove unused variable mismatch
2022-11-04 14:07 [PATCH] ath9k: Remove unused variable mismatch Colin Ian King
2022-11-04 18:17 ` Jakub Kicinski
@ 2022-11-06 13:41 ` Toke Høiland-Jørgensen
2022-11-09 7:04 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Toke Høiland-Jørgensen @ 2022-11-06 13:41 UTC (permalink / raw)
To: Colin Ian King, Kalle Valo, linux-wireless; +Cc: kernel-janitors, linux-kernel
Colin Ian King <colin.i.king@gmail.com> writes:
> Variable mismatch is just being incremented and it's never used anywhere
> else. The variable and the increment are redundant so remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath9k: Remove unused variable mismatch
2022-11-04 14:07 [PATCH] ath9k: Remove unused variable mismatch Colin Ian King
2022-11-04 18:17 ` Jakub Kicinski
2022-11-06 13:41 ` Toke Høiland-Jørgensen
@ 2022-11-09 7:04 ` Kalle Valo
2 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2022-11-09 7:04 UTC (permalink / raw)
To: Colin Ian King
Cc: Toke Høiland-Jørgensen, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-wireless, netdev,
kernel-janitors, linux-kernel
Colin Ian King <colin.i.king@gmail.com> wrote:
> Variable mismatch is just being incremented and it's never used anywhere
> else. The variable and the increment are redundant so remove it.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Patch applied to ath-next branch of ath.git, thanks.
dc45398446be wifi: ath9k: Remove unused variable mismatch
--
https://patchwork.kernel.org/project/linux-wireless/patch/20221104140723.226857-1-colin.i.king@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-09 7:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-04 14:07 [PATCH] ath9k: Remove unused variable mismatch Colin Ian King
2022-11-04 18:17 ` Jakub Kicinski
2022-11-06 13:41 ` Toke Høiland-Jørgensen
2022-11-09 7:04 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.