* [Intel-gfx] [PATCH] drm/i915: set min brightness for aux backlight interface. @ 2021-04-19 15:17 Lee Shawn C 2021-04-19 15:43 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork ` (3 more replies) 0 siblings, 4 replies; 6+ messages in thread From: Lee Shawn C @ 2021-04-19 15:17 UTC (permalink / raw) To: intel-gfx; +Cc: Cooper Chiou Min brightness level for aux backlight interface is always zero. Driver should refer to VBT's setting to configure proper minimum level just like PWM backlight interface. Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Ville Syrjala <ville.syrjala@linux.intel.com> Cc: Lyude Paul <lyude@redhat.com> Cc: Cooper Chiou <cooper.chiou@intel.com> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com> --- drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +- drivers/gpu/drm/i915/display/intel_panel.c | 2 +- drivers/gpu/drm/i915/display/intel_panel.h | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c index 4f8337c7fd2e..efd8fa155105 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c @@ -571,7 +571,7 @@ static int intel_dp_aux_vesa_setup_backlight(struct intel_connector *connector, if (!panel->backlight.max) return -ENODEV; - panel->backlight.min = 0; + panel->backlight.min = get_backlight_min_vbt(connector); panel->backlight.level = intel_dp_aux_vesa_get_backlight(connector, pipe); panel->backlight.enabled = intel_dp_aux_vesa_backlight_dpcd_mode(connector) && panel->backlight.level != 0; diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c index 551fcaa77c2c..6d58ec192a04 100644 --- a/drivers/gpu/drm/i915/display/intel_panel.c +++ b/drivers/gpu/drm/i915/display/intel_panel.c @@ -1614,7 +1614,7 @@ static u32 get_backlight_max_vbt(struct intel_connector *connector) /* * Note: The setup hooks can't assume pipe is set! */ -static u32 get_backlight_min_vbt(struct intel_connector *connector) +u32 get_backlight_min_vbt(struct intel_connector *connector) { struct drm_i915_private *dev_priv = to_i915(connector->base.dev); struct intel_panel *panel = &connector->panel; diff --git a/drivers/gpu/drm/i915/display/intel_panel.h b/drivers/gpu/drm/i915/display/intel_panel.h index 1d340f77bffc..63da4e355585 100644 --- a/drivers/gpu/drm/i915/display/intel_panel.h +++ b/drivers/gpu/drm/i915/display/intel_panel.h @@ -53,6 +53,7 @@ void intel_panel_set_pwm_level(const struct drm_connector_state *conn_state, u32 u32 intel_panel_invert_pwm_level(struct intel_connector *connector, u32 level); u32 intel_panel_backlight_level_to_pwm(struct intel_connector *connector, u32 level); u32 intel_panel_backlight_level_from_pwm(struct intel_connector *connector, u32 val); +u32 get_backlight_min_vbt(struct intel_connector *connector); #if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) int intel_backlight_device_register(struct intel_connector *connector); -- 2.17.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: set min brightness for aux backlight interface. 2021-04-19 15:17 [Intel-gfx] [PATCH] drm/i915: set min brightness for aux backlight interface Lee Shawn C @ 2021-04-19 15:43 ` Patchwork 2021-04-19 16:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2021-04-19 15:43 UTC (permalink / raw) To: Lee Shawn C; +Cc: intel-gfx == Series Details == Series: drm/i915: set min brightness for aux backlight interface. URL : https://patchwork.freedesktop.org/series/89233/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:102: warning: Function parameter or member 'ww' not described in 'i915_gem_shrink' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'jump_whitelist' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'shadow_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Function parameter or member 'batch_map' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1420: warning: Excess function parameter 'trampoline' description in 'intel_engine_cmd_parser' _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: set min brightness for aux backlight interface. 2021-04-19 15:17 [Intel-gfx] [PATCH] drm/i915: set min brightness for aux backlight interface Lee Shawn C 2021-04-19 15:43 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork @ 2021-04-19 16:08 ` Patchwork 2021-04-19 19:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-04-21 9:42 ` [Intel-gfx] [PATCH] " Jani Nikula 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2021-04-19 16:08 UTC (permalink / raw) To: Lee Shawn C; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 2901 bytes --] == Series Details == Series: drm/i915: set min brightness for aux backlight interface. URL : https://patchwork.freedesktop.org/series/89233/ State : success == Summary == CI Bug Log - changes from CI_DRM_9981 -> Patchwork_19951 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/index.html Known issues ------------ Here are the changes found in Patchwork_19951 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@runner@aborted: - fi-cfl-8700k: NOTRUN -> [FAIL][1] ([i915#2426]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/fi-cfl-8700k/igt@runner@aborted.html #### Possible fixes #### * igt@gem_exec_suspend@basic-s0: - fi-tgl-u2: [FAIL][2] ([i915#1888]) -> [PASS][3] [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/fi-tgl-u2/igt@gem_exec_suspend@basic-s0.html * igt@i915_selftest@live@gt_pm: - fi-cml-s: [DMESG-FAIL][4] ([i915#2291]) -> [PASS][5] [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/fi-cml-s/igt@i915_selftest@live@gt_pm.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/fi-cml-s/igt@i915_selftest@live@gt_pm.html * igt@i915_selftest@live@hangcheck: - {fi-hsw-gt1}: [DMESG-WARN][6] ([i915#3303]) -> [PASS][7] [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291 [i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426 [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303 Participating hosts (43 -> 41) ------------------------------ Missing (2): fi-bsw-cyan fi-bdw-samus Build changes ------------- * Linux: CI_DRM_9981 -> Patchwork_19951 CI-20190529: 20190529 CI_DRM_9981: 319c9b19adaf32bd92cbaa36e23272be36925f02 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6069: 71ee6cdc849c381186f681527e19fb217d32510d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19951: 5f89686183663c66111e711c1def95a834864bbc @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 5f8968618366 drm/i915: set min brightness for aux backlight interface. == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/index.html [-- Attachment #1.2: Type: text/html, Size: 3595 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: set min brightness for aux backlight interface. 2021-04-19 15:17 [Intel-gfx] [PATCH] drm/i915: set min brightness for aux backlight interface Lee Shawn C 2021-04-19 15:43 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork 2021-04-19 16:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2021-04-19 19:30 ` Patchwork 2021-04-21 9:42 ` [Intel-gfx] [PATCH] " Jani Nikula 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2021-04-19 19:30 UTC (permalink / raw) To: Lee Shawn C; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 27683 bytes --] == Series Details == Series: drm/i915: set min brightness for aux backlight interface. URL : https://patchwork.freedesktop.org/series/89233/ State : success == Summary == CI Bug Log - changes from CI_DRM_9981_full -> Patchwork_19951_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_19951_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@feature_discovery@psr2: - shard-iclb: [PASS][1] -> [SKIP][2] ([i915#658]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-iclb2/igt@feature_discovery@psr2.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-iclb4/igt@feature_discovery@psr2.html * igt@gem_ctx_persistence@legacy-engines-mixed: - shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +5 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-snb5/igt@gem_ctx_persistence@legacy-engines-mixed.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-tglb: [PASS][4] -> [FAIL][5] ([i915#2842]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-tglb3/igt@gem_exec_fair@basic-none-share@rcs0.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-tglb1/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842]) +3 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-glk6/igt@gem_exec_fair@basic-pace-solo@rcs0.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-glk5/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-iclb: [PASS][8] -> [FAIL][9] ([i915#2842]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-iclb8/igt@gem_exec_fair@basic-pace@vcs0.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-iclb6/igt@gem_exec_fair@basic-pace@vcs0.html - shard-kbl: [PASS][10] -> [SKIP][11] ([fdo#109271]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-kbl6/igt@gem_exec_fair@basic-pace@vcs0.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_exec_reloc@basic-wide-active@vcs1: - shard-iclb: NOTRUN -> [FAIL][12] ([i915#2389]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-iclb2/igt@gem_exec_reloc@basic-wide-active@vcs1.html * igt@gem_exec_whisper@basic-queues-priority-all: - shard-iclb: [PASS][13] -> [INCOMPLETE][14] ([i915#1895]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-iclb6/igt@gem_exec_whisper@basic-queues-priority-all.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-iclb4/igt@gem_exec_whisper@basic-queues-priority-all.html * igt@gem_mmap_gtt@cpuset-big-copy: - shard-iclb: [PASS][15] -> [FAIL][16] ([i915#307]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-iclb1/igt@gem_mmap_gtt@cpuset-big-copy.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-iclb7/igt@gem_mmap_gtt@cpuset-big-copy.html * igt@gem_mmap_gtt@cpuset-big-copy-odd: - shard-glk: [PASS][17] -> [FAIL][18] ([i915#307]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-glk4/igt@gem_mmap_gtt@cpuset-big-copy-odd.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-glk7/igt@gem_mmap_gtt@cpuset-big-copy-odd.html * igt@gem_pread@exhaustion: - shard-apl: NOTRUN -> [WARN][19] ([i915#2658]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl7/igt@gem_pread@exhaustion.html * igt@gem_render_copy@linear-to-vebox-y-tiled: - shard-apl: NOTRUN -> [SKIP][20] ([fdo#109271]) +184 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl8/igt@gem_render_copy@linear-to-vebox-y-tiled.html * igt@gem_userptr_blits@input-checking: - shard-snb: NOTRUN -> [DMESG-WARN][21] ([i915#3002]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-snb5/igt@gem_userptr_blits@input-checking.html * igt@gem_userptr_blits@set-cache-level: - shard-snb: NOTRUN -> [FAIL][22] ([i915#3324]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-snb5/igt@gem_userptr_blits@set-cache-level.html * igt@gem_userptr_blits@vma-merge: - shard-snb: NOTRUN -> [FAIL][23] ([i915#2724]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-snb7/igt@gem_userptr_blits@vma-merge.html * igt@i915_pm_dc@dc6-dpms: - shard-kbl: NOTRUN -> [FAIL][24] ([i915#454]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl7/igt@i915_pm_dc@dc6-dpms.html - shard-skl: NOTRUN -> [FAIL][25] ([i915#454]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl4/igt@i915_pm_dc@dc6-dpms.html * igt@kms_big_joiner@basic: - shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#2705]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl2/igt@kms_big_joiner@basic.html * igt@kms_chamelium@dp-edid-read: - shard-snb: NOTRUN -> [SKIP][27] ([fdo#109271] / [fdo#111827]) +13 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-snb7/igt@kms_chamelium@dp-edid-read.html * igt@kms_chamelium@hdmi-hpd-with-enabled-mode: - shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271] / [fdo#111827]) +10 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl6/igt@kms_chamelium@hdmi-hpd-with-enabled-mode.html * igt@kms_chamelium@vga-hpd-after-suspend: - shard-skl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +7 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl8/igt@kms_chamelium@vga-hpd-after-suspend.html * igt@kms_color_chamelium@pipe-a-ctm-limited-range: - shard-apl: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +15 similar issues [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl8/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-apl: NOTRUN -> [DMESG-WARN][31] ([i915#180]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge: - shard-snb: NOTRUN -> [SKIP][32] ([fdo#109271]) +301 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-snb5/igt@kms_cursor_edge_walk@pipe-d-128x128-right-edge.html * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2: - shard-glk: [PASS][33] -> [FAIL][34] ([i915#79]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ac-hdmi-a1-hdmi-a2.html * igt@kms_flip@flip-vs-expired-vblank@b-edp1: - shard-skl: [PASS][35] -> [FAIL][36] ([i915#79]) [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-skl6/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl3/igt@kms_flip@flip-vs-expired-vblank@b-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +7 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1: - shard-apl: [PASS][39] -> [DMESG-WARN][40] ([i915#180]) +2 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl6/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt: - shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271]) +85 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl4/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-gtt.html * igt@kms_hdr@bpc-switch-suspend: - shard-skl: NOTRUN -> [FAIL][42] ([i915#1188]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl10/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - shard-kbl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#533]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence: - shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#533]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl8/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max: - shard-skl: NOTRUN -> [FAIL][45] ([fdo#108145] / [i915#265]) [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html - shard-kbl: NOTRUN -> [FAIL][46] ([fdo#108145] / [i915#265]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max.html * igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb: - shard-apl: NOTRUN -> [FAIL][47] ([fdo#108145] / [i915#265]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl7/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb: - shard-kbl: NOTRUN -> [FAIL][48] ([i915#265]) +1 similar issue [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl7/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html - shard-skl: NOTRUN -> [FAIL][49] ([i915#265]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1: - shard-kbl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#658]) +1 similar issue [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2: - shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#658]) +4 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl7/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2.html * igt@kms_psr@psr2_suspend: - shard-iclb: [PASS][52] -> [SKIP][53] ([fdo#109441]) +3 similar issues [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-iclb2/igt@kms_psr@psr2_suspend.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-iclb6/igt@kms_psr@psr2_suspend.html * igt@kms_sysfs_edid_timing: - shard-apl: NOTRUN -> [FAIL][54] ([IGT#2]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl8/igt@kms_sysfs_edid_timing.html * igt@prime_nv_pcopy@test2: - shard-kbl: NOTRUN -> [SKIP][55] ([fdo#109271]) +125 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl7/igt@prime_nv_pcopy@test2.html * igt@sysfs_clients@busy: - shard-skl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#2994]) +2 similar issues [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl4/igt@sysfs_clients@busy.html * igt@sysfs_clients@fair-7: - shard-apl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#2994]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl8/igt@sysfs_clients@fair-7.html * igt@sysfs_clients@recycle: - shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2994]) +3 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl1/igt@sysfs_clients@recycle.html #### Possible fixes #### * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [FAIL][59] ([i915#2842]) -> [PASS][60] +2 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-tglb1/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_exec_fair@basic-pace@rcs0: - shard-kbl: [SKIP][61] ([fdo#109271]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-kbl6/igt@gem_exec_fair@basic-pace@rcs0.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl3/igt@gem_exec_fair@basic-pace@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [FAIL][63] ([i915#2849]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-iclb1/igt@gem_exec_fair@basic-throttle@rcs0.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_exec_whisper@basic-fds-forked-all: - shard-skl: [DMESG-WARN][65] ([i915#1982]) -> [PASS][66] +1 similar issue [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-skl1/igt@gem_exec_whisper@basic-fds-forked-all.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl6/igt@gem_exec_whisper@basic-fds-forked-all.html * igt@i915_suspend@fence-restore-tiled2untiled: - shard-apl: [DMESG-WARN][67] ([i915#180]) -> [PASS][68] +1 similar issue [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl2/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [DMESG-WARN][69] ([i915#180]) -> [PASS][70] +4 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_flip@plain-flip-fb-recreate@c-edp1: - shard-skl: [FAIL][71] ([i915#2122]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-skl6/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl7/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html * igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu: - shard-skl: [FAIL][73] ([i915#49]) -> [PASS][74] [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-skl10/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl9/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-cpu.html * igt@kms_pipe_crc_basic@read-crc-pipe-a: - shard-skl: [FAIL][75] ([i915#53]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-skl2/igt@kms_pipe_crc_basic@read-crc-pipe-a.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl10/igt@kms_pipe_crc_basic@read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [FAIL][77] ([fdo#108145] / [i915#265]) -> [PASS][78] [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [SKIP][79] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][80] [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-iclb5/igt@kms_psr2_su@frontbuffer.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-iclb2/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_no_drrs: - shard-iclb: [SKIP][81] ([fdo#109441]) -> [PASS][82] +1 similar issue [81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-iclb5/igt@kms_psr@psr2_no_drrs.html [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-iclb2/igt@kms_psr@psr2_no_drrs.html #### Warnings #### * igt@gem_exec_fair@basic-pace@vecs0: - shard-kbl: [FAIL][83] ([i915#2842]) -> [SKIP][84] ([fdo#109271]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-kbl6/igt@gem_exec_fair@basic-pace@vecs0.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl3/igt@gem_exec_fair@basic-pace@vecs0.html * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][85] ([i915#2684]) -> [WARN][86] ([i915#1804] / [i915#2684]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-iclb2/igt@i915_pm_rc6_residency@rc6-fence.html [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [WARN][87] ([i915#2681] / [i915#2684]) -> [WARN][88] ([i915#2684]) [87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1: - shard-iclb: [SKIP][89] ([i915#2920]) -> [SKIP][90] ([i915#658]) +1 similar issue [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-iclb6/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html * igt@kms_psr2_sf@plane-move-sf-dmg-area-2: - shard-iclb: [SKIP][91] ([i915#658]) -> [SKIP][92] ([i915#2920]) +1 similar issue [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-iclb5/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-iclb2/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html * igt@runner@aborted: - shard-kbl: ([FAIL][93], [FAIL][94], [FAIL][95], [FAIL][96], [FAIL][97], [FAIL][98], [FAIL][99], [FAIL][100]) ([i915#180] / [i915#1814] / [i915#3002]) -> ([FAIL][101], [FAIL][102], [FAIL][103], [FAIL][104], [FAIL][105], [FAIL][106], [FAIL][107]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2292] / [i915#2505] / [i915#3002]) [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-kbl4/igt@runner@aborted.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-kbl4/igt@runner@aborted.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-kbl3/igt@runner@aborted.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-kbl2/igt@runner@aborted.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-kbl4/igt@runner@aborted.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-kbl2/igt@runner@aborted.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-kbl7/igt@runner@aborted.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-kbl3/igt@runner@aborted.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl2/igt@runner@aborted.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl4/igt@runner@aborted.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl7/igt@runner@aborted.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl4/igt@runner@aborted.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl4/igt@runner@aborted.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl2/igt@runner@aborted.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-kbl6/igt@runner@aborted.html - shard-apl: ([FAIL][108], [FAIL][109], [FAIL][110], [FAIL][111], [FAIL][112], [FAIL][113]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002]) -> ([FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117]) ([i915#1610] / [i915#180] / [i915#1814] / [i915#3002]) [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-apl3/igt@runner@aborted.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-apl8/igt@runner@aborted.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-apl6/igt@runner@aborted.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-apl1/igt@runner@aborted.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-apl1/igt@runner@aborted.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-apl2/igt@runner@aborted.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl2/igt@runner@aborted.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl2/igt@runner@aborted.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl8/igt@runner@aborted.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-apl6/igt@runner@aborted.html - shard-skl: ([FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122], [FAIL][123], [FAIL][124]) ([i915#1814] / [i915#2029] / [i915#3002] / [i915#3254]) -> ([FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129]) ([i915#2029] / [i915#2263] / [i915#3002]) [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-skl10/igt@runner@aborted.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-skl3/igt@runner@aborted.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-skl2/igt@runner@aborted.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-skl2/igt@runner@aborted.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-skl7/igt@runner@aborted.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-skl3/igt@runner@aborted.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9981/shard-skl3/igt@runner@aborted.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl6/igt@runner@aborted.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl2/igt@runner@aborted.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl3/igt@runner@aborted.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl3/igt@runner@aborted.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/shard-skl3/igt@runner@aborted.html ### Piglit changes ### {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804 [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814 [i915#1834]: https://gitlab.freedesktop.org/drm/intel/issues/1834 [i915#1895]: https://gitlab.freedesktop.org/drm/intel/issues/1895 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2263]: https://gitlab.freedesktop.org/drm/intel/issues/2263 [i915#2292]: https://gitlab.freedesktop.org/drm/intel/issues/2292 [i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389 [i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684 [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 [i915#2724]: https://gitlab.freedesktop.org/drm/intel/issues/2724 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002 [i915#3045]: https://gitlab.freedesktop.org/drm/intel/issues/3045 [i915#307]: https://gitlab.freedesktop.org/drm/intel/issues/307 [i915#3105]: https://gitlab.freedesktop.org/drm/intel/issues/3105 [i915#3254]: https://gitlab.freedesktop.org/drm/intel/issues/3254 [i915#3324]: https://gitlab.freedesktop.org/drm/intel/issues/3324 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49 [i915#53]: https://gitlab.freedesktop.org/drm/intel/issues/53 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 Participating hosts (11 -> 12) ------------------------------ Additional (1): pig-icl-1065g7 Build changes ------------- * Linux: CI_DRM_9981 -> Patchwork_19951 CI-20190529: 20190529 CI_DRM_9981: 319c9b19adaf32bd92cbaa36e23272be36925f02 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6069: 71ee6cdc849c381186f681527e19fb217d32510d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_19951: 5f89686183663c66111e711c1def95a834864bbc @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19951/index.html [-- Attachment #1.2: Type: text/html, Size: 34616 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: set min brightness for aux backlight interface. 2021-04-19 15:17 [Intel-gfx] [PATCH] drm/i915: set min brightness for aux backlight interface Lee Shawn C ` (2 preceding siblings ...) 2021-04-19 19:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2021-04-21 9:42 ` Jani Nikula 2021-04-23 14:23 ` Lee, Shawn C 3 siblings, 1 reply; 6+ messages in thread From: Jani Nikula @ 2021-04-21 9:42 UTC (permalink / raw) To: Lee Shawn C, intel-gfx; +Cc: Cooper Chiou On Mon, 19 Apr 2021, Lee Shawn C <shawn.c.lee@intel.com> wrote: > Min brightness level for aux backlight interface is always zero. > Driver should refer to VBT's setting to configure proper minimum > level just like PWM backlight interface. Unfortunately this change makes it harder for Lyude to extract the dpcd backlight code from i915 to drm helpers, and I think the min brightness should be handled after or in connection with that change. BR, Jani. > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Ville Syrjala <ville.syrjala@linux.intel.com> > Cc: Lyude Paul <lyude@redhat.com> > Cc: Cooper Chiou <cooper.chiou@intel.com> > > Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com> > --- > drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +- > drivers/gpu/drm/i915/display/intel_panel.c | 2 +- > drivers/gpu/drm/i915/display/intel_panel.h | 1 + > 3 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > index 4f8337c7fd2e..efd8fa155105 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c > @@ -571,7 +571,7 @@ static int intel_dp_aux_vesa_setup_backlight(struct intel_connector *connector, > if (!panel->backlight.max) > return -ENODEV; > > - panel->backlight.min = 0; > + panel->backlight.min = get_backlight_min_vbt(connector); > panel->backlight.level = intel_dp_aux_vesa_get_backlight(connector, pipe); > panel->backlight.enabled = intel_dp_aux_vesa_backlight_dpcd_mode(connector) && > panel->backlight.level != 0; > diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c > index 551fcaa77c2c..6d58ec192a04 100644 > --- a/drivers/gpu/drm/i915/display/intel_panel.c > +++ b/drivers/gpu/drm/i915/display/intel_panel.c > @@ -1614,7 +1614,7 @@ static u32 get_backlight_max_vbt(struct intel_connector *connector) > /* > * Note: The setup hooks can't assume pipe is set! > */ > -static u32 get_backlight_min_vbt(struct intel_connector *connector) > +u32 get_backlight_min_vbt(struct intel_connector *connector) > { > struct drm_i915_private *dev_priv = to_i915(connector->base.dev); > struct intel_panel *panel = &connector->panel; > diff --git a/drivers/gpu/drm/i915/display/intel_panel.h b/drivers/gpu/drm/i915/display/intel_panel.h > index 1d340f77bffc..63da4e355585 100644 > --- a/drivers/gpu/drm/i915/display/intel_panel.h > +++ b/drivers/gpu/drm/i915/display/intel_panel.h > @@ -53,6 +53,7 @@ void intel_panel_set_pwm_level(const struct drm_connector_state *conn_state, u32 > u32 intel_panel_invert_pwm_level(struct intel_connector *connector, u32 level); > u32 intel_panel_backlight_level_to_pwm(struct intel_connector *connector, u32 level); > u32 intel_panel_backlight_level_from_pwm(struct intel_connector *connector, u32 val); > +u32 get_backlight_min_vbt(struct intel_connector *connector); > > #if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) > int intel_backlight_device_register(struct intel_connector *connector); -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: set min brightness for aux backlight interface. 2021-04-21 9:42 ` [Intel-gfx] [PATCH] " Jani Nikula @ 2021-04-23 14:23 ` Lee, Shawn C 0 siblings, 0 replies; 6+ messages in thread From: Lee, Shawn C @ 2021-04-23 14:23 UTC (permalink / raw) To: Jani Nikula, intel-gfx; +Cc: Chiou, Cooper On Wed, 21 Apr 2021, Jani Nikula <jani.nikula@linux.intel.com> wrote: >On Mon, 19 Apr 2021, Lee Shawn C <shawn.c.lee@intel.com> wrote: >> Min brightness level for aux backlight interface is always zero. >> Driver should refer to VBT's setting to configure proper minimum level >> just like PWM backlight interface. > >Unfortunately this change makes it harder for Lyude to extract the dpcd backlight code from i915 to drm helpers, and I think the min brightness should be handled after or in connection with that change. > >BR, >Jani. > Understood. We will wait for Lyude's patch landing on upstream. And confirm i915 driver need this change or not. Best regards, Shawn > >> >> Cc: Jani Nikula <jani.nikula@linux.intel.com> >> Cc: Ville Syrjala <ville.syrjala@linux.intel.com> >> Cc: Lyude Paul <lyude@redhat.com> >> Cc: Cooper Chiou <cooper.chiou@intel.com> >> >> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com> >> --- >> drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 2 +- >> drivers/gpu/drm/i915/display/intel_panel.c | 2 +- >> drivers/gpu/drm/i915/display/intel_panel.h | 1 + >> 3 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c >> b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c >> index 4f8337c7fd2e..efd8fa155105 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c >> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c >> @@ -571,7 +571,7 @@ static int intel_dp_aux_vesa_setup_backlight(struct intel_connector *connector, >> if (!panel->backlight.max) >> return -ENODEV; >> >> - panel->backlight.min = 0; >> + panel->backlight.min = get_backlight_min_vbt(connector); >> panel->backlight.level = intel_dp_aux_vesa_get_backlight(connector, pipe); >> panel->backlight.enabled = intel_dp_aux_vesa_backlight_dpcd_mode(connector) && >> panel->backlight.level != 0; >> diff --git a/drivers/gpu/drm/i915/display/intel_panel.c >> b/drivers/gpu/drm/i915/display/intel_panel.c >> index 551fcaa77c2c..6d58ec192a04 100644 >> --- a/drivers/gpu/drm/i915/display/intel_panel.c >> +++ b/drivers/gpu/drm/i915/display/intel_panel.c >> @@ -1614,7 +1614,7 @@ static u32 get_backlight_max_vbt(struct >> intel_connector *connector) >> /* >> * Note: The setup hooks can't assume pipe is set! >> */ >> -static u32 get_backlight_min_vbt(struct intel_connector *connector) >> +u32 get_backlight_min_vbt(struct intel_connector *connector) >> { >> struct drm_i915_private *dev_priv = to_i915(connector->base.dev); >> struct intel_panel *panel = &connector->panel; diff --git >> a/drivers/gpu/drm/i915/display/intel_panel.h >> b/drivers/gpu/drm/i915/display/intel_panel.h >> index 1d340f77bffc..63da4e355585 100644 >> --- a/drivers/gpu/drm/i915/display/intel_panel.h >> +++ b/drivers/gpu/drm/i915/display/intel_panel.h >> @@ -53,6 +53,7 @@ void intel_panel_set_pwm_level(const struct >> drm_connector_state *conn_state, u32 >> u32 intel_panel_invert_pwm_level(struct intel_connector *connector, >> u32 level); >> u32 intel_panel_backlight_level_to_pwm(struct intel_connector >> *connector, u32 level); >> u32 intel_panel_backlight_level_from_pwm(struct intel_connector >> *connector, u32 val); >> +u32 get_backlight_min_vbt(struct intel_connector *connector); >> >> #if IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) >> int intel_backlight_device_register(struct intel_connector >> *connector); > >-- >Jani Nikula, Intel Open Source Graphics Center > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-23 14:23 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-19 15:17 [Intel-gfx] [PATCH] drm/i915: set min brightness for aux backlight interface Lee Shawn C 2021-04-19 15:43 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork 2021-04-19 16:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-04-19 19:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-04-21 9:42 ` [Intel-gfx] [PATCH] " Jani Nikula 2021-04-23 14:23 ` Lee, Shawn C
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.