From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/openblas: fix build failure due to forced FFLAGS
Date: Tue, 16 Mar 2021 23:12:54 +0100 [thread overview]
Message-ID: <875z1qzr15.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20210305134839.30612-1-patrickdepinguin@gmail.com> (Thomas De Schampheleire's message of "Fri, 5 Mar 2021 14:48:36 +0100")
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> Buildroot specifies a value for FFLAGS on the make command-line.
> While the openblas makefiles allowed this principle for the most part by
> using 'override FFLAGS += ....', the make.inc file generated for the shipped
> 'lapack' sources just used a 'FFLAGS = ...' statement, whose value is then
> eclipsed by the command-line FFLAGS.
> This meant that -fPIC may be passed to the link step but not to all relevant
> source files, causing relocation failures.
> Fixes: http://autobuild.buildroot.net/results/d530db0f37e1e0462e3af1e1787e15f94ff21884/
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
Committed to 2020.11.x, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2021-03-16 22:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 13:48 [Buildroot] [PATCH 1/3] package/openblas: fix build failure due to forced FFLAGS Thomas De Schampheleire
2021-03-05 13:48 ` [Buildroot] [PATCH 2/3] package/openblas: strip any optimization flag where needed Thomas De Schampheleire
2021-03-06 15:34 ` Peter Korsgaard
2021-03-16 22:12 ` Peter Korsgaard
2021-03-05 13:48 ` [Buildroot] [PATCH 3/3] package/openblas: respect the optimization level specified by Buildroot Thomas De Schampheleire
2021-03-06 15:36 ` Peter Korsgaard
2021-03-16 22:13 ` Peter Korsgaard
2021-03-06 15:33 ` [Buildroot] [PATCH 1/3] package/openblas: fix build failure due to forced FFLAGS Peter Korsgaard
2021-03-16 22:12 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875z1qzr15.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.