From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/openblas: strip any optimization flag where needed
Date: Sat, 06 Mar 2021 16:34:45 +0100 [thread overview]
Message-ID: <87y2f08fe2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20210305134839.30612-2-patrickdepinguin@gmail.com> (Thomas De Schampheleire's message of "Fri, 5 Mar 2021 14:48:37 +0100")
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> openblas strips off -O1-O3 for certain source files, but forgets to handle
> -Os, -Og and -O. This means that the intended effect of 'no optimization' is
> not always reached.
> Signed-off-by: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> ---
> ...nsider-Os-when-determining-LAPACK_NO.patch | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644
> package/openblas/0003-Makefile-also-consider-Os-when-determining-LAPACK_NO.patch
> As the openblas patch is fixing a generic problem, I will attempt to upstream it.
> diff --git
> a/package/openblas/0003-Makefile-also-consider-Os-when-determining-LAPACK_NO.patch
> b/package/openblas/0003-Makefile-also-consider-Os-when-determining-LAPACK_NO.patch
> new file mode 100644
> index 0000000000..0ff9051ae4
> --- /dev/null
> +++ b/package/openblas/0003-Makefile-also-consider-Os-when-determining-LAPACK_NO.patch
> @@ -0,0 +1,31 @@
> +From ced08de1ad74811bc23d74121751537bfd8e9556 Mon Sep 17 00:00:00 2001
> +From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> +Date: Fri, 5 Mar 2021 11:15:52 +0100
> +Subject: [PATCH 1/2] Makefile: also consider -O, -Og and -Os when stripping flags
Same comment about -N. Committed with that fixed, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2021-03-06 15:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 13:48 [Buildroot] [PATCH 1/3] package/openblas: fix build failure due to forced FFLAGS Thomas De Schampheleire
2021-03-05 13:48 ` [Buildroot] [PATCH 2/3] package/openblas: strip any optimization flag where needed Thomas De Schampheleire
2021-03-06 15:34 ` Peter Korsgaard [this message]
2021-03-16 22:12 ` Peter Korsgaard
2021-03-05 13:48 ` [Buildroot] [PATCH 3/3] package/openblas: respect the optimization level specified by Buildroot Thomas De Schampheleire
2021-03-06 15:36 ` Peter Korsgaard
2021-03-16 22:13 ` Peter Korsgaard
2021-03-06 15:33 ` [Buildroot] [PATCH 1/3] package/openblas: fix build failure due to forced FFLAGS Peter Korsgaard
2021-03-16 22:12 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2f08fe2.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.