All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Cc: zohar@linux.ibm.com, robh@kernel.org, takahiro.akashi@linaro.org,
	gregkh@linuxfoundation.org, will@kernel.org,
	catalin.marinas@arm.com, mpe@ellerman.id.au, james.morse@arm.com,
	sashal@kernel.org, benh@kernel.crashing.org, paulus@samba.org,
	frowand.list@gmail.com, vincenzo.frascino@arm.com,
	mark.rutland@arm.com, dmitry.kasatkin@gmail.com,
	jmorris@namei.org, serge@hallyn.com, pasha.tatashin@soleen.com,
	allison@lohutok.net, masahiroy@kernel.org, bhsharma@redhat.com,
	mbrugger@suse.com, hsinyi@chromium.org, tao.li@vivo.com,
	christophe.leroy@c-s.fr, prsriva@linux.microsoft.com,
	balajib@linux.microsoft.com, linux-integrity@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v13 2/6] powerpc: Move arch independent ima kexec functions to drivers/of/kexec.c
Date: Tue, 22 Dec 2020 21:48:02 -0300	[thread overview]
Message-ID: <875z4tl54t.fsf@manicouagan.localdomain> (raw)
In-Reply-To: <20201219175713.18888-3-nramas@linux.microsoft.com>


Actually, I have one more comment on this patch:

Lakshmi Ramasubramanian <nramas@linux.microsoft.com> writes:

> diff --git a/arch/powerpc/kexec/file_load.c b/arch/powerpc/kexec/file_load.c
> index 956bcb2d1ec2..9f3ec0b239ef 100644
> --- a/arch/powerpc/kexec/file_load.c
> +++ b/arch/powerpc/kexec/file_load.c
> @@ -20,7 +20,6 @@
>  #include <linux/of_fdt.h>
>  #include <linux/libfdt.h>
>  #include <asm/setup.h>
> -#include <asm/ima.h>
>  
>  #define SLAVE_CODE_SIZE		256	/* First 0x100 bytes */
>  
> @@ -163,12 +162,6 @@ int setup_new_fdt(const struct kimage *image, void *fdt,
>  	if (ret)
>  		goto err;
>  
> -	ret = setup_ima_buffer(image, fdt, fdt_path_offset(fdt, "/chosen"));
> -	if (ret) {
> -		pr_err("Error setting up the new device tree.\n");
> -		return ret;
> -	}
> -
>  	return 0;
>  
>  err:

With this change, setup_new_fdt() is nothing more than a call to
of_kexec_setup_new_fdt(). It should be removed, and its caller should
call of_kexec_setup_new_fdt() directly.

This change could be done in patch 4 of this series, to keep this patch
simpler.

-- 
Thiago Jung Bauermann
IBM Linux Technology Center

WARNING: multiple messages have this Message-ID (diff)
From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Cc: mark.rutland@arm.com, benh@kernel.crashing.org,
	bhsharma@redhat.com, tao.li@vivo.com, zohar@linux.ibm.com,
	paulus@samba.org, vincenzo.frascino@arm.com,
	frowand.list@gmail.com, sashal@kernel.org, mpe@ellerman.id.au,
	masahiroy@kernel.org, jmorris@namei.org,
	takahiro.akashi@linaro.org, linux-arm-kernel@lists.infradead.org,
	catalin.marinas@arm.com, serge@hallyn.com,
	devicetree@vger.kernel.org, pasha.tatashin@soleen.com,
	will@kernel.org, prsriva@linux.microsoft.com,
	hsinyi@chromium.org, allison@lohutok.net,
	christophe.leroy@c-s.fr, mbrugger@suse.com,
	balajib@linux.microsoft.com, dmitry.kasatkin@gmail.com,
	linux-kernel@vger.kernel.org, james.morse@arm.com,
	gregkh@linuxfoundation.org, linux-integrity@vger.kernel.org
Subject: Re: [PATCH v13 2/6] powerpc: Move arch independent ima kexec functions to drivers/of/kexec.c
Date: Tue, 22 Dec 2020 21:48:02 -0300	[thread overview]
Message-ID: <875z4tl54t.fsf@manicouagan.localdomain> (raw)
In-Reply-To: <20201219175713.18888-3-nramas@linux.microsoft.com>


Actually, I have one more comment on this patch:

Lakshmi Ramasubramanian <nramas@linux.microsoft.com> writes:

> diff --git a/arch/powerpc/kexec/file_load.c b/arch/powerpc/kexec/file_load.c
> index 956bcb2d1ec2..9f3ec0b239ef 100644
> --- a/arch/powerpc/kexec/file_load.c
> +++ b/arch/powerpc/kexec/file_load.c
> @@ -20,7 +20,6 @@
>  #include <linux/of_fdt.h>
>  #include <linux/libfdt.h>
>  #include <asm/setup.h>
> -#include <asm/ima.h>
>  
>  #define SLAVE_CODE_SIZE		256	/* First 0x100 bytes */
>  
> @@ -163,12 +162,6 @@ int setup_new_fdt(const struct kimage *image, void *fdt,
>  	if (ret)
>  		goto err;
>  
> -	ret = setup_ima_buffer(image, fdt, fdt_path_offset(fdt, "/chosen"));
> -	if (ret) {
> -		pr_err("Error setting up the new device tree.\n");
> -		return ret;
> -	}
> -
>  	return 0;
>  
>  err:

With this change, setup_new_fdt() is nothing more than a call to
of_kexec_setup_new_fdt(). It should be removed, and its caller should
call of_kexec_setup_new_fdt() directly.

This change could be done in patch 4 of this series, to keep this patch
simpler.

-- 
Thiago Jung Bauermann
IBM Linux Technology Center

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-12-23  0:49 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-19 17:57 [PATCH v13 0/6] Carry forward IMA measurement log on kexec on ARM64 Lakshmi Ramasubramanian
2020-12-19 17:57 ` Lakshmi Ramasubramanian
2020-12-19 17:57 ` [PATCH v13 1/6] ima: Move arch_ima_add_kexec_buffer() to ima Lakshmi Ramasubramanian
2020-12-19 17:57   ` Lakshmi Ramasubramanian
2020-12-22 14:22   ` Mimi Zohar
2020-12-22 14:22     ` Mimi Zohar
2020-12-22 22:53   ` Thiago Jung Bauermann
2020-12-22 22:53     ` Thiago Jung Bauermann
2020-12-19 17:57 ` [PATCH v13 2/6] powerpc: Move arch independent ima kexec functions to drivers/of/kexec.c Lakshmi Ramasubramanian
2020-12-19 17:57   ` Lakshmi Ramasubramanian
2020-12-22 14:26   ` Mimi Zohar
2020-12-22 14:26     ` Mimi Zohar
2020-12-22 18:53     ` Lakshmi Ramasubramanian
2020-12-22 18:53       ` Lakshmi Ramasubramanian
2020-12-22 19:45       ` Mimi Zohar
2020-12-22 19:45         ` Mimi Zohar
2020-12-22 21:02         ` Lakshmi Ramasubramanian
2020-12-22 21:02           ` Lakshmi Ramasubramanian
2020-12-23  0:40           ` Thiago Jung Bauermann
2020-12-23  0:40             ` Thiago Jung Bauermann
2020-12-23  5:03             ` Lakshmi Ramasubramanian
2020-12-23  5:03               ` Lakshmi Ramasubramanian
2020-12-23  0:19   ` Thiago Jung Bauermann
2020-12-23  0:19     ` Thiago Jung Bauermann
2020-12-23  5:01     ` Lakshmi Ramasubramanian
2020-12-23  5:01       ` Lakshmi Ramasubramanian
2020-12-23 17:57       ` Thiago Jung Bauermann
2020-12-23 17:57         ` Thiago Jung Bauermann
2020-12-23  0:48   ` Thiago Jung Bauermann [this message]
2020-12-23  0:48     ` Thiago Jung Bauermann
2020-12-23  4:56     ` Lakshmi Ramasubramanian
2020-12-23  4:56       ` Lakshmi Ramasubramanian
2020-12-31 22:28   ` Rob Herring
2020-12-31 22:28     ` Rob Herring
2020-12-19 17:57 ` [PATCH v13 3/6] kexec: Use fdt_appendprop_addrrange() to add ima buffer to FDT Lakshmi Ramasubramanian
2020-12-19 17:57   ` Lakshmi Ramasubramanian
2020-12-23  0:57   ` Thiago Jung Bauermann
2020-12-23  0:57     ` Thiago Jung Bauermann
2020-12-19 17:57 ` [PATCH v13 4/6] powerpc: Delete unused function delete_fdt_mem_rsv() Lakshmi Ramasubramanian
2020-12-19 17:57   ` Lakshmi Ramasubramanian
2020-12-23  1:08   ` Thiago Jung Bauermann
2020-12-23  1:08     ` Thiago Jung Bauermann
2020-12-23  5:09     ` Lakshmi Ramasubramanian
2020-12-23  5:09       ` Lakshmi Ramasubramanian
2020-12-19 17:57 ` [PATCH v13 5/6] arm64: Free DTB buffer if fdt_open_into() fails Lakshmi Ramasubramanian
2020-12-19 17:57   ` Lakshmi Ramasubramanian
2020-12-23  1:11   ` Thiago Jung Bauermann
2020-12-23  1:11     ` Thiago Jung Bauermann
2020-12-19 17:57 ` [PATCH v13 6/6] arm64: Add IMA log information in kimage used for kexec Lakshmi Ramasubramanian
2020-12-19 17:57   ` Lakshmi Ramasubramanian
2020-12-23  1:17   ` Thiago Jung Bauermann
2020-12-23  1:17     ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875z4tl54t.fsf@manicouagan.localdomain \
    --to=bauerman@linux.ibm.com \
    --cc=allison@lohutok.net \
    --cc=balajib@linux.microsoft.com \
    --cc=benh@kernel.crashing.org \
    --cc=bhsharma@redhat.com \
    --cc=catalin.marinas@arm.com \
    --cc=christophe.leroy@c-s.fr \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsinyi@chromium.org \
    --cc=james.morse@arm.com \
    --cc=jmorris@namei.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=masahiroy@kernel.org \
    --cc=mbrugger@suse.com \
    --cc=mpe@ellerman.id.au \
    --cc=nramas@linux.microsoft.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=paulus@samba.org \
    --cc=prsriva@linux.microsoft.com \
    --cc=robh@kernel.org \
    --cc=sashal@kernel.org \
    --cc=serge@hallyn.com \
    --cc=takahiro.akashi@linaro.org \
    --cc=tao.li@vivo.com \
    --cc=vincenzo.frascino@arm.com \
    --cc=will@kernel.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.