All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@kernel.org>
To: kernel test robot <lkp@intel.com>,
	Amelie Delaunay <amelie.delaunay@st.com>,
	Minas Harutyunyan <hminas@synopsys.com>
Cc: kbuild-all@lists.01.org, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: Re: [balbi-usb:testing/next 1/39] drivers/usb/dwc2/drd.c:80:36: error: 'struct dwc2_hsotg' has no member named 'test_mode'
Date: Fri, 24 Jul 2020 10:51:47 +0300	[thread overview]
Message-ID: <875zadnyek.fsf@kernel.org> (raw)
In-Reply-To: <202007241311.MMbsxewn%lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

kernel test robot <lkp@intel.com> writes:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
> head:   74dbc49b08d37ed9d4fd440d8896626733f80564
> commit: bc0f0d4a5853e32ba97a0318f774570428fc5634 [1/39] usb: dwc2: override PHY input signals with usb role switch support
> config: nios2-randconfig-r002-20200724 (attached as .config)
> compiler: nios2-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout bc0f0d4a5853e32ba97a0318f774570428fc5634
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>    drivers/usb/dwc2/drd.c: In function 'dwc2_drd_role_sw_set':
>>> drivers/usb/dwc2/drd.c:80:36: error: 'struct dwc2_hsotg' has no member named 'test_mode'
>       80 |  if (role == USB_ROLE_NONE && hsotg->test_mode) {

weird, this compiled just fine here with allmodconfig on AArch64.

/me goes check. Oh, I see what's happening, hsotg->test_mode is only
compiled on Peripheral-only and Dual-role builds. I'm assuming this was
a Host-only build. Then the problem triggers because drd.o is
unconditionally added to the binary.

dwc2-y					:= core.o core_intr.o platform.o drd.o

Is this an old problem or was it triggered by $subject?

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [balbi-usb:testing/next 1/39] drivers/usb/dwc2/drd.c:80:36: error: 'struct dwc2_hsotg' has no member named 'test_mode'
Date: Fri, 24 Jul 2020 10:51:47 +0300	[thread overview]
Message-ID: <875zadnyek.fsf@kernel.org> (raw)
In-Reply-To: <202007241311.MMbsxewn%lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

kernel test robot <lkp@intel.com> writes:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
> head:   74dbc49b08d37ed9d4fd440d8896626733f80564
> commit: bc0f0d4a5853e32ba97a0318f774570428fc5634 [1/39] usb: dwc2: override PHY input signals with usb role switch support
> config: nios2-randconfig-r002-20200724 (attached as .config)
> compiler: nios2-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout bc0f0d4a5853e32ba97a0318f774570428fc5634
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
>    drivers/usb/dwc2/drd.c: In function 'dwc2_drd_role_sw_set':
>>> drivers/usb/dwc2/drd.c:80:36: error: 'struct dwc2_hsotg' has no member named 'test_mode'
>       80 |  if (role == USB_ROLE_NONE && hsotg->test_mode) {

weird, this compiled just fine here with allmodconfig on AArch64.

/me goes check. Oh, I see what's happening, hsotg->test_mode is only
compiled on Peripheral-only and Dual-role builds. I'm assuming this was
a Host-only build. Then the problem triggers because drd.o is
unconditionally added to the binary.

dwc2-y					:= core.o core_intr.o platform.o drd.o

Is this an old problem or was it triggered by $subject?

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2020-07-24  7:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-24  5:17 [balbi-usb:testing/next 1/39] drivers/usb/dwc2/drd.c:80:36: error: 'struct dwc2_hsotg' has no member named 'test_mode' kernel test robot
2020-07-24  5:17 ` kernel test robot
2020-07-24  7:51 ` Felipe Balbi [this message]
2020-07-24  7:51   ` Felipe Balbi
2020-07-24  7:59   ` Amelie DELAUNAY
2020-07-24  7:59     ` Amelie DELAUNAY
2020-07-24 10:48     ` Amelie DELAUNAY
2020-07-24 10:48       ` Amelie DELAUNAY
2020-07-24 12:31       ` Amelie DELAUNAY
2020-07-24 12:31         ` Amelie DELAUNAY

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875zadnyek.fsf@kernel.org \
    --to=balbi@kernel.org \
    --cc=amelie.delaunay@st.com \
    --cc=hminas@synopsys.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.