* [Buildroot] [PATCH] package/pkg-generic.mk: in image install, print message before pre-hooks
@ 2020-02-28 15:04 Thomas Petazzoni
2020-02-29 16:33 ` Peter Korsgaard
2020-03-14 17:50 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2020-02-28 15:04 UTC (permalink / raw)
To: buildroot
In all steps, we print the message indicating the start of the step
using the MESSAGE macro before running pre-hooks. Except in the image
installation step, where the message is printed after the pre-hooks.
Let's fix this inconsistency.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/pkg-generic.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index 7b240ca012..c1b9fe2e59 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -347,8 +347,8 @@ $(BUILD_DIR)/%/.stamp_staging_installed:
$(BUILD_DIR)/%/.stamp_images_installed:
@$(call step_start,install-image)
@mkdir -p $(BINARIES_DIR)
- $(foreach hook,$($(PKG)_PRE_INSTALL_IMAGES_HOOKS),$(call $(hook))$(sep))
@$(call MESSAGE,"Installing to images directory")
+ $(foreach hook,$($(PKG)_PRE_INSTALL_IMAGES_HOOKS),$(call $(hook))$(sep))
+$($(PKG)_INSTALL_IMAGES_CMDS)
$(foreach hook,$($(PKG)_POST_INSTALL_IMAGES_HOOKS),$(call $(hook))$(sep))
@$(call step_end,install-image)
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/pkg-generic.mk: in image install, print message before pre-hooks
2020-02-28 15:04 [Buildroot] [PATCH] package/pkg-generic.mk: in image install, print message before pre-hooks Thomas Petazzoni
@ 2020-02-29 16:33 ` Peter Korsgaard
2020-03-14 17:50 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2020-02-29 16:33 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> In all steps, we print the message indicating the start of the step
> using the MESSAGE macro before running pre-hooks. Except in the image
> installation step, where the message is printed after the pre-hooks.
> Let's fix this inconsistency.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/pkg-generic.mk: in image install, print message before pre-hooks
2020-02-28 15:04 [Buildroot] [PATCH] package/pkg-generic.mk: in image install, print message before pre-hooks Thomas Petazzoni
2020-02-29 16:33 ` Peter Korsgaard
@ 2020-03-14 17:50 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2020-03-14 17:50 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> In all steps, we print the message indicating the start of the step
> using the MESSAGE macro before running pre-hooks. Except in the image
> installation step, where the message is printed after the pre-hooks.
> Let's fix this inconsistency.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed to 2019.02.x and 2019.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-14 17:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 15:04 [Buildroot] [PATCH] package/pkg-generic.mk: in image install, print message before pre-hooks Thomas Petazzoni
2020-02-29 16:33 ` Peter Korsgaard
2020-03-14 17:50 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.