From: Fabiano Rosas <farosas@linux.ibm.com> To: Aravinda Prasad <aravinda@linux.vnet.ibm.com> Cc: paulus@ozlabs.org, mahesh@linux.vnet.ibm.com, aik@au1.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, david@gibson.dropbear.id.au Subject: Re: [Qemu-devel] [PATCH v8 4/6] target/ppc: Build rtas error log upon an MCE Date: Tue, 23 Apr 2019 11:38:48 -0300 [thread overview] Message-ID: <875zr43hxj.fsf@linux.ibm.com> (raw) In-Reply-To: <155591660602.20338.9804738040071843715.stgit@aravinda> Aravinda Prasad <aravinda@linux.vnet.ibm.com> writes: > + /* > + * Properly set bits in MSR before we invoke the handler. > + * SRR0/1, DAR and DSISR are properly set by KVM > + */ > + if (!(*pcc->interrupts_big_endian)(cpu)) { > + msr |= (1ULL << MSR_LE); > + } > + > + if (env->msr && (1ULL << MSR_SF)) { Don't you mean & instead of &&? > + msr |= (1ULL << MSR_SF); > + }
WARNING: multiple messages have this Message-ID (diff)
From: Fabiano Rosas <farosas@linux.ibm.com> To: Aravinda Prasad <aravinda@linux.vnet.ibm.com> Cc: aik@au1.ibm.com, qemu-devel@nongnu.org, paulus@ozlabs.org, qemu-ppc@nongnu.org, david@gibson.dropbear.id.au Subject: Re: [Qemu-devel] [PATCH v8 4/6] target/ppc: Build rtas error log upon an MCE Date: Tue, 23 Apr 2019 11:38:48 -0300 [thread overview] Message-ID: <875zr43hxj.fsf@linux.ibm.com> (raw) Message-ID: <20190423143848.C0_BGVc1ddsr-A_we1NNxsB3bkuqANWW4HjIu2ZsHUI@z> (raw) In-Reply-To: <155591660602.20338.9804738040071843715.stgit@aravinda> Aravinda Prasad <aravinda@linux.vnet.ibm.com> writes: > + /* > + * Properly set bits in MSR before we invoke the handler. > + * SRR0/1, DAR and DSISR are properly set by KVM > + */ > + if (!(*pcc->interrupts_big_endian)(cpu)) { > + msr |= (1ULL << MSR_LE); > + } > + > + if (env->msr && (1ULL << MSR_SF)) { Don't you mean & instead of &&? > + msr |= (1ULL << MSR_SF); > + }
next prev parent reply other threads:[~2019-04-23 14:39 UTC|newest] Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-22 7:02 [Qemu-devel] [PATCH v8 0/6] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests Aravinda Prasad 2019-04-22 7:02 ` Aravinda Prasad 2019-04-22 7:02 ` [Qemu-devel] [PATCH v8 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls Aravinda Prasad 2019-04-22 7:02 ` Aravinda Prasad 2019-04-23 6:45 ` David Gibson 2019-04-23 6:45 ` David Gibson 2019-04-25 4:56 ` Aravinda Prasad 2019-04-25 4:56 ` Aravinda Prasad 2019-05-10 9:06 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz 2019-05-10 9:54 ` David Gibson 2019-05-10 14:33 ` Greg Kurz 2019-05-13 4:57 ` Aravinda Prasad 2019-05-13 4:53 ` Aravinda Prasad 2019-04-22 7:03 ` [Qemu-devel] [PATCH v8 2/6] Wrapper function to wait on condition for the main loop mutex Aravinda Prasad 2019-04-22 7:03 ` Aravinda Prasad 2019-04-23 6:47 ` David Gibson 2019-04-23 6:47 ` David Gibson 2019-05-10 13:14 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz 2019-04-22 7:03 ` [Qemu-devel] [PATCH v8 3/6] target/ppc: Handle NMI guest exit Aravinda Prasad 2019-04-22 7:03 ` Aravinda Prasad 2019-04-23 6:53 ` David Gibson 2019-04-23 6:53 ` David Gibson 2019-04-24 4:50 ` [Qemu-devel] [Qemu-ppc] " Aravinda Prasad 2019-04-24 4:50 ` Aravinda Prasad 2019-05-10 6:37 ` David Gibson 2019-05-10 6:58 ` Aravinda Prasad 2019-05-10 16:25 ` Greg Kurz 2019-05-13 5:40 ` Aravinda Prasad 2019-05-13 5:56 ` David Gibson 2019-04-22 7:03 ` [Qemu-devel] [PATCH v8 4/6] target/ppc: Build rtas error log upon an MCE Aravinda Prasad 2019-04-22 7:03 ` Aravinda Prasad 2019-04-23 14:38 ` Fabiano Rosas [this message] 2019-04-23 14:38 ` Fabiano Rosas 2019-04-24 4:51 ` [Qemu-devel] [Qemu-ppc] " Aravinda Prasad 2019-04-24 4:51 ` Aravinda Prasad 2019-05-10 6:42 ` [Qemu-devel] " David Gibson 2019-05-10 7:05 ` Aravinda Prasad 2019-05-10 9:52 ` David Gibson 2019-05-13 5:00 ` Aravinda Prasad 2019-05-13 11:30 ` [Qemu-devel] [Qemu-ppc] " Greg Kurz 2019-05-14 0:08 ` David Gibson 2019-05-14 4:26 ` Aravinda Prasad 2019-05-14 4:40 ` David Gibson 2019-05-14 5:06 ` Aravinda Prasad 2019-05-16 1:47 ` David Gibson 2019-05-16 4:54 ` Aravinda Prasad 2019-04-22 7:03 ` [Qemu-devel] [PATCH v8 5/6] ppc: spapr: Enable FWNMI capability Aravinda Prasad 2019-04-22 7:03 ` Aravinda Prasad 2019-05-10 6:46 ` David Gibson 2019-05-10 7:15 ` [Qemu-devel] [Qemu-ppc] " Aravinda Prasad 2019-05-10 9:53 ` David Gibson 2019-05-13 10:30 ` Aravinda Prasad 2019-05-14 4:47 ` David Gibson 2019-05-14 5:32 ` Aravinda Prasad 2019-05-16 1:45 ` David Gibson 2019-05-16 4:59 ` Aravinda Prasad 2019-04-22 7:03 ` [Qemu-devel] [PATCH v8 6/6] migration: Block migration while handling machine check Aravinda Prasad 2019-04-22 7:03 ` Aravinda Prasad 2019-05-10 6:51 ` David Gibson 2019-05-10 7:16 ` Aravinda Prasad 2019-05-29 5:46 ` [Qemu-devel] [Qemu-ppc] " Aravinda Prasad 2019-05-16 10:54 ` Greg Kurz 2019-05-16 10:59 ` Aravinda Prasad 2019-05-16 14:17 ` Dr. David Alan Gilbert 2019-05-20 5:57 ` Aravinda Prasad
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=875zr43hxj.fsf@linux.ibm.com \ --to=farosas@linux.ibm.com \ --cc=aik@au1.ibm.com \ --cc=aravinda@linux.vnet.ibm.com \ --cc=david@gibson.dropbear.id.au \ --cc=mahesh@linux.vnet.ibm.com \ --cc=paulus@ozlabs.org \ --cc=qemu-devel@nongnu.org \ --cc=qemu-ppc@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.