All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lluís Vilanova" <vilanova@ac.upc.edu>
To: qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@gmail.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v6 2/4] trace: Remove unnecessary intermediate event copies
Date: Thu, 11 Feb 2016 15:30:34 +0100	[thread overview]
Message-ID: <8760xv9v5h.fsf@fimbulvetr.bsc.es> (raw)
In-Reply-To: <145505247535.4785.10937373381145935912.stgit@localhost> (=?utf-8?Q?=22Llu=C3=ADs?= Vilanova"'s message of "Tue, 9 Feb 2016 22:14:35 +0100")

Lluís Vilanova writes:

> The current code forces the use of a chain of ".original" dereferences,
> which looks odd.

> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
>  scripts/tracetool/__init__.py        |    4 +---
>  scripts/tracetool/format/events_h.py |    4 ++--
>  scripts/tracetool/format/tcg_h.py    |    4 ++--
>  3 files changed, 5 insertions(+), 7 deletions(-)

> diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
> index 0663e7f..1bf9246 100644
> --- a/scripts/tracetool/__init__.py
> +++ b/scripts/tracetool/__init__.py
> @@ -6,7 +6,7 @@ Machinery for generating tracing-related intermediate files.
>  """
 
>  __author__     = "Lluís Vilanova <vilanova@ac.upc.edu>"
> -__copyright__  = "Copyright 2012-2014, Lluís Vilanova <vilanova@ac.upc.edu>"
> +__copyright__  = "Copyright 2012-2016, Lluís Vilanova <vilanova@ac.upc.edu>"
>  __license__    = "GPL version 2 or (at your option) any later version"
 
>  __maintainer__ = "Stefan Hajnoczi"
> @@ -287,8 +287,6 @@ def _read_events(fobj):
>                      event.args):
>                  if atrans == aorig:
>                      args_trans.append(atrans)
> -            event_trans.args = Arguments(args_trans)
> -            event_trans = event_trans.copy()
 
>              event_exec = event.copy()
>              event_exec.name += "_exec"

I've detected an error in this piece. Please ignore this patch until v7.


Thanks,
  Lluis

  reply	other threads:[~2016-02-11 14:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-09 21:14 [Qemu-devel] [PATCH v6 0/4] trace: Show vCPU info in guest code events Lluís Vilanova
2016-02-09 21:14 ` [Qemu-devel] [PATCH v6 1/4] trace: Extend API to manage event arguments Lluís Vilanova
2016-02-09 21:14 ` [Qemu-devel] [PATCH v6 2/4] trace: Remove unnecessary intermediate event copies Lluís Vilanova
2016-02-11 14:30   ` Lluís Vilanova [this message]
2016-02-09 21:14 ` [Qemu-devel] [PATCH v6 3/4] tcg: Add type for vCPU pointers Lluís Vilanova
2016-02-10  3:24   ` Richard Henderson
2016-02-10 13:15     ` Lluís Vilanova
2016-02-10 13:38       ` Lluís Vilanova
2016-02-09 21:14 ` [Qemu-devel] [PATCH v6 4/4] trace: Add 'vcpu' event property to trace guest vCPU Lluís Vilanova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8760xv9v5h.fsf@fimbulvetr.bsc.es \
    --to=vilanova@ac.upc.edu \
    --cc=alex.bennee@linaro.org \
    --cc=ehabkost@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.