All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 0/7]  Various fixes
@ 2015-02-27  9:19 Fabio Porcedda
  2015-02-27  9:19 ` [Buildroot] [PATCH 1/7] shared-mime-info: host variant requires libxml2 and libglib2 Fabio Porcedda
                   ` (6 more replies)
  0 siblings, 7 replies; 19+ messages in thread
From: Fabio Porcedda @ 2015-02-27  9:19 UTC (permalink / raw)
  To: buildroot

Hi all,
this patch set fix:
- some build failures
- some error messages
- some optional dependencies

Best regards

Fabio Porcedda (7):
  shared-mime-info: host variant requires libxml2 and libglib2
  libxmlrpc: add missing braces for variable CURL_CONFIG in patch 4
  x11r7/xcb-util-keysyms: depends on host-pkgconf and libxcb
  package/civetweb: fix build error on a host with make v4.0
  freetype: host-freetype-patch requires host-automake
  package/efl/libevas: add optional dependency libfribidi
  package/libfribidi: add optional dependency libglib2

 ...ua-fix-a-typo-changing-LFS_DIR-to-LFS_DIR.patch | 27 ++++++++++++++++++++++
 package/efl/libevas/libevas.mk                     |  7 ++++++
 package/freetype/freetype.mk                       |  7 +++---
 package/libfribidi/libfribidi.mk                   |  6 +++++
 .../libxmlrpc/0004-use-correct-curl-config.patch   |  8 +++----
 package/shared-mime-info/shared-mime-info.mk       |  5 ++--
 package/x11r7/xcb-util-keysyms/Config.in           |  1 +
 package/x11r7/xcb-util-keysyms/xcb-util-keysyms.mk |  2 ++
 8 files changed, 54 insertions(+), 9 deletions(-)
 create mode 100644 package/civetweb/0001-Lua-fix-a-typo-changing-LFS_DIR-to-LFS_DIR.patch

-- 
2.3.0

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 1/7] shared-mime-info: host variant requires libxml2 and libglib2
  2015-02-27  9:19 [Buildroot] [PATCH 0/7] Various fixes Fabio Porcedda
@ 2015-02-27  9:19 ` Fabio Porcedda
  2015-03-01 21:02   ` Peter Korsgaard
  2015-02-27  9:19 ` [Buildroot] [PATCH 2/7] libxmlrpc: add missing braces for variable CURL_CONFIG in patch 4 Fabio Porcedda
                   ` (5 subsequent siblings)
  6 siblings, 1 reply; 19+ messages in thread
From: Fabio Porcedda @ 2015-02-27  9:19 UTC (permalink / raw)
  To: buildroot

Add to HOST_SHARED_MIME_INFO_DEPENDENCIES the missing dependencies
host-libxml2 and host-libglib2.

Also remove from SHARED_MIME_INFO_DEPENDENCIES dependencies already
present in HOST_SHARED_MIME_INFO_DEPENDENCIES.

Fix build failure:
configure: error: Package requirements ( libxml-2.0 >= 2.4 glib-2.0 >= 2.6.0) were not met

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 package/shared-mime-info/shared-mime-info.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/shared-mime-info/shared-mime-info.mk b/package/shared-mime-info/shared-mime-info.mk
index 978cd31..80a9526 100644
--- a/package/shared-mime-info/shared-mime-info.mk
+++ b/package/shared-mime-info/shared-mime-info.mk
@@ -9,13 +9,14 @@ SHARED_MIME_INFO_SOURCE = shared-mime-info-$(SHARED_MIME_INFO_VERSION).tar.bz2
 SHARED_MIME_INFO_SITE = http://freedesktop.org/~hadess
 SHARED_MIME_INFO_INSTALL_STAGING = YES
 SHARED_MIME_INFO_CONF_ENV = XMLLINT=$(HOST_DIR)/usr/bin/xmllint
-SHARED_MIME_INFO_DEPENDENCIES = host-pkgconf host-libglib2 host-libxml2 host-shared-mime-info libxml2 libglib2
+SHARED_MIME_INFO_DEPENDENCIES = host-shared-mime-info libxml2 libglib2
 SHARED_MIME_INFO_CONF_OPTS = --disable-update-mimedb
 SHARED_MIME_INFO_MAKE = $(MAKE1)
 SHARED_MIME_INFO_LICENSE = GPLv2
 SHARED_MIME_INFO_LICENSE_FILES = COPYING
 
-HOST_SHARED_MIME_INFO_DEPENDENCIES = host-pkgconf host-intltool
+HOST_SHARED_MIME_INFO_DEPENDENCIES = \
+	host-pkgconf host-intltool host-libxml2 host-libglib2
 
 HOST_SHARED_MIME_INFO_CONF_OPTS = --disable-update-mimedb
 HOST_SHARED_MIME_INFO_MAKE = $(MAKE1)
-- 
2.3.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 2/7] libxmlrpc: add missing braces for variable CURL_CONFIG in patch 4
  2015-02-27  9:19 [Buildroot] [PATCH 0/7] Various fixes Fabio Porcedda
  2015-02-27  9:19 ` [Buildroot] [PATCH 1/7] shared-mime-info: host variant requires libxml2 and libglib2 Fabio Porcedda
@ 2015-02-27  9:19 ` Fabio Porcedda
  2015-02-27 16:19   ` Peter Korsgaard
  2015-02-27  9:19 ` [Buildroot] [PATCH 3/7] x11r7/xcb-util-keysyms: depends on host-pkgconf and libxcb Fabio Porcedda
                   ` (4 subsequent siblings)
  6 siblings, 1 reply; 19+ messages in thread
From: Fabio Porcedda @ 2015-02-27  9:19 UTC (permalink / raw)
  To: buildroot

Change $CURL_CONFIG to $(CURL_CONFIG) in the patch
0004-use-correct-curl-config.patch because in a makefile the braces are
required to expand a variable.

Fix error messages:
make[3]: Entering directory '/home/tetsuya/buildroot/br2/output/build/libxmlrpc-1.25.30/lib/curl_transport'
make[3]: URL_CONFIG: Command not found
/bin/sh: line 0: test: <: unary operator expected
make[3]: URL_CONFIG: Command not found

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 package/libxmlrpc/0004-use-correct-curl-config.patch | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/package/libxmlrpc/0004-use-correct-curl-config.patch b/package/libxmlrpc/0004-use-correct-curl-config.patch
index c0646d3..b581643 100644
--- a/package/libxmlrpc/0004-use-correct-curl-config.patch
+++ b/package/libxmlrpc/0004-use-correct-curl-config.patch
@@ -55,7 +55,7 @@ Index: b/lib/curl_transport/Makefile
  $(SRCDIR)/common.mk: srcdir blddir
  
 -CURL_VERSION := $(shell curl-config --vernum)
-+CURL_VERSION := $(shell $CURL_CONFIG --vernum)
++CURL_VERSION := $(shell $(CURL_CONFIG) --vernum)
  
  # Some time at or before Curl 7.12, <curl/types.h> became an empty file
  # (no-op).  Some time after Curl 7.18, <curl/types.h> ceased to exist.
@@ -64,7 +64,7 @@ Index: b/lib/curl_transport/Makefile
  endif
  
 -CURL_INCLUDES := $(shell curl-config --cflags)
-+CURL_INCLUDES := $(shell $CURL_CONFIG --cflags)
++CURL_INCLUDES := $(shell $(CURL_CONFIG) --cflags)
  # We expect that curl-config --cflags just gives us -I options, because
  # we need just the -I options for 'make dep'.  Plus, it's scary to think
  # of what any other compiler flag would do to our compile.
@@ -77,7 +77,7 @@ Index: b/src/cpp/test/Makefile
  
  ifeq ($(MUST_BUILD_CURL_CLIENT),yes)
 -  LIBS += $(shell curl-config --libs)
-+  LIBS += $(shell $CURL_CONFIG --libs)
++  LIBS += $(shell $(CURL_CONFIG) --libs)
  endif
  ifeq ($(MUST_BUILD_LIBWWW_CLIENT),yes)
    LIBS += $(shell libwww-config --libs)
@@ -90,7 +90,7 @@ Index: b/tools/common.mk
  endif
  ifeq ($(MUST_BUILD_CURL_CLIENT),yes)
 -  CLIENT_LDLIBS += $(shell curl-config --libs)
-+  CLIENT_LDLIBS += $(shell $CURL_CONFIG --libs)
++  CLIENT_LDLIBS += $(shell $(CURL_CONFIG) --libs)
  endif
  ifeq ($(MUST_BUILD_WININET_CLIENT),yes)
    CLIENT_LDLIBS += $(shell wininet-config --libs)
-- 
2.3.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 3/7] x11r7/xcb-util-keysyms: depends on host-pkgconf and libxcb
  2015-02-27  9:19 [Buildroot] [PATCH 0/7] Various fixes Fabio Porcedda
  2015-02-27  9:19 ` [Buildroot] [PATCH 1/7] shared-mime-info: host variant requires libxml2 and libglib2 Fabio Porcedda
  2015-02-27  9:19 ` [Buildroot] [PATCH 2/7] libxmlrpc: add missing braces for variable CURL_CONFIG in patch 4 Fabio Porcedda
@ 2015-02-27  9:19 ` Fabio Porcedda
  2015-02-28  9:44   ` Peter Korsgaard
  2015-02-27  9:19 ` [Buildroot] [PATCH 4/7] package/civetweb: fix build error on a host with make v4.0 Fabio Porcedda
                   ` (3 subsequent siblings)
  6 siblings, 1 reply; 19+ messages in thread
From: Fabio Porcedda @ 2015-02-27  9:19 UTC (permalink / raw)
  To: buildroot

Fix build failure:
./configure: line 11453: /home/tetsuya/buildroot/br/output/host/usr/bin/pkg-config: No such file or directory
configure: error: in `/home/tetsuya/buildroot/br/output/build/xcb-util-keysyms-0.3.9':
configure: error: The pkg-config script could not be found or is too old.  Make sure it
is in your PATH or set the PKG_CONFIG environment variable to the full
path to pkg-config.

Fix build failure:
configure: error: Package requirements (xcb >= 1.4) were not met:

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 package/x11r7/xcb-util-keysyms/Config.in           | 1 +
 package/x11r7/xcb-util-keysyms/xcb-util-keysyms.mk | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/package/x11r7/xcb-util-keysyms/Config.in b/package/x11r7/xcb-util-keysyms/Config.in
index ef42eb2..0c1d8cc 100644
--- a/package/x11r7/xcb-util-keysyms/Config.in
+++ b/package/x11r7/xcb-util-keysyms/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_XCB_UTIL_KEYSYMS
 	bool "xcb-util-keysyms"
+	select BR2_PACKAGE_LIBXCB
 	help
 	  The XCB util modules provides a number of libraries which sit on top
 	  of libxcb, the core X protocol library, and some of the extension
diff --git a/package/x11r7/xcb-util-keysyms/xcb-util-keysyms.mk b/package/x11r7/xcb-util-keysyms/xcb-util-keysyms.mk
index 0f653c3..6bc0a79 100644
--- a/package/x11r7/xcb-util-keysyms/xcb-util-keysyms.mk
+++ b/package/x11r7/xcb-util-keysyms/xcb-util-keysyms.mk
@@ -13,4 +13,6 @@ XCB_UTIL_KEYSYMS_LICENSE = MIT
 
 XCB_UTIL_KEYSYMS_INSTALL_STAGING = YES
 
+XCB_UTIL_KEYSYMS_DEPENDENCIES = host-pkgconf libxcb
+
 $(eval $(autotools-package))
-- 
2.3.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 4/7] package/civetweb: fix build error on a host with make v4.0
  2015-02-27  9:19 [Buildroot] [PATCH 0/7] Various fixes Fabio Porcedda
                   ` (2 preceding siblings ...)
  2015-02-27  9:19 ` [Buildroot] [PATCH 3/7] x11r7/xcb-util-keysyms: depends on host-pkgconf and libxcb Fabio Porcedda
@ 2015-02-27  9:19 ` Fabio Porcedda
  2015-02-28  9:05   ` Peter Korsgaard
  2015-02-27  9:19 ` [Buildroot] [PATCH 5/7] freetype: host-freetype-patch requires host-automake Fabio Porcedda
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 19+ messages in thread
From: Fabio Porcedda @ 2015-02-27  9:19 UTC (permalink / raw)
  To: buildroot

Add a patch to fix a typo that on a system with make v4.0 and
BR2_CIVETWEB_WITH_LUA=y fails to build:
  Makefile:203: *** mixed implicit and normal rules.  Stop.

The patch was not sent upstream because this problem is already fixed on
master.

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 ...ua-fix-a-typo-changing-LFS_DIR-to-LFS_DIR.patch | 27 ++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 package/civetweb/0001-Lua-fix-a-typo-changing-LFS_DIR-to-LFS_DIR.patch

diff --git a/package/civetweb/0001-Lua-fix-a-typo-changing-LFS_DIR-to-LFS_DIR.patch b/package/civetweb/0001-Lua-fix-a-typo-changing-LFS_DIR-to-LFS_DIR.patch
new file mode 100644
index 0000000..aee3cfc
--- /dev/null
+++ b/package/civetweb/0001-Lua-fix-a-typo-changing-LFS_DIR-to-LFS_DIR.patch
@@ -0,0 +1,27 @@
+From 0821066f9adf8410891cd07684ecac50a9bc36a4 Mon Sep 17 00:00:00 2001
+From: Fabio Porcedda <fabio.porcedda@gmail>
+Date: Wed, 25 Feb 2015 18:40:24 +0100
+Subject: [PATCH] Lua: fix a typo changing %(LFS_DIR) to $(LFS_DIR)
+
+Also this fix a error on GNU Make v4.0:
+  Makefile:203: *** mixed implicit and normal rules.  Stop.
+
+Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail>
+---
+ resources/Makefile.in-lua | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/resources/Makefile.in-lua b/resources/Makefile.in-lua
+index 0902f11..f3d95fd 100644
+--- a/resources/Makefile.in-lua
++++ b/resources/Makefile.in-lua
+@@ -57,5 +57,5 @@ LFS_CFLAGS = -I$(LFS_DIR)
+ 
+ OBJECTS += $(LUA_OBJECTS) $(SQLITE_OBJECTS) $(LFS_OBJECTS)
+ CFLAGS += $(LUA_CFLAGS) $(SQLITE_CFLAGS) $(LFS_CFLAGS) -DUSE_LUA -DUSE_LUA_SQLITE3 -DUSE_LUA_FILE_SYSTEM
+-SOURCE_DIRS = $(LUA_DIR) $(SQLITE_DIR) %(LFS_DIR)
++SOURCE_DIRS = $(LUA_DIR) $(SQLITE_DIR) $(LFS_DIR)
+ 
+-- 
+2.3.0
+
-- 
2.3.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 5/7] freetype: host-freetype-patch requires host-automake
  2015-02-27  9:19 [Buildroot] [PATCH 0/7] Various fixes Fabio Porcedda
                   ` (3 preceding siblings ...)
  2015-02-27  9:19 ` [Buildroot] [PATCH 4/7] package/civetweb: fix build error on a host with make v4.0 Fabio Porcedda
@ 2015-02-27  9:19 ` Fabio Porcedda
  2015-02-27 14:28   ` Thomas Petazzoni
  2015-02-28  9:11   ` Peter Korsgaard
  2015-02-27  9:19 ` [Buildroot] [PATCH 6/7] package/efl/libevas: add optional dependency libfribidi Fabio Porcedda
  2015-02-27  9:19 ` [Buildroot] [PATCH 7/7] package/libfribidi: add optional dependency libglib2 Fabio Porcedda
  6 siblings, 2 replies; 19+ messages in thread
From: Fabio Porcedda @ 2015-02-27  9:19 UTC (permalink / raw)
  To: buildroot

The "make host-freetype-patch" fails because using the autogen.sh script
it doesn't found the autoconf tool, the problem was already fixed for
"make freetype-patch" adding the "host-automake" as a prerequisite to
freetype-patch, so fix it by adding "host-automake" as a prerequisite to
"host-freetype-patch" too.

Fix build failure:
running `autoconf --force'
./autogen.sh: line 15: autoconf: command not found
error while running `autoconf --force'
package/pkg-generic.mk:146: recipe for target 'buildroot/output/build/host-freetype-2.5.5/.stamp_patched' failed

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 package/freetype/freetype.mk | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/package/freetype/freetype.mk b/package/freetype/freetype.mk
index 0de5ce3..56274cb 100644
--- a/package/freetype/freetype.mk
+++ b/package/freetype/freetype.mk
@@ -98,6 +98,7 @@ HOST_FREETYPE_POST_INSTALL_HOOKS += HOST_FREETYPE_FIX_FREETYPE_INCLUDE
 $(eval $(autotools-package))
 $(eval $(host-autotools-package))
 
-# freetype-patch uses autogen.sh so add it as a order-only-prerequisite
-# because it is a phony target.
-$(FREETYPE_TARGET_PATCH): | host-automake
+# freetype-patch and host-freetype-patch use autogen.sh so add
+# host-automake as a order-only-prerequisite because it is a phony
+# target.
+$(FREETYPE_TARGET_PATCH) $(HOST_FREETYPE_TARGET_PATCH): | host-automake
-- 
2.3.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 6/7] package/efl/libevas: add optional dependency libfribidi
  2015-02-27  9:19 [Buildroot] [PATCH 0/7] Various fixes Fabio Porcedda
                   ` (4 preceding siblings ...)
  2015-02-27  9:19 ` [Buildroot] [PATCH 5/7] freetype: host-freetype-patch requires host-automake Fabio Porcedda
@ 2015-02-27  9:19 ` Fabio Porcedda
  2015-03-01 21:02   ` Peter Korsgaard
  2015-02-27  9:19 ` [Buildroot] [PATCH 7/7] package/libfribidi: add optional dependency libglib2 Fabio Porcedda
  6 siblings, 1 reply; 19+ messages in thread
From: Fabio Porcedda @ 2015-02-27  9:19 UTC (permalink / raw)
  To: buildroot

Fix the following message when libfribidi is enabled but not already
built:
Package fribidi was not found in the pkg-config search path.
Perhaps you should add the directory containing `fribidi.pc'
No package 'fribidi' found

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 package/efl/libevas/libevas.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/efl/libevas/libevas.mk b/package/efl/libevas/libevas.mk
index 40a01e7..10c3bc3 100644
--- a/package/efl/libevas/libevas.mk
+++ b/package/efl/libevas/libevas.mk
@@ -225,6 +225,13 @@ else
 LIBEVAS_CONF_OPTS += --disable-fontconfig
 endif
 
+ifeq ($(BR2_PACKAGE_LIBFRIBIDI),y)
+LIBEVAS_CONF_OPTS += --enable-fribidi
+LIBEVAS_DEPENDENCIES += libfribidi
+else
+LIBEVAS_CONF_OPTS += --disable-fribidi
+endif
+
 # libevas installs the source code of examples on the target, which
 # are generally not useful.
 define LIBEVAS_REMOVE_EXAMPLES
-- 
2.3.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 7/7] package/libfribidi: add optional dependency libglib2
  2015-02-27  9:19 [Buildroot] [PATCH 0/7] Various fixes Fabio Porcedda
                   ` (5 preceding siblings ...)
  2015-02-27  9:19 ` [Buildroot] [PATCH 6/7] package/efl/libevas: add optional dependency libfribidi Fabio Porcedda
@ 2015-02-27  9:19 ` Fabio Porcedda
  2015-03-01 21:03   ` Peter Korsgaard
  6 siblings, 1 reply; 19+ messages in thread
From: Fabio Porcedda @ 2015-02-27  9:19 UTC (permalink / raw)
  To: buildroot

Fix the following message when libglib2 is enabled but not already
built:
Package glib-2.0 was not found in the pkg-config search path.
Perhaps you should add the directory containing `glib-2.0.pc'
No package 'glib-2.0' found

Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
---
 package/libfribidi/libfribidi.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/package/libfribidi/libfribidi.mk b/package/libfribidi/libfribidi.mk
index 20a5df0..12e7664 100644
--- a/package/libfribidi/libfribidi.mk
+++ b/package/libfribidi/libfribidi.mk
@@ -15,4 +15,10 @@ LIBFRIBIDI_INSTALL_STAGING = YES
 LIBFRIBIDI_AUTORECONF = YES
 LIBFRIBIDI_DEPENDENCIES = host-pkgconf
 
+ifeq ($(BR2_PACKAGE_LIBGLIB2),y)
+ LIBFRIBIDI_DEPENDENCIES += libglib2
+else
+ LIBFRIBIDI_CONF_OPTS += --with-glib=no
+endif
+
 $(eval $(autotools-package))
-- 
2.3.0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 5/7] freetype: host-freetype-patch requires host-automake
  2015-02-27  9:19 ` [Buildroot] [PATCH 5/7] freetype: host-freetype-patch requires host-automake Fabio Porcedda
@ 2015-02-27 14:28   ` Thomas Petazzoni
  2015-02-27 18:32     ` Fabio Porcedda
  2015-02-28  9:11   ` Peter Korsgaard
  1 sibling, 1 reply; 19+ messages in thread
From: Thomas Petazzoni @ 2015-02-27 14:28 UTC (permalink / raw)
  To: buildroot

Dear Fabio Porcedda,

On Fri, 27 Feb 2015 10:19:22 +0100, Fabio Porcedda wrote:
> The "make host-freetype-patch" fails because using the autogen.sh script
> it doesn't found the autoconf tool, the problem was already fixed for
> "make freetype-patch" adding the "host-automake" as a prerequisite to
> freetype-patch, so fix it by adding "host-automake" as a prerequisite to
> "host-freetype-patch" too.
> 
> Fix build failure:
> running `autoconf --force'
> ./autogen.sh: line 15: autoconf: command not found
> error while running `autoconf --force'
> package/pkg-generic.mk:146: recipe for target 'buildroot/output/build/host-freetype-2.5.5/.stamp_patched' failed
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Maybe this has been discussed before, but why are we doing the autogen
in a post patch hook rather than in a pre-configure hook ?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 2/7] libxmlrpc: add missing braces for variable CURL_CONFIG in patch 4
  2015-02-27  9:19 ` [Buildroot] [PATCH 2/7] libxmlrpc: add missing braces for variable CURL_CONFIG in patch 4 Fabio Porcedda
@ 2015-02-27 16:19   ` Peter Korsgaard
  0 siblings, 0 replies; 19+ messages in thread
From: Peter Korsgaard @ 2015-02-27 16:19 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes:

 > Change $CURL_CONFIG to $(CURL_CONFIG) in the patch
 > 0004-use-correct-curl-config.patch because in a makefile the braces are
 > required to expand a variable.

 > Fix error messages:
 > make[3]: Entering directory '/home/tetsuya/buildroot/br2/output/build/libxmlrpc-1.25.30/lib/curl_transport'
 > make[3]: URL_CONFIG: Command not found
 > /bin/sh: line 0: test: <: unary operator expected
 > make[3]: URL_CONFIG: Command not found

 > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 5/7] freetype: host-freetype-patch requires host-automake
  2015-02-27 14:28   ` Thomas Petazzoni
@ 2015-02-27 18:32     ` Fabio Porcedda
  0 siblings, 0 replies; 19+ messages in thread
From: Fabio Porcedda @ 2015-02-27 18:32 UTC (permalink / raw)
  To: buildroot

On Fri, Feb 27, 2015 at 3:28 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Fabio Porcedda,
>
> On Fri, 27 Feb 2015 10:19:22 +0100, Fabio Porcedda wrote:
>> The "make host-freetype-patch" fails because using the autogen.sh script
>> it doesn't found the autoconf tool, the problem was already fixed for
>> "make freetype-patch" adding the "host-automake" as a prerequisite to
>> freetype-patch, so fix it by adding "host-automake" as a prerequisite to
>> "host-freetype-patch" too.
>>
>> Fix build failure:
>> running `autoconf --force'
>> ./autogen.sh: line 15: autoconf: command not found
>> error while running `autoconf --force'
>> package/pkg-generic.mk:146: recipe for target 'buildroot/output/build/host-freetype-2.5.5/.stamp_patched' failed
>>
>> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>
> Maybe this has been discussed before, but why are we doing the autogen
> in a post patch hook rather than in a pre-configure hook ?

Inside the freetype.mk file there is a comment about that:

# POST_PATCH is because we still need to patch libtool after the regen.

The message and hook was added in this commit:

 commit a31a66802a7a1af76a629b0ba7120424ed547646
Author: Gustavo Zacarias <gustavo@zacarias.com.ar>
Date:   Tue Apr 22 14:12:40 2014 -0300

    freetype: security bump to version 2.5.3

    Fixes CVE-2014-2240.

I've tried to use a PRE_CONFIGURE hook but it fails:

>>> host-freetype 2.5.5 Patching
>>> host-freetype 2.5.5 Updating config.sub and config.guess
for file in config.guess config.sub; do for i in $(find
/home/fabiopo/buildroot/br/output/build/host-freetype-2.5.5 -name
$file); do cp support/gnuconfig/$file $i; done; done
>>> host-freetype 2.5.5 Patching libtool

Applying buildroot-libtool-v2.4.patch using patch:
patching file ltmain.sh
Hunk #1 FAILED at 1417.
Hunk #2 FAILED at 2963.
Hunk #3 FAILED at 5176.
Hunk #4 succeeded at 6537 (offset 1352 lines).
Hunk #5 succeeded at 6825 with fuzz 1 (offset 1358 lines).
Hunk #6 succeeded at 7112 (offset 1363 lines).
Hunk #7 succeeded at 8055 with fuzz 2 (offset 1363 lines).
Hunk #8 succeeded at 10647 (offset 1377 lines).
3 out of 8 hunks FAILED -- saving rejects to file ltmain.sh.rej
Patch failed!  Please fix buildroot-libtool-v2.4.patch!

BR
-- 
Fabio Porcedda

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 4/7] package/civetweb: fix build error on a host with make v4.0
  2015-02-27  9:19 ` [Buildroot] [PATCH 4/7] package/civetweb: fix build error on a host with make v4.0 Fabio Porcedda
@ 2015-02-28  9:05   ` Peter Korsgaard
  2015-02-28  9:47     ` Fabio Porcedda
  0 siblings, 1 reply; 19+ messages in thread
From: Peter Korsgaard @ 2015-02-28  9:05 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes:

 > Add a patch to fix a typo that on a system with make v4.0 and
 > BR2_CIVETWEB_WITH_LUA=y fails to build:
 >   Makefile:203: *** mixed implicit and normal rules.  Stop.

 > The patch was not sent upstream because this problem is already fixed on
 > master.

 > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Committed, thanks.

Strangely enough, make on my system (Debian 4.0-8.1) only warns about
the syntax:

Makefile:203: *** mixed implicit and normal rules: deprecated syntax

With the patch applied I get another warning, but that can probably be
ignored:

Makefile:203: target 'out/src/third_party' given more than once in the same rule

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 5/7] freetype: host-freetype-patch requires host-automake
  2015-02-27  9:19 ` [Buildroot] [PATCH 5/7] freetype: host-freetype-patch requires host-automake Fabio Porcedda
  2015-02-27 14:28   ` Thomas Petazzoni
@ 2015-02-28  9:11   ` Peter Korsgaard
  1 sibling, 0 replies; 19+ messages in thread
From: Peter Korsgaard @ 2015-02-28  9:11 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes:

 > The "make host-freetype-patch" fails because using the autogen.sh script
 > it doesn't found the autoconf tool, the problem was already fixed for
 > "make freetype-patch" adding the "host-automake" as a prerequisite to
 > freetype-patch, so fix it by adding "host-automake" as a prerequisite to
 > "host-freetype-patch" too.

Committed with the commit message slightly reworded, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 3/7] x11r7/xcb-util-keysyms: depends on host-pkgconf and libxcb
  2015-02-27  9:19 ` [Buildroot] [PATCH 3/7] x11r7/xcb-util-keysyms: depends on host-pkgconf and libxcb Fabio Porcedda
@ 2015-02-28  9:44   ` Peter Korsgaard
  0 siblings, 0 replies; 19+ messages in thread
From: Peter Korsgaard @ 2015-02-28  9:44 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes:

 > Fix build failure:
 > ./configure: line 11453: /home/tetsuya/buildroot/br/output/host/usr/bin/pkg-config: No such file or directory
 > configure: error: in `/home/tetsuya/buildroot/br/output/build/xcb-util-keysyms-0.3.9':
 > configure: error: The pkg-config script could not be found or is too old.  Make sure it
 > is in your PATH or set the PKG_CONFIG environment variable to the full
 > path to pkg-config.

 > Fix build failure:
 > configure: error: Package requirements (xcb >= 1.4) were not met:

 > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 4/7] package/civetweb: fix build error on a host with make v4.0
  2015-02-28  9:05   ` Peter Korsgaard
@ 2015-02-28  9:47     ` Fabio Porcedda
  2015-02-28 10:37       ` Peter Korsgaard
  0 siblings, 1 reply; 19+ messages in thread
From: Fabio Porcedda @ 2015-02-28  9:47 UTC (permalink / raw)
  To: buildroot

On Sat, Feb 28, 2015 at 10:05 AM, Peter Korsgaard <peter@korsgaard.com> wrote:
>>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes:
>
>  > Add a patch to fix a typo that on a system with make v4.0 and
>  > BR2_CIVETWEB_WITH_LUA=y fails to build:
>  >   Makefile:203: *** mixed implicit and normal rules.  Stop.
>
>  > The patch was not sent upstream because this problem is already fixed on
>  > master.
>
>  > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
>
> Committed, thanks.
>
> Strangely enough, make on my system (Debian 4.0-8.1) only warns about
> the syntax:
>
> Makefile:203: *** mixed implicit and normal rules: deprecated syntax

That is because in the debian package the have backported a change to
turn it in a worning:
http://metadata.ftp-master.debian.org/changelogs//main/m/make-dfsg/make-dfsg_4.0-8.1_changelog
make-dfsg (4.0-2) experimental; urgency=medium

  * Pull back some patches from upstream git that fix bugs. One of these
    converts the mixed implicit and explicit rule error into a warning,
    and that should give us a grace period to fix the Makefiles,

The make on fedora 21 does not have such a patch so it fails like the
officiale make 4.0 release.

> With the patch applied I get another warning, but that can probably be
> ignored:
>
> Makefile:203: target 'out/src/third_party' given more than once in the same rule
> --
> Bye, Peter Korsgaard

BR
-- 
Fabio Porcedda

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 4/7] package/civetweb: fix build error on a host with make v4.0
  2015-02-28  9:47     ` Fabio Porcedda
@ 2015-02-28 10:37       ` Peter Korsgaard
  0 siblings, 0 replies; 19+ messages in thread
From: Peter Korsgaard @ 2015-02-28 10:37 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes:

Hi,

>> Committed, thanks.
 >> 
 >> Strangely enough, make on my system (Debian 4.0-8.1) only warns about
 >> the syntax:
 >> 
 >> Makefile:203: *** mixed implicit and normal rules: deprecated syntax

 > That is because in the debian package the have backported a change to
 > turn it in a worning:
 > http://metadata.ftp-master.debian.org/changelogs//main/m/make-dfsg/make-dfsg_4.0-8.1_changelog
 > make-dfsg (4.0-2) experimental; urgency=medium

 >   * Pull back some patches from upstream git that fix bugs. One of these
 >     converts the mixed implicit and explicit rule error into a warning,
 >     and that should give us a grace period to fix the Makefiles,

 > The make on fedora 21 does not have such a patch so it fails like the
 > officiale make 4.0 release.

Ok, thanks!

-- 
Bye, Peter Korsgaard 

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 1/7] shared-mime-info: host variant requires libxml2 and libglib2
  2015-02-27  9:19 ` [Buildroot] [PATCH 1/7] shared-mime-info: host variant requires libxml2 and libglib2 Fabio Porcedda
@ 2015-03-01 21:02   ` Peter Korsgaard
  0 siblings, 0 replies; 19+ messages in thread
From: Peter Korsgaard @ 2015-03-01 21:02 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes:

 > Add to HOST_SHARED_MIME_INFO_DEPENDENCIES the missing dependencies
 > host-libxml2 and host-libglib2.

 > Also remove from SHARED_MIME_INFO_DEPENDENCIES dependencies already
 > present in HOST_SHARED_MIME_INFO_DEPENDENCIES.

 > Fix build failure:
 > configure: error: Package requirements ( libxml-2.0 >= 2.4 glib-2.0 >= 2.6.0) were not met

 > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 6/7] package/efl/libevas: add optional dependency libfribidi
  2015-02-27  9:19 ` [Buildroot] [PATCH 6/7] package/efl/libevas: add optional dependency libfribidi Fabio Porcedda
@ 2015-03-01 21:02   ` Peter Korsgaard
  0 siblings, 0 replies; 19+ messages in thread
From: Peter Korsgaard @ 2015-03-01 21:02 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes:

 > Fix the following message when libfribidi is enabled but not already
 > built:
 > Package fribidi was not found in the pkg-config search path.
 > Perhaps you should add the directory containing `fribidi.pc'
 > No package 'fribidi' found

 > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [Buildroot] [PATCH 7/7] package/libfribidi: add optional dependency libglib2
  2015-02-27  9:19 ` [Buildroot] [PATCH 7/7] package/libfribidi: add optional dependency libglib2 Fabio Porcedda
@ 2015-03-01 21:03   ` Peter Korsgaard
  0 siblings, 0 replies; 19+ messages in thread
From: Peter Korsgaard @ 2015-03-01 21:03 UTC (permalink / raw)
  To: buildroot

>>>>> "Fabio" == Fabio Porcedda <fabio.porcedda@gmail.com> writes:

 > Fix the following message when libglib2 is enabled but not already
 > built:
 > Package glib-2.0 was not found in the pkg-config search path.
 > Perhaps you should add the directory containing `glib-2.0.pc'
 > No package 'glib-2.0' found

 > Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2015-03-01 21:03 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-27  9:19 [Buildroot] [PATCH 0/7] Various fixes Fabio Porcedda
2015-02-27  9:19 ` [Buildroot] [PATCH 1/7] shared-mime-info: host variant requires libxml2 and libglib2 Fabio Porcedda
2015-03-01 21:02   ` Peter Korsgaard
2015-02-27  9:19 ` [Buildroot] [PATCH 2/7] libxmlrpc: add missing braces for variable CURL_CONFIG in patch 4 Fabio Porcedda
2015-02-27 16:19   ` Peter Korsgaard
2015-02-27  9:19 ` [Buildroot] [PATCH 3/7] x11r7/xcb-util-keysyms: depends on host-pkgconf and libxcb Fabio Porcedda
2015-02-28  9:44   ` Peter Korsgaard
2015-02-27  9:19 ` [Buildroot] [PATCH 4/7] package/civetweb: fix build error on a host with make v4.0 Fabio Porcedda
2015-02-28  9:05   ` Peter Korsgaard
2015-02-28  9:47     ` Fabio Porcedda
2015-02-28 10:37       ` Peter Korsgaard
2015-02-27  9:19 ` [Buildroot] [PATCH 5/7] freetype: host-freetype-patch requires host-automake Fabio Porcedda
2015-02-27 14:28   ` Thomas Petazzoni
2015-02-27 18:32     ` Fabio Porcedda
2015-02-28  9:11   ` Peter Korsgaard
2015-02-27  9:19 ` [Buildroot] [PATCH 6/7] package/efl/libevas: add optional dependency libfribidi Fabio Porcedda
2015-03-01 21:02   ` Peter Korsgaard
2015-02-27  9:19 ` [Buildroot] [PATCH 7/7] package/libfribidi: add optional dependency libglib2 Fabio Porcedda
2015-03-01 21:03   ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.