All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tracing: Fix documentation on tp_printk cmdline option
@ 2024-03-23 23:17 Vitaly Chikunov
  2024-03-24  0:29 ` Randy Dunlap
  2024-03-29 14:55 ` Jonathan Corbet
  0 siblings, 2 replies; 3+ messages in thread
From: Vitaly Chikunov @ 2024-03-23 23:17 UTC (permalink / raw)
  To: Thomas Gleixner, Steven Rostedt (Red Hat), linux-doc, linux-kernel
  Cc: Vitaly Chikunov, Jonathan Corbet

kernel-parameters.txt incorrectly states that workings of
kernel.tracepoint_printk sysctl depends on "tracepoint_printk kernel
cmdline option", this is a bit misleading for new users since the actual
cmdline option name is tp_printk.

Fixes: 0daa2302968c ("tracing: Add tp_printk cmdline to have tracepoints go to printk()")
Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
---
 Documentation/admin-guide/kernel-parameters.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
index bb884c14b2f6..623fce7d5fcd 100644
--- a/Documentation/admin-guide/kernel-parameters.txt
+++ b/Documentation/admin-guide/kernel-parameters.txt
@@ -6599,7 +6599,7 @@
 			To turn off having tracepoints sent to printk,
 			 echo 0 > /proc/sys/kernel/tracepoint_printk
 			Note, echoing 1 into this file without the
-			tracepoint_printk kernel cmdline option has no effect.
+			tp_printk kernel cmdline option has no effect.
 
 			The tp_printk_stop_on_boot (see below) can also be used
 			to stop the printing of events to console at
-- 
2.42.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] tracing: Fix documentation on tp_printk cmdline option
  2024-03-23 23:17 [PATCH] tracing: Fix documentation on tp_printk cmdline option Vitaly Chikunov
@ 2024-03-24  0:29 ` Randy Dunlap
  2024-03-29 14:55 ` Jonathan Corbet
  1 sibling, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2024-03-24  0:29 UTC (permalink / raw)
  To: Vitaly Chikunov, Thomas Gleixner, Steven Rostedt (Red Hat),
	linux-doc, linux-kernel
  Cc: Jonathan Corbet



On 3/23/24 16:17, Vitaly Chikunov wrote:
> kernel-parameters.txt incorrectly states that workings of
> kernel.tracepoint_printk sysctl depends on "tracepoint_printk kernel
> cmdline option", this is a bit misleading for new users since the actual
> cmdline option name is tp_printk.
> 
> Fixes: 0daa2302968c ("tracing: Add tp_printk cmdline to have tracepoints go to printk()")
> Signed-off-by: Vitaly Chikunov <vt@altlinux.org>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  Documentation/admin-guide/kernel-parameters.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index bb884c14b2f6..623fce7d5fcd 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -6599,7 +6599,7 @@
>  			To turn off having tracepoints sent to printk,
>  			 echo 0 > /proc/sys/kernel/tracepoint_printk
>  			Note, echoing 1 into this file without the
> -			tracepoint_printk kernel cmdline option has no effect.
> +			tp_printk kernel cmdline option has no effect.
>  
>  			The tp_printk_stop_on_boot (see below) can also be used
>  			to stop the printing of events to console at

-- 
#Randy

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tracing: Fix documentation on tp_printk cmdline option
  2024-03-23 23:17 [PATCH] tracing: Fix documentation on tp_printk cmdline option Vitaly Chikunov
  2024-03-24  0:29 ` Randy Dunlap
@ 2024-03-29 14:55 ` Jonathan Corbet
  1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2024-03-29 14:55 UTC (permalink / raw)
  To: Vitaly Chikunov, Thomas Gleixner, Steven Rostedt (Red Hat),
	linux-doc, linux-kernel
  Cc: Vitaly Chikunov

Vitaly Chikunov <vt@altlinux.org> writes:

> kernel-parameters.txt incorrectly states that workings of
> kernel.tracepoint_printk sysctl depends on "tracepoint_printk kernel
> cmdline option", this is a bit misleading for new users since the actual
> cmdline option name is tp_printk.
>
> Fixes: 0daa2302968c ("tracing: Add tp_printk cmdline to have tracepoints go to printk()")
> Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
> ---
>  Documentation/admin-guide/kernel-parameters.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

jon

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-03-29 14:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-23 23:17 [PATCH] tracing: Fix documentation on tp_printk cmdline option Vitaly Chikunov
2024-03-24  0:29 ` Randy Dunlap
2024-03-29 14:55 ` Jonathan Corbet

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.