* [PATCH] sound: hda: increase timeouts to stop crash on resume with ALC3204 and others
@ 2023-01-04 22:10 Ben Carter
2023-01-05 8:55 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Ben Carter @ 2023-01-04 22:10 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, Cezary Rojewski,
Amadeusz Sławiński, Mark Brown, Divya Prakash,
Ben Carter
Cc: alsa-devel, linux-kernel
Upon waking after system suspend, ALSA often crashed with:
snd_hda_intel 0000:00:1f.3: CORB reset timeout#2, CORBRP = 65535
snd_hda_codec_hdmi hdaudioC1D2: Unable to sync register 0x2f8100. -5
snd_hda_codec_realtek hdaudioC1D0: Unable to sync register 0x2b8000. -5
A temporary fix was established by reloading snd_hda_intel, but increasing
the rather strict timeout of 1ms to 100ms has remedied the issue on my
device. Although this is a much larger delay, most hardware took less than
1ms anyway and it's preferable to the whole audio system crashing.
Signed-off-by: Ben Carter <craterrender@gmail.com>
---
sound/hda/hdac_controller.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c
index 3c7af6558249..1ab573248452 100644
--- a/sound/hda/hdac_controller.c
+++ b/sound/hda/hdac_controller.c
@@ -16,7 +16,7 @@ static void azx_clear_corbrp(struct hdac_bus *bus)
{
int timeout;
- for (timeout = 1000; timeout > 0; timeout--) {
+ for (timeout = 100000; timeout > 0; timeout--) {
if (snd_hdac_chip_readw(bus, CORBRP) & AZX_CORBRP_RST)
break;
udelay(1);
@@ -26,7 +26,7 @@ static void azx_clear_corbrp(struct hdac_bus *bus)
snd_hdac_chip_readw(bus, CORBRP));
snd_hdac_chip_writew(bus, CORBRP, 0);
- for (timeout = 1000; timeout > 0; timeout--) {
+ for (timeout = 100000; timeout > 0; timeout--) {
if (snd_hdac_chip_readw(bus, CORBRP) == 0)
break;
udelay(1);
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sound: hda: increase timeouts to stop crash on resume with ALC3204 and others
2023-01-04 22:10 [PATCH] sound: hda: increase timeouts to stop crash on resume with ALC3204 and others Ben Carter
@ 2023-01-05 8:55 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2023-01-05 8:55 UTC (permalink / raw)
To: Ben Carter
Cc: Jaroslav Kysela, Takashi Iwai, Cezary Rojewski,
Amadeusz Sławiński, Mark Brown, Divya Prakash,
alsa-devel, linux-kernel
On Wed, 04 Jan 2023 23:10:24 +0100,
Ben Carter wrote:
>
> Upon waking after system suspend, ALSA often crashed with:
> snd_hda_intel 0000:00:1f.3: CORB reset timeout#2, CORBRP = 65535
> snd_hda_codec_hdmi hdaudioC1D2: Unable to sync register 0x2f8100. -5
> snd_hda_codec_realtek hdaudioC1D0: Unable to sync register 0x2b8000. -5
> A temporary fix was established by reloading snd_hda_intel, but increasing
> the rather strict timeout of 1ms to 100ms has remedied the issue on my
> device. Although this is a much larger delay, most hardware took less than
> 1ms anyway and it's preferable to the whole audio system crashing.
100ms is way too long for an atomic context. How long it took in
reality?
If we extend to 100ms, the loop should be outside the spinlock.
Maybe it's worth to rewrite with the standard iopoll helper, too.
thanks,
Takashi
>
> Signed-off-by: Ben Carter <craterrender@gmail.com>
> ---
> sound/hda/hdac_controller.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c
> index 3c7af6558249..1ab573248452 100644
> --- a/sound/hda/hdac_controller.c
> +++ b/sound/hda/hdac_controller.c
> @@ -16,7 +16,7 @@ static void azx_clear_corbrp(struct hdac_bus *bus)
> {
> int timeout;
>
> - for (timeout = 1000; timeout > 0; timeout--) {
> + for (timeout = 100000; timeout > 0; timeout--) {
> if (snd_hdac_chip_readw(bus, CORBRP) & AZX_CORBRP_RST)
> break;
> udelay(1);
> @@ -26,7 +26,7 @@ static void azx_clear_corbrp(struct hdac_bus *bus)
> snd_hdac_chip_readw(bus, CORBRP));
>
> snd_hdac_chip_writew(bus, CORBRP, 0);
> - for (timeout = 1000; timeout > 0; timeout--) {
> + for (timeout = 100000; timeout > 0; timeout--) {
> if (snd_hdac_chip_readw(bus, CORBRP) == 0)
> break;
> udelay(1);
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sound: hda: increase timeouts to stop crash on resume with ALC3204 and others
@ 2023-01-05 8:55 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2023-01-05 8:55 UTC (permalink / raw)
To: Ben Carter
Cc: Cezary Rojewski, alsa-devel, Divya Prakash, Takashi Iwai,
Mark Brown, Amadeusz Sławiński, linux-kernel
On Wed, 04 Jan 2023 23:10:24 +0100,
Ben Carter wrote:
>
> Upon waking after system suspend, ALSA often crashed with:
> snd_hda_intel 0000:00:1f.3: CORB reset timeout#2, CORBRP = 65535
> snd_hda_codec_hdmi hdaudioC1D2: Unable to sync register 0x2f8100. -5
> snd_hda_codec_realtek hdaudioC1D0: Unable to sync register 0x2b8000. -5
> A temporary fix was established by reloading snd_hda_intel, but increasing
> the rather strict timeout of 1ms to 100ms has remedied the issue on my
> device. Although this is a much larger delay, most hardware took less than
> 1ms anyway and it's preferable to the whole audio system crashing.
100ms is way too long for an atomic context. How long it took in
reality?
If we extend to 100ms, the loop should be outside the spinlock.
Maybe it's worth to rewrite with the standard iopoll helper, too.
thanks,
Takashi
>
> Signed-off-by: Ben Carter <craterrender@gmail.com>
> ---
> sound/hda/hdac_controller.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/hda/hdac_controller.c b/sound/hda/hdac_controller.c
> index 3c7af6558249..1ab573248452 100644
> --- a/sound/hda/hdac_controller.c
> +++ b/sound/hda/hdac_controller.c
> @@ -16,7 +16,7 @@ static void azx_clear_corbrp(struct hdac_bus *bus)
> {
> int timeout;
>
> - for (timeout = 1000; timeout > 0; timeout--) {
> + for (timeout = 100000; timeout > 0; timeout--) {
> if (snd_hdac_chip_readw(bus, CORBRP) & AZX_CORBRP_RST)
> break;
> udelay(1);
> @@ -26,7 +26,7 @@ static void azx_clear_corbrp(struct hdac_bus *bus)
> snd_hdac_chip_readw(bus, CORBRP));
>
> snd_hdac_chip_writew(bus, CORBRP, 0);
> - for (timeout = 1000; timeout > 0; timeout--) {
> + for (timeout = 100000; timeout > 0; timeout--) {
> if (snd_hdac_chip_readw(bus, CORBRP) == 0)
> break;
> udelay(1);
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-05 8:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-04 22:10 [PATCH] sound: hda: increase timeouts to stop crash on resume with ALC3204 and others Ben Carter
2023-01-05 8:55 ` Takashi Iwai
2023-01-05 8:55 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.