All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/liburing: needs MMU
@ 2022-04-05 20:40 Fabrice Fontaine
  2022-04-10 21:11 ` Peter Korsgaard
  2022-04-11  9:44 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2022-04-05 20:40 UTC (permalink / raw)
  To: buildroot; +Cc: Fabrice Fontaine

liburing needs MMU since its addition in commit
03ca6f4e39874583060317e7e15e9e360220877e:

setup.c: In function 'io_uring_ring_dontfork':
setup.c:119:8: warning: implicit declaration of function 'madvise'; did you mean 'raise'? [-Wimplicit-function-declaration]
  119 |  ret = madvise(ring->sq.sqes, len, MADV_DONTFORK);
      |        ^~~~~~~
      |        raise

Fixes:
 - http://autobuild.buildroot.org/results/33f3c58e98daab07139b4f400b85f87c0e314240

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/liburing/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/liburing/Config.in b/package/liburing/Config.in
index d65a3f1322..fc13f1c17c 100644
--- a/package/liburing/Config.in
+++ b/package/liburing/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBURING
 	bool "liburing"
+	depends on BR2_USE_MMU # madvise()
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 # C11/stdatomic.h
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
 	help
@@ -11,5 +12,6 @@ config BR2_PACKAGE_LIBURING
 	  https://git.kernel.dk/cgit/liburing
 
 comment "liburing needs a toolchain w/ gcc >= 4.9, headers >= 5.1"
+	depends on BR2_USE_MMU
 	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 || \
 		!BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/liburing: needs MMU
  2022-04-05 20:40 [Buildroot] [PATCH 1/1] package/liburing: needs MMU Fabrice Fontaine
@ 2022-04-10 21:11 ` Peter Korsgaard
  2022-04-11  9:44 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-04-10 21:11 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > liburing needs MMU since its addition in commit
 > 03ca6f4e39874583060317e7e15e9e360220877e:

 > setup.c: In function 'io_uring_ring_dontfork':
 > setup.c:119:8: warning: implicit declaration of function 'madvise'; did you mean 'raise'? [-Wimplicit-function-declaration]
 >   119 |  ret = madvise(ring->sq.sqes, len, MADV_DONTFORK);
 >       |        ^~~~~~~
 >       |        raise

 > Fixes:
 >  - http://autobuild.buildroot.org/results/33f3c58e98daab07139b4f400b85f87c0e314240

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH 1/1] package/liburing: needs MMU
  2022-04-05 20:40 [Buildroot] [PATCH 1/1] package/liburing: needs MMU Fabrice Fontaine
  2022-04-10 21:11 ` Peter Korsgaard
@ 2022-04-11  9:44 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2022-04-11  9:44 UTC (permalink / raw)
  To: Fabrice Fontaine; +Cc: buildroot

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > liburing needs MMU since its addition in commit
 > 03ca6f4e39874583060317e7e15e9e360220877e:

 > setup.c: In function 'io_uring_ring_dontfork':
 > setup.c:119:8: warning: implicit declaration of function 'madvise';
 > did you mean 'raise'? [-Wimplicit-function-declaration]
 >   119 |  ret = madvise(ring->sq.sqes, len, MADV_DONTFORK);
 >       |        ^~~~~~~
 >       |        raise

 > Fixes:
 >  - http://autobuild.buildroot.org/results/33f3c58e98daab07139b4f400b85f87c0e314240

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-04-11  9:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-05 20:40 [Buildroot] [PATCH 1/1] package/liburing: needs MMU Fabrice Fontaine
2022-04-10 21:11 ` Peter Korsgaard
2022-04-11  9:44 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.