All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] target/rx: Remove unused ENV_OFFSET definition
@ 2022-01-22  0:23 Philippe Mathieu-Daudé via
  2022-01-24  8:24 ` Richard Henderson
  2022-01-24 10:14 ` Yoshinori Sato
  0 siblings, 2 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé via @ 2022-01-22  0:23 UTC (permalink / raw)
  To: qemu-devel; +Cc: Yoshinori Sato, qemu-trivial, Philippe Mathieu-Daudé

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/rx/cpu.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/target/rx/cpu.h b/target/rx/cpu.h
index 657db84ef0..58adf9edf6 100644
--- a/target/rx/cpu.h
+++ b/target/rx/cpu.h
@@ -116,8 +116,6 @@ struct RXCPU {
 
 typedef RXCPU ArchCPU;
 
-#define ENV_OFFSET offsetof(RXCPU, env)
-
 #define RX_CPU_TYPE_SUFFIX "-" TYPE_RX_CPU
 #define RX_CPU_TYPE_NAME(model) model RX_CPU_TYPE_SUFFIX
 #define CPU_RESOLVING_TYPE TYPE_RX_CPU
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] target/rx: Remove unused ENV_OFFSET definition
  2022-01-22  0:23 [PATCH] target/rx: Remove unused ENV_OFFSET definition Philippe Mathieu-Daudé via
@ 2022-01-24  8:24 ` Richard Henderson
  2022-01-24 10:14 ` Yoshinori Sato
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Henderson @ 2022-01-24  8:24 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel; +Cc: qemu-trivial, Yoshinori Sato

On 1/22/22 11:23 AM, Philippe Mathieu-Daudé via wrote:
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>   target/rx/cpu.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/target/rx/cpu.h b/target/rx/cpu.h
> index 657db84ef0..58adf9edf6 100644
> --- a/target/rx/cpu.h
> +++ b/target/rx/cpu.h
> @@ -116,8 +116,6 @@ struct RXCPU {
>   
>   typedef RXCPU ArchCPU;
>   
> -#define ENV_OFFSET offsetof(RXCPU, env)
> -
>   #define RX_CPU_TYPE_SUFFIX "-" TYPE_RX_CPU
>   #define RX_CPU_TYPE_NAME(model) model RX_CPU_TYPE_SUFFIX
>   #define CPU_RESOLVING_TYPE TYPE_RX_CPU
> 

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

For the viewers at home, the last use of ENV_OFFSET was removed in 
5e1401969b25f676fee6b1c564441759cf967a43; the commit of target/rx came in just afterward.


r~


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] target/rx: Remove unused ENV_OFFSET definition
  2022-01-22  0:23 [PATCH] target/rx: Remove unused ENV_OFFSET definition Philippe Mathieu-Daudé via
  2022-01-24  8:24 ` Richard Henderson
@ 2022-01-24 10:14 ` Yoshinori Sato
  1 sibling, 0 replies; 3+ messages in thread
From: Yoshinori Sato @ 2022-01-24 10:14 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé; +Cc: qemu-trivial, qemu-devel

On Sat, 22 Jan 2022 09:23:04 +0900,
Philippe Mathieu-Daudé via wrote:
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  target/rx/cpu.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/target/rx/cpu.h b/target/rx/cpu.h
> index 657db84ef0..58adf9edf6 100644
> --- a/target/rx/cpu.h
> +++ b/target/rx/cpu.h
> @@ -116,8 +116,6 @@ struct RXCPU {
>  
>  typedef RXCPU ArchCPU;
>  
> -#define ENV_OFFSET offsetof(RXCPU, env)
> -
>  #define RX_CPU_TYPE_SUFFIX "-" TYPE_RX_CPU
>  #define RX_CPU_TYPE_NAME(model) model RX_CPU_TYPE_SUFFIX
>  #define CPU_RESOLVING_TYPE TYPE_RX_CPU
> -- 
> 2.34.1
> 
> 

Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>

-- 
Yosinori Sato


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-01-24 10:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-22  0:23 [PATCH] target/rx: Remove unused ENV_OFFSET definition Philippe Mathieu-Daudé via
2022-01-24  8:24 ` Richard Henderson
2022-01-24 10:14 ` Yoshinori Sato

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.