* [Buildroot] [PATCH v2,1/1] package/ipmiutil: touch config.h.in
@ 2021-08-27 16:23 Fabrice Fontaine
2021-08-27 19:59 ` Yann E. MORIN
2021-09-07 12:30 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2021-08-27 16:23 UTC (permalink / raw)
To: buildroot; +Cc: David Bachelart, Fabrice Fontaine
Build fails since bump to version 3.1.7 in commit
011f31ee244b7fe4621b3f69ca3d7e7b1cfdb5bb because config.h.in is older
than aclocal.m4:
make[1]: Entering directory '/tmp/instance-4/output-1/build/ipmiutil-3.1.7'
(CDPATH="${ZSH_VERSION+.}:" && cd . && autoheader)
/bin/bash: autoheader: command not found
Fixes:
- http://autobuild.buildroot.org/results/2005af881726473f2cda176e90c1e41e4baea67c
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2 (after review of Arnout Vandecappelle):
- touch config.h.in instead of autoreconf
package/ipmiutil/ipmiutil.mk | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/package/ipmiutil/ipmiutil.mk b/package/ipmiutil/ipmiutil.mk
index d85b9643f0..a8d9bb8763 100644
--- a/package/ipmiutil/ipmiutil.mk
+++ b/package/ipmiutil/ipmiutil.mk
@@ -11,6 +11,12 @@ IPMIUTIL_LICENSE_FILES = COPYING
IPMIUTIL_MAKE = $(MAKE1)
+# aclocal.m4 is newer than config.h.in. touch it to avoid autoreconf
+define IPMIUTIL_TOUCH_CONFIG_H_IN
+ touch $(@D)/config.h.in
+endef
+IPMIUTIL_PRE_CONFIGURE_HOOKS += IPMIUTIL_TOUCH_CONFIG_H_IN
+
# forgets to link against libcrypto dependencies breaking static link
ifeq ($(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yx)
# tests against distro libcrypto so it might get a false positive when
--
2.32.0
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v2,1/1] package/ipmiutil: touch config.h.in
2021-08-27 16:23 [Buildroot] [PATCH v2,1/1] package/ipmiutil: touch config.h.in Fabrice Fontaine
@ 2021-08-27 19:59 ` Yann E. MORIN
2021-09-07 12:30 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-08-27 19:59 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: David Bachelart, buildroot
Fabrice, All,
On 2021-08-27 18:23 +0200, Fabrice Fontaine spake thusly:
> Build fails since bump to version 3.1.7 in commit
> 011f31ee244b7fe4621b3f69ca3d7e7b1cfdb5bb because config.h.in is older
> than aclocal.m4:
>
> make[1]: Entering directory '/tmp/instance-4/output-1/build/ipmiutil-3.1.7'
> (CDPATH="${ZSH_VERSION+.}:" && cd . && autoheader)
> /bin/bash: autoheader: command not found
>
> Fixes:
> - http://autobuild.buildroot.org/results/2005af881726473f2cda176e90c1e41e4baea67c
>
- the title should explain what is fixed, not how it is fixed, so I've
changed that to: package/ipmiutil: avoid the need for autoreconf
- the comment in the code was a bit misleading: "it" as a subject
refers to the subject of the previous sentence, so it was a bit
confusing that config.h.in was touched, not aclocal.m4; to remove
the confusion, I've changed that to: "Touch the latter to avoid
autoreconf".
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> Changes v1 -> v2 (after review of Arnout Vandecappelle):
> - touch config.h.in instead of autoreconf
>
> package/ipmiutil/ipmiutil.mk | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/package/ipmiutil/ipmiutil.mk b/package/ipmiutil/ipmiutil.mk
> index d85b9643f0..a8d9bb8763 100644
> --- a/package/ipmiutil/ipmiutil.mk
> +++ b/package/ipmiutil/ipmiutil.mk
> @@ -11,6 +11,12 @@ IPMIUTIL_LICENSE_FILES = COPYING
>
> IPMIUTIL_MAKE = $(MAKE1)
>
> +# aclocal.m4 is newer than config.h.in. touch it to avoid autoreconf
> +define IPMIUTIL_TOUCH_CONFIG_H_IN
> + touch $(@D)/config.h.in
> +endef
> +IPMIUTIL_PRE_CONFIGURE_HOOKS += IPMIUTIL_TOUCH_CONFIG_H_IN
> +
> # forgets to link against libcrypto dependencies breaking static link
> ifeq ($(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yx)
> # tests against distro libcrypto so it might get a false positive when
> --
> 2.32.0
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH v2,1/1] package/ipmiutil: touch config.h.in
2021-08-27 16:23 [Buildroot] [PATCH v2,1/1] package/ipmiutil: touch config.h.in Fabrice Fontaine
2021-08-27 19:59 ` Yann E. MORIN
@ 2021-09-07 12:30 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-09-07 12:30 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: David Bachelart, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Build fails since bump to version 3.1.7 in commit
> 011f31ee244b7fe4621b3f69ca3d7e7b1cfdb5bb because config.h.in is older
> than aclocal.m4:
> make[1]: Entering directory '/tmp/instance-4/output-1/build/ipmiutil-3.1.7'
> (CDPATH="${ZSH_VERSION+.}:" && cd . && autoheader)
> /bin/bash: autoheader: command not found
> Fixes:
> - http://autobuild.buildroot.org/results/2005af881726473f2cda176e90c1e41e4baea67c
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Arnout Vandecappelle):
> - touch config.h.in instead of autoreconf
Committed to 2021.02.x and 2021.05.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@lists.buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-09-07 12:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-27 16:23 [Buildroot] [PATCH v2,1/1] package/ipmiutil: touch config.h.in Fabrice Fontaine
2021-08-27 19:59 ` Yann E. MORIN
2021-09-07 12:30 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.