* [Buildroot] [PATCH 1/3] package/dhcpcd: enhance syntax
@ 2020-12-26 17:17 Fabrice Fontaine
2020-12-26 17:17 ` [Buildroot] [PATCH 2/3] package/dhcpcd: create dhcpcd user Fabrice Fontaine
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Fabrice Fontaine @ 2020-12-26 17:17 UTC (permalink / raw)
To: buildroot
Add all configure options through DHCP_CONFIG_OPTS and avoid splitting
lines when they are less than 80 characters
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/dhcpcd/dhcpcd.mk | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/package/dhcpcd/dhcpcd.mk b/package/dhcpcd/dhcpcd.mk
index 0dcd36f369..11d78e1847 100644
--- a/package/dhcpcd/dhcpcd.mk
+++ b/package/dhcpcd/dhcpcd.mk
@@ -11,6 +11,10 @@ DHCPCD_DEPENDENCIES = host-pkgconf
DHCPCD_LICENSE = BSD-2-Clause
DHCPCD_LICENSE_FILES = LICENSE
+DHCPCD_CONFIG_OPTS = \
+ --libexecdir=/lib/dhcpcd \
+ --os=linux
+
ifeq ($(BR2_STATIC_LIBS),y)
DHCPCD_CONFIG_OPTS += --enable-static
endif
@@ -20,16 +24,11 @@ DHCPCD_CONFIG_OPTS += --disable-fork --disable-privsep
endif
define DHCPCD_CONFIGURE_CMDS
- (cd $(@D); \
- $(TARGET_CONFIGURE_OPTS) ./configure \
- --os=linux \
- --libexecdir=/lib/dhcpcd \
- $(DHCPCD_CONFIG_OPTS) )
+ (cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure $(DHCPCD_CONFIG_OPTS))
endef
define DHCPCD_BUILD_CMDS
- $(TARGET_MAKE_ENV) $(MAKE) \
- -C $(@D) all
+ $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) all
endef
define DHCPCD_INSTALL_TARGET_CMDS
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH 2/3] package/dhcpcd: create dhcpcd user
2020-12-26 17:17 [Buildroot] [PATCH 1/3] package/dhcpcd: enhance syntax Fabrice Fontaine
@ 2020-12-26 17:17 ` Fabrice Fontaine
2020-12-27 8:09 ` Peter Korsgaard
2020-12-26 17:17 ` [Buildroot] [PATCH 3/3] package/dhcpcd: add udev optional dependency Fabrice Fontaine
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Fabrice Fontaine @ 2020-12-26 17:17 UTC (permalink / raw)
To: buildroot
privsep is supported since version 9.0.0 and
https://github.com/rsmarples/dhcpcd/commit/d5786118da1bad4c247631cae86344f1b249a8cb
It is enabled by default since
https://github.com/rsmarples/dhcpcd/commit/3a4c2e5604d72151b06ed365aa71493740a3ad75
So use --privsepuser to avoid that the detection mechanism finds a wrong
value from host and create it on the target
Fixes:
- https://bugs.buildroot.org/show_bug.cgi?id=13416
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/dhcpcd/dhcpcd.mk | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/package/dhcpcd/dhcpcd.mk b/package/dhcpcd/dhcpcd.mk
index 11d78e1847..7b69602605 100644
--- a/package/dhcpcd/dhcpcd.mk
+++ b/package/dhcpcd/dhcpcd.mk
@@ -13,7 +13,8 @@ DHCPCD_LICENSE_FILES = LICENSE
DHCPCD_CONFIG_OPTS = \
--libexecdir=/lib/dhcpcd \
- --os=linux
+ --os=linux \
+ --privsepuser=dhcpcd
ifeq ($(BR2_STATIC_LIBS),y)
DHCPCD_CONFIG_OPTS += --enable-static
@@ -50,6 +51,10 @@ define DHCPCD_INSTALL_INIT_SYSTEMD
endef
endif
+define DHCPCD_USERS
+ dhcpcd -1 dhcpcd -1 * - - - dhcpcd user
+endef
+
# NOTE: Even though this package has a configure script, it is not generated
# using the autotools, so we have to use the generic package infrastructure.
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH 3/3] package/dhcpcd: add udev optional dependency
2020-12-26 17:17 [Buildroot] [PATCH 1/3] package/dhcpcd: enhance syntax Fabrice Fontaine
2020-12-26 17:17 ` [Buildroot] [PATCH 2/3] package/dhcpcd: create dhcpcd user Fabrice Fontaine
@ 2020-12-26 17:17 ` Fabrice Fontaine
2020-12-27 8:11 ` Peter Korsgaard
2020-12-26 17:28 ` [Buildroot] [PATCH 1/3] package/dhcpcd: enhance syntax Thomas Petazzoni
2020-12-27 8:09 ` Peter Korsgaard
3 siblings, 1 reply; 7+ messages in thread
From: Fabrice Fontaine @ 2020-12-26 17:17 UTC (permalink / raw)
To: buildroot
udev is an optional dependency (enabled by default) since version 6.1.0:
https://github.com/rsmarples/dhcpcd/commit/12bbc8cb5c7507be15a7e0af4140c3d81125c46c
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/dhcpcd/dhcpcd.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/dhcpcd/dhcpcd.mk b/package/dhcpcd/dhcpcd.mk
index 7b69602605..4900e0581f 100644
--- a/package/dhcpcd/dhcpcd.mk
+++ b/package/dhcpcd/dhcpcd.mk
@@ -16,6 +16,13 @@ DHCPCD_CONFIG_OPTS = \
--os=linux \
--privsepuser=dhcpcd
+ifeq ($(BR2_PACKAGE_HAS_UDEV),y)
+DHCPCD_CONFIG_OPTS += --with-udev
+DHCPCD_DEPENDENCIES += udev
+else
+DHCPCD_CONFIG_OPTS += --without-udev
+endif
+
ifeq ($(BR2_STATIC_LIBS),y)
DHCPCD_CONFIG_OPTS += --enable-static
endif
--
2.29.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/3] package/dhcpcd: enhance syntax
2020-12-26 17:17 [Buildroot] [PATCH 1/3] package/dhcpcd: enhance syntax Fabrice Fontaine
2020-12-26 17:17 ` [Buildroot] [PATCH 2/3] package/dhcpcd: create dhcpcd user Fabrice Fontaine
2020-12-26 17:17 ` [Buildroot] [PATCH 3/3] package/dhcpcd: add udev optional dependency Fabrice Fontaine
@ 2020-12-26 17:28 ` Thomas Petazzoni
2020-12-27 8:09 ` Peter Korsgaard
3 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2020-12-26 17:28 UTC (permalink / raw)
To: buildroot
On Sat, 26 Dec 2020 18:17:43 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Add all configure options through DHCP_CONFIG_OPTS and avoid splitting
> lines when they are less than 80 characters
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/dhcpcd/dhcpcd.mk | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
Series applied. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/3] package/dhcpcd: enhance syntax
2020-12-26 17:17 [Buildroot] [PATCH 1/3] package/dhcpcd: enhance syntax Fabrice Fontaine
` (2 preceding siblings ...)
2020-12-26 17:28 ` [Buildroot] [PATCH 1/3] package/dhcpcd: enhance syntax Thomas Petazzoni
@ 2020-12-27 8:09 ` Peter Korsgaard
3 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2020-12-27 8:09 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Add all configure options through DHCP_CONFIG_OPTS and avoid splitting
> lines when they are less than 80 characters
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2020.08.x and 2020.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-12-27 8:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-26 17:17 [Buildroot] [PATCH 1/3] package/dhcpcd: enhance syntax Fabrice Fontaine
2020-12-26 17:17 ` [Buildroot] [PATCH 2/3] package/dhcpcd: create dhcpcd user Fabrice Fontaine
2020-12-27 8:09 ` Peter Korsgaard
2020-12-26 17:17 ` [Buildroot] [PATCH 3/3] package/dhcpcd: add udev optional dependency Fabrice Fontaine
2020-12-27 8:11 ` Peter Korsgaard
2020-12-26 17:28 ` [Buildroot] [PATCH 1/3] package/dhcpcd: enhance syntax Thomas Petazzoni
2020-12-27 8:09 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.