From: Kurt Kanzenbach <kurt@linutronix.de>
To: Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] dt-bindings: net: dsa: b53: Add missing reg property to example
Date: Sat, 03 Oct 2020 11:21:52 +0200 [thread overview]
Message-ID: <877ds78y1b.fsf@kurt> (raw)
In-Reply-To: <8d1e1eed-6cc2-3a83-8f7e-71ec63ebe9fd@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]
On Fri Oct 02 2020, Florian Fainelli wrote:
> On 10/1/2020 11:20 PM, Kurt Kanzenbach wrote:
>> The switch has a certain MDIO address and this needs to be specified using the
>> reg property. Add it to the example.
>>
>> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
>> ---
>> Documentation/devicetree/bindings/net/dsa/b53.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt
>> index cfd1afdc6e94..80437b2fc935 100644
>> --- a/Documentation/devicetree/bindings/net/dsa/b53.txt
>> +++ b/Documentation/devicetree/bindings/net/dsa/b53.txt
>> @@ -106,6 +106,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0:
>>
>> switch0: ethernet-switch@30 {
>
> This should actually be 1e because the unit address is supposed to be in
> hexadecimal.
OK.
>
>> compatible = "brcm,bcm53125";
>> + reg = <30>;
>
> however this one is correct, if you want to resend with the unit address
> fixed that would be fine, if not:
Just noticed another problem in the example: The fixed link is specified
with "duplex-full" instead of "full-duplex" leading to half speed. So, I'll
send another patch and fix the above along with it.
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-10-03 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 6:20 [PATCH net-next] dt-bindings: net: dsa: b53: Add missing reg property to example Kurt Kanzenbach
2020-10-02 12:09 ` Andrew Lunn
2020-10-02 15:12 ` Florian Fainelli
2020-10-03 9:21 ` Kurt Kanzenbach [this message]
2020-10-02 22:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ds78y1b.fsf@kurt \
--to=kurt@linutronix.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.