* [PATCH net-next] dt-bindings: net: dsa: b53: Add missing reg property to example
@ 2020-10-02 6:20 Kurt Kanzenbach
2020-10-02 12:09 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Kurt Kanzenbach @ 2020-10-02 6:20 UTC (permalink / raw)
To: Florian Fainelli, Andrew Lunn, Vivien Didelot
Cc: David S. Miller, Jakub Kicinski, Rob Herring, netdev, Kurt Kanzenbach
The switch has a certain MDIO address and this needs to be specified using the
reg property. Add it to the example.
Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
---
Documentation/devicetree/bindings/net/dsa/b53.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt
index cfd1afdc6e94..80437b2fc935 100644
--- a/Documentation/devicetree/bindings/net/dsa/b53.txt
+++ b/Documentation/devicetree/bindings/net/dsa/b53.txt
@@ -106,6 +106,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0:
switch0: ethernet-switch@30 {
compatible = "brcm,bcm53125";
+ reg = <30>;
#address-cells = <1>;
#size-cells = <0>;
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH net-next] dt-bindings: net: dsa: b53: Add missing reg property to example
2020-10-02 6:20 [PATCH net-next] dt-bindings: net: dsa: b53: Add missing reg property to example Kurt Kanzenbach
@ 2020-10-02 12:09 ` Andrew Lunn
2020-10-02 15:12 ` Florian Fainelli
2020-10-02 22:18 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: Andrew Lunn @ 2020-10-02 12:09 UTC (permalink / raw)
To: Kurt Kanzenbach
Cc: Florian Fainelli, Vivien Didelot, David S. Miller,
Jakub Kicinski, Rob Herring, netdev
On Fri, Oct 02, 2020 at 08:20:51AM +0200, Kurt Kanzenbach wrote:
> The switch has a certain MDIO address and this needs to be specified using the
> reg property. Add it to the example.
>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] dt-bindings: net: dsa: b53: Add missing reg property to example
2020-10-02 6:20 [PATCH net-next] dt-bindings: net: dsa: b53: Add missing reg property to example Kurt Kanzenbach
2020-10-02 12:09 ` Andrew Lunn
@ 2020-10-02 15:12 ` Florian Fainelli
2020-10-03 9:21 ` Kurt Kanzenbach
2020-10-02 22:18 ` David Miller
2 siblings, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2020-10-02 15:12 UTC (permalink / raw)
To: Kurt Kanzenbach, Andrew Lunn, Vivien Didelot
Cc: David S. Miller, Jakub Kicinski, Rob Herring, netdev
On 10/1/2020 11:20 PM, Kurt Kanzenbach wrote:
> The switch has a certain MDIO address and this needs to be specified using the
> reg property. Add it to the example.
>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---
> Documentation/devicetree/bindings/net/dsa/b53.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt
> index cfd1afdc6e94..80437b2fc935 100644
> --- a/Documentation/devicetree/bindings/net/dsa/b53.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/b53.txt
> @@ -106,6 +106,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0:
>
> switch0: ethernet-switch@30 {
This should actually be 1e because the unit address is supposed to be in
hexadecimal.
> compatible = "brcm,bcm53125";
> + reg = <30>;
however this one is correct, if you want to resend with the unit address
fixed that would be fine, if not:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] dt-bindings: net: dsa: b53: Add missing reg property to example
2020-10-02 15:12 ` Florian Fainelli
@ 2020-10-03 9:21 ` Kurt Kanzenbach
0 siblings, 0 replies; 5+ messages in thread
From: Kurt Kanzenbach @ 2020-10-03 9:21 UTC (permalink / raw)
To: Florian Fainelli, Andrew Lunn, Vivien Didelot
Cc: David S. Miller, Jakub Kicinski, Rob Herring, netdev
[-- Attachment #1: Type: text/plain, Size: 1322 bytes --]
On Fri Oct 02 2020, Florian Fainelli wrote:
> On 10/1/2020 11:20 PM, Kurt Kanzenbach wrote:
>> The switch has a certain MDIO address and this needs to be specified using the
>> reg property. Add it to the example.
>>
>> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
>> ---
>> Documentation/devicetree/bindings/net/dsa/b53.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt
>> index cfd1afdc6e94..80437b2fc935 100644
>> --- a/Documentation/devicetree/bindings/net/dsa/b53.txt
>> +++ b/Documentation/devicetree/bindings/net/dsa/b53.txt
>> @@ -106,6 +106,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0:
>>
>> switch0: ethernet-switch@30 {
>
> This should actually be 1e because the unit address is supposed to be in
> hexadecimal.
OK.
>
>> compatible = "brcm,bcm53125";
>> + reg = <30>;
>
> however this one is correct, if you want to resend with the unit address
> fixed that would be fine, if not:
Just noticed another problem in the example: The fixed link is specified
with "duplex-full" instead of "full-duplex" leading to half speed. So, I'll
send another patch and fix the above along with it.
Thanks,
Kurt
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] dt-bindings: net: dsa: b53: Add missing reg property to example
2020-10-02 6:20 [PATCH net-next] dt-bindings: net: dsa: b53: Add missing reg property to example Kurt Kanzenbach
2020-10-02 12:09 ` Andrew Lunn
2020-10-02 15:12 ` Florian Fainelli
@ 2020-10-02 22:18 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2020-10-02 22:18 UTC (permalink / raw)
To: kurt; +Cc: f.fainelli, andrew, vivien.didelot, kuba, robh+dt, netdev
From: Kurt Kanzenbach <kurt@linutronix.de>
Date: Fri, 2 Oct 2020 08:20:51 +0200
> The switch has a certain MDIO address and this needs to be specified using the
> reg property. Add it to the example.
>
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Applied, thank you.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-10-03 9:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-02 6:20 [PATCH net-next] dt-bindings: net: dsa: b53: Add missing reg property to example Kurt Kanzenbach
2020-10-02 12:09 ` Andrew Lunn
2020-10-02 15:12 ` Florian Fainelli
2020-10-03 9:21 ` Kurt Kanzenbach
2020-10-02 22:18 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.