[Buildroot] [PATCH/next 1/1] package/log4cplus: add optional qt5 dependency

[Buildroot] [PATCH/next 1/1] package/log4cplus: add optional qt5 dependency

[Fabrice Fontaine]

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/log4cplus/log4cplus.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/log4cplus/log4cplus.mk b/package/log4cplus/log4cplus.mk
index 0bc4fc9aa6..b632066de1 100644
--- a/package/log4cplus/log4cplus.mk
+++ b/package/log4cplus/log4cplus.mk
@@ -11,6 +11,13 @@ LOG4CPLUS_LICENSE = Apache-2.0, BSD-2-Clause, BSD-like (threadpool)
 LOG4CPLUS_LICENSE_FILES = LICENSE
 LOG4CPLUS_INSTALL_STAGING = YES
 
+ifeq ($(BR2_PACKAGE_QT5),y)
+LOG4CPLUS_DEPENDENCIES += host-pkgconf qt5base
+LOG4CPLUS_CONF_OPTS += --with-qt5
+else
+LOG4CPLUS_CONF_OPTS += --without-qt5
+endif
+
 ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
 LOG4CPLUS_CONF_ENV += LIBS='-latomic'
 endif
-- 
2.14.1

[Buildroot] [PATCH/next 1/1] package/log4cplus: add optional qt5 dependency

[Thomas Petazzoni]

Hello Fabrice,

On Sun,  3 Mar 2019 11:12:52 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/log4cplus/log4cplus.mk | 7 +++++++
>  1 file changed, 7 insertions(+)

Thanks, I've applied, with one minor change, see below.

> diff --git a/package/log4cplus/log4cplus.mk b/package/log4cplus/log4cplus.mk
> index 0bc4fc9aa6..b632066de1 100644
> --- a/package/log4cplus/log4cplus.mk
> +++ b/package/log4cplus/log4cplus.mk
> @@ -11,6 +11,13 @@ LOG4CPLUS_LICENSE = Apache-2.0, BSD-2-Clause, BSD-like (threadpool)
>  LOG4CPLUS_LICENSE_FILES = LICENSE
>  LOG4CPLUS_INSTALL_STAGING = YES
>  
> +ifeq ($(BR2_PACKAGE_QT5),y)

I've changed to use BR2_PACKAGE_QT5BASE here. Obviously, it's
functionally exactly the same, because BR2_PACKAGE_QT5 selects
BR2_PACKAGE_QT5BASE. However, because we add qt5base to the
DEPENDENCIES variable below, I found it more consistent to check for
this specific package being enabled.

> +LOG4CPLUS_DEPENDENCIES += host-pkgconf qt5base
> +LOG4CPLUS_CONF_OPTS += --with-qt5
> +else
> +LOG4CPLUS_CONF_OPTS += --without-qt5
> +endif

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH/next 1/1] package/log4cplus: add optional qt5 dependency

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2019.02.x, thanks.

-- 
Bye, Peter Korsgaard