All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Jiada Wang <jiada_wang@mentor.com>
Cc: <lgirdwood@gmail.com>, <broonie@kernel.org>, <perex@perex.cz>,
	<tiwai@suse.com>, <alsa-devel@alsa-project.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH linux-next v2 9/9] ASoC: rsnd: add busif property to dai stream
Date: Tue, 9 Oct 2018 07:47:11 +0000	[thread overview]
Message-ID: <877eirbmcf.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <ed602ba8-6dc5-005c-3267-47aa378b6c0a@mentor.com>


Hi Jiada

Thanks for your feedback

> 1ch:  (tdm_slots < 4) Basic mode, (tdm_slots >= 4) TDM Split mode
> 2ch: (2 <= tdm_slots < 8) Basic mode, (tdm_slots >= 8) TDM Ex-Split mode
> 4ch: (4 <= tdm_slots < 8) Basic mode, (tdm_slots >= 8) TDM Ex-Split mode
> 6ch: (6 <= tdm_slots < 8) Basic mode, (tdm_slots == 8) TDM Extended
> mode, (8 < tdm_slots) TDM Ex-Split mode
> 8ch: (6 <= tdm_slots < 8) TDM Extended mode, (8 <= tdm_slots < 16)
> Basic mode, (tdm_slots == 16) TDM Ex-Split
> 10ch: TDM Ex-Split mode
> 16ch: Basic Mode

Sorry, but I couldn't understand what this table means ?
For example, what does "1ch" mean ?
It looks like "1ch playback by TDM"...

> The reason I added rsnd_ssi_select_busif(io, chan) in rsnd_hw_params()
> in patch ASoC: rsnd: add busif property to dai stream of v2 patch-set,
> is because runtime channel is necessary information to determine which
> BUSIFx to select,
> (which is mentioned in above)
> and at this stage (rsnd_hw_params()), all other control settings
> (register setting, dma address calculation etc)
> haven't been done, so corresponding dai-link can be considered to be
> not active at this timing
> but maybe you have better suggestion when to automatically select BUSIFx

My image is like this.

	sound {
		compatible = "simple-scu-audio-card or new card";
		...
		simple-audio-card,convert-channels = <8>;
		...
		busif0: simple-audio-card,cpu@0 { sound-dai = <&rcar_sound 0>; };
		busif1: simple-audio-card,cpu@1 { sound-dai = <&rcar_sound 1>; };
		busif2: simple-audio-card,cpu@2 { sound-dai = <&rcar_sound 2>; };
		busif3: simple-audio-card,cpu@3 { sound-dai = <&rcar_sound 3>; };
		        simple-audio-card,codec { sound-dai = <&xxx>;          };
	};

	rcar_sound {
		dai0 { playback = <&ssiu0 ssi0>; }
		dai1 { playback = <&ssiu1 ssi0>; }
		dai2 { playback = <&ssiu2 ssi0>; }
		dai3 { playback = <&ssiu3 ssi0>; }
	};

Best regards
---
Kuninori Morimoto

WARNING: multiple messages have this Message-ID (diff)
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Jiada Wang <jiada_wang@mentor.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
	tiwai@suse.com, alsa-devel@alsa-project.org,
	linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH linux-next v2 9/9] ASoC: rsnd: add busif property to dai stream
Date: Tue, 9 Oct 2018 07:47:11 +0000	[thread overview]
Message-ID: <877eirbmcf.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <ed602ba8-6dc5-005c-3267-47aa378b6c0a@mentor.com>


Hi Jiada

Thanks for your feedback

> 1ch:  (tdm_slots < 4) Basic mode, (tdm_slots >= 4) TDM Split mode
> 2ch: (2 <= tdm_slots < 8) Basic mode, (tdm_slots >= 8) TDM Ex-Split mode
> 4ch: (4 <= tdm_slots < 8) Basic mode, (tdm_slots >= 8) TDM Ex-Split mode
> 6ch: (6 <= tdm_slots < 8) Basic mode, (tdm_slots == 8) TDM Extended
> mode, (8 < tdm_slots) TDM Ex-Split mode
> 8ch: (6 <= tdm_slots < 8) TDM Extended mode, (8 <= tdm_slots < 16)
> Basic mode, (tdm_slots == 16) TDM Ex-Split
> 10ch: TDM Ex-Split mode
> 16ch: Basic Mode

Sorry, but I couldn't understand what this table means ?
For example, what does "1ch" mean ?
It looks like "1ch playback by TDM"...

> The reason I added rsnd_ssi_select_busif(io, chan) in rsnd_hw_params()
> in patch ASoC: rsnd: add busif property to dai stream of v2 patch-set,
> is because runtime channel is necessary information to determine which
> BUSIFx to select,
> (which is mentioned in above)
> and at this stage (rsnd_hw_params()), all other control settings
> (register setting, dma address calculation etc)
> haven't been done, so corresponding dai-link can be considered to be
> not active at this timing
> but maybe you have better suggestion when to automatically select BUSIFx

My image is like this.

	sound {
		compatible = "simple-scu-audio-card or new card";
		...
		simple-audio-card,convert-channels = <8>;
		...
		busif0: simple-audio-card,cpu@0 { sound-dai = <&rcar_sound 0>; };
		busif1: simple-audio-card,cpu@1 { sound-dai = <&rcar_sound 1>; };
		busif2: simple-audio-card,cpu@2 { sound-dai = <&rcar_sound 2>; };
		busif3: simple-audio-card,cpu@3 { sound-dai = <&rcar_sound 3>; };
		        simple-audio-card,codec { sound-dai = <&xxx>;          };
	};

	rcar_sound {
		dai0 { playback = <&ssiu0 ssi0>; }
		dai1 { playback = <&ssiu1 ssi0>; }
		dai2 { playback = <&ssiu2 ssi0>; }
		dai3 { playback = <&ssiu3 ssi0>; }
	};

Best regards
---
Kuninori Morimoto

  reply	other threads:[~2018-10-09  7:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-03  9:01 [PATCH linux-next v2 9/9] ASoC: rsnd: add busif property to dai stream jiada_wang
2018-10-03  9:01 ` jiada_wang
2018-10-04  1:41 ` [alsa-devel] " Kuninori Morimoto
2018-10-04  1:41   ` Kuninori Morimoto
2018-10-04  2:43   ` Jiada Wang
2018-10-04  2:43     ` Jiada Wang
2018-10-04  3:43     ` Kuninori Morimoto
2018-10-04  3:43       ` Kuninori Morimoto
2018-10-04  7:00       ` Jiada Wang
2018-10-04  7:00         ` Jiada Wang
2018-10-09  0:44         ` Kuninori Morimoto
2018-10-09  0:44           ` Kuninori Morimoto
2018-10-09  7:09           ` Jiada Wang
2018-10-09  7:09             ` Jiada Wang
2018-10-09  7:47             ` Kuninori Morimoto [this message]
2018-10-09  7:47               ` Kuninori Morimoto
2018-10-09 10:40               ` Jiada Wang
2018-10-09 10:40                 ` Jiada Wang
2018-10-10  0:16                 ` Kuninori Morimoto
2018-10-10  0:16                   ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877eirbmcf.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jiada_wang@mentor.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.