All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Qiang Zhao <qiang.zhao@nxp.com>, "oss\@buserror.net" <oss@buserror.net>
Cc: "valentin.longchamp\@keymile.com"
	<valentin.longchamp@keymile.com>,
	"linuxppc-dev\@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] qe: fix compile issue for arm64
Date: Mon, 31 Jul 2017 20:37:21 +1000	[thread overview]
Message-ID: <877eyo6gf2.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <AM3PR04MB118514C540F2A3FF383FC4AD91BF0@AM3PR04MB1185.eurprd04.prod.outlook.com>

Qiang Zhao <qiang.zhao@nxp.com> writes:

> Fri 7/28/2017 2:14 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>
>> -----Original Message-----
>> From: Michael Ellerman [mailto:mpe@ellerman.id.au]
>> Sent: Friday, July 28, 2017 2:14 PM
>> To: Qiang Zhao <qiang.zhao@nxp.com>; oss@buserror.net
>> Cc: valentin.longchamp@keymile.com; linuxppc-dev@lists.ozlabs.org; linux-
>> kernel@vger.kernel.org; Qiang Zhao <qiang.zhao@nxp.com>
>> Subject: Re: [PATCH v2] qe: fix compile issue for arm64
>> 
>> Zhao Qiang <qiang.zhao@nxp.com> writes:
>> 
>> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
>> > ---
>> > Changes for v2:
>> > 	- include all Errata QE_General4 in #ifdef
>> >
>> >  drivers/soc/fsl/qe/qe.c | 2 ++
>> >  1 file changed, 2 insertions(+)
>> 
>> AFAICS this driver can only be built on PPC, what am I missing?
>> 
>> config QUICC_ENGINE
>>         bool "Freescale QUICC Engine (QE) Support"
>>         depends on FSL_SOC && PPC32
>> 
>> cheers
>
> I sent another patchset to support it on arm64.

Where? I don't see it.

Shouldn't this patch be part of that series? Otherwise when that series
is merged the build will break on arm64.

cheers

      reply	other threads:[~2017-07-31 10:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-24  3:39 [PATCH v2] qe: fix compile issue for arm64 Zhao Qiang
2017-07-28  6:13 ` Michael Ellerman
2017-07-28  7:14   ` Qiang Zhao
2017-07-28  7:14     ` Qiang Zhao
2017-07-31 10:37     ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877eyo6gf2.fsf@concordia.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=oss@buserror.net \
    --cc=qiang.zhao@nxp.com \
    --cc=valentin.longchamp@keymile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.