From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] checkpatch: There is no qemu_strtod()
Date: Thu, 16 Jun 2016 18:20:32 +0200 [thread overview]
Message-ID: <877fdpw1f3.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <1465526889-8339-3-git-send-email-eblake@redhat.com> (Eric Blake's message of "Thu, 9 Jun 2016 20:48:07 -0600")
Eric Blake <eblake@redhat.com> writes:
> Maybe there should be; but until there is, we should not flag
> strtod() calls as something to replaced with qemu_strtod().
>
> We also lack qemu_strtof() and qemu_strtold(), but as no one
> has been using strtof() or strtold(), it's not worth complicating
> the regex for them.
>
> (Ironically, I had to use 'git commit -n' since checkpatch uses
> TAB indents, in violation of its own recommendations.)
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index c939a32..cf32c8f 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2453,7 +2453,7 @@ sub process {
> }
>
> # recommend qemu_strto* over strto* for numeric conversions
> - if ($line =~ /\b(strto[^k].*?)\s*\(/) {
> + if ($line =~ /\b(strto[^kd].*?)\s*\(/) {
> WARN("consider using qemu_$1 in preference to $1\n" . $herecurr);
> }
> # check for module_init(), use category-specific init macros explicitly please
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Paolo, if you want me to smuggle this into master via qapi-next, let me
know.
next prev parent reply other threads:[~2016-06-16 16:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 2:48 [Qemu-devel] [PATCH 0/4] Guarantee valid JSON in QMP, even for nonfinite numbers Eric Blake
2016-06-10 2:48 ` [Qemu-devel] [PATCH 1/4] qobject: Correct JSON lexer grammar comments Eric Blake
2016-06-16 16:19 ` Markus Armbruster
2016-06-16 17:41 ` Eric Blake
2016-06-17 7:54 ` Markus Armbruster
2016-06-21 13:53 ` Eric Blake
2016-06-10 2:48 ` [Qemu-devel] [PATCH 2/4] checkpatch: There is no qemu_strtod() Eric Blake
2016-06-16 16:20 ` Markus Armbruster [this message]
2016-06-16 16:31 ` Paolo Bonzini
2016-06-10 2:48 ` [Qemu-devel] [PATCH 3/4] qobject: Parse non-finite numbers, as an extension Eric Blake
2016-06-16 15:38 ` Markus Armbruster
2016-06-16 16:25 ` Markus Armbruster
2016-06-17 3:00 ` Eric Blake
2016-06-17 8:04 ` Markus Armbruster
2016-06-10 2:48 ` [Qemu-devel] [PATCH 4/4] qobject: Output valid JSON for non-finite numbers Eric Blake
2016-06-16 16:17 ` Markus Armbruster
2016-06-17 3:06 ` Eric Blake
2016-06-17 8:14 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877fdpw1f3.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.