* [PATCH] stm: select CONFIG_SRCU
@ 2015-11-16 21:14 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2015-11-16 21:14 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-arm-kernel, Mathieu Poirier, Alexander Shishkin, linux-kernel
The newly added STM code uses SRCU, but does not ensure that
this code is part of the kernel:
drivers/built-in.o: In function `stm_source_link_show':
include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
drivers/built-in.o: In function `stm_source_link_drop':
include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
This adds a Kconfig 'select' statement like all the other SRCU using
drivers have.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices")
---
diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
index 83e9f591a54b..e7a348807f0c 100644
--- a/drivers/hwtracing/stm/Kconfig
+++ b/drivers/hwtracing/stm/Kconfig
@@ -1,6 +1,7 @@
config STM
tristate "System Trace Module devices"
select CONFIGFS_FS
+ select SRCU
help
A System Trace Module (STM) is a device exporting data in System
Trace Protocol (STP) format as defined by MIPI STP standards.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] stm: select CONFIG_SRCU
@ 2015-11-16 21:14 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2015-11-16 21:14 UTC (permalink / raw)
To: linux-arm-kernel
The newly added STM code uses SRCU, but does not ensure that
this code is part of the kernel:
drivers/built-in.o: In function `stm_source_link_show':
include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
drivers/built-in.o: In function `stm_source_link_drop':
include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
This adds a Kconfig 'select' statement like all the other SRCU using
drivers have.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices")
---
diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
index 83e9f591a54b..e7a348807f0c 100644
--- a/drivers/hwtracing/stm/Kconfig
+++ b/drivers/hwtracing/stm/Kconfig
@@ -1,6 +1,7 @@
config STM
tristate "System Trace Module devices"
select CONFIGFS_FS
+ select SRCU
help
A System Trace Module (STM) is a device exporting data in System
Trace Protocol (STP) format as defined by MIPI STP standards.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] stm: select CONFIG_SRCU
2015-11-16 21:14 ` Arnd Bergmann
@ 2015-11-16 22:39 ` Russell King - ARM Linux
-1 siblings, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2015-11-16 22:39 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Greg Kroah-Hartman, Alexander Shishkin, Mathieu Poirier,
linux-arm-kernel, linux-kernel
On Mon, Nov 16, 2015 at 10:14:35PM +0100, Arnd Bergmann wrote:
> The newly added STM code uses SRCU, but does not ensure that
> this code is part of the kernel:
>
> drivers/built-in.o: In function `stm_source_link_show':
> include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
> include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
> drivers/built-in.o: In function `stm_source_link_drop':
> include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
> include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
>
> This adds a Kconfig 'select' statement like all the other SRCU using
> drivers have.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices")
Related to this, I have to ask why if I answer to N to STM, I'm then
presented with the STM driver options in this file. It's not like
they'll be built, as drivers/Makefile has:
obj-$(CONFIG_STM) += hwtracing/stm/
so it seems rather pointless.. Maybe the other options here should
be wrapped with if STM..endif ?
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] stm: select CONFIG_SRCU
@ 2015-11-16 22:39 ` Russell King - ARM Linux
0 siblings, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2015-11-16 22:39 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Nov 16, 2015 at 10:14:35PM +0100, Arnd Bergmann wrote:
> The newly added STM code uses SRCU, but does not ensure that
> this code is part of the kernel:
>
> drivers/built-in.o: In function `stm_source_link_show':
> include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
> include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
> drivers/built-in.o: In function `stm_source_link_drop':
> include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
> include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
>
> This adds a Kconfig 'select' statement like all the other SRCU using
> drivers have.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices")
Related to this, I have to ask why if I answer to N to STM, I'm then
presented with the STM driver options in this file. It's not like
they'll be built, as drivers/Makefile has:
obj-$(CONFIG_STM) += hwtracing/stm/
so it seems rather pointless.. Maybe the other options here should
be wrapped with if STM..endif ?
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] stm: select CONFIG_SRCU
2015-11-16 21:14 ` Arnd Bergmann
@ 2015-11-17 13:48 ` Alexander Shishkin
-1 siblings, 0 replies; 6+ messages in thread
From: Alexander Shishkin @ 2015-11-17 13:48 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman
Cc: linux-arm-kernel, Mathieu Poirier, linux-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> The newly added STM code uses SRCU, but does not ensure that
> this code is part of the kernel:
>
> drivers/built-in.o: In function `stm_source_link_show':
> include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
> include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
> drivers/built-in.o: In function `stm_source_link_drop':
> include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
> include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
>
> This adds a Kconfig 'select' statement like all the other SRCU using
> drivers have.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices")
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] stm: select CONFIG_SRCU
@ 2015-11-17 13:48 ` Alexander Shishkin
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Shishkin @ 2015-11-17 13:48 UTC (permalink / raw)
To: linux-arm-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> The newly added STM code uses SRCU, but does not ensure that
> this code is part of the kernel:
>
> drivers/built-in.o: In function `stm_source_link_show':
> include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
> include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
> drivers/built-in.o: In function `stm_source_link_drop':
> include/linux/srcu.h:221: undefined reference to `__srcu_read_lock'
> include/linux/srcu.h:238: undefined reference to `__srcu_read_unlock'
>
> This adds a Kconfig 'select' statement like all the other SRCU using
> drivers have.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices")
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-17 13:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-16 21:14 [PATCH] stm: select CONFIG_SRCU Arnd Bergmann
2015-11-16 21:14 ` Arnd Bergmann
2015-11-16 22:39 ` Russell King - ARM Linux
2015-11-16 22:39 ` Russell King - ARM Linux
2015-11-17 13:48 ` Alexander Shishkin
2015-11-17 13:48 ` Alexander Shishkin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.