All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com,
	mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 00/11] Sprint to the finish: purge QError
Date: Tue, 16 Jun 2015 15:08:41 +0200	[thread overview]
Message-ID: <877fr3g5ra.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20150615120304.7de9c59f@redhat.com> (Luiz Capitulino's message of "Mon, 15 Jun 2015 12:03:04 -0400")

Luiz Capitulino <lcapitulino@redhat.com> writes:

> On Sat, 13 Jun 2015 16:20:47 +0200
> Markus Armbruster <armbru@redhat.com> wrote:
>
>> After a bit over a year and many patches, QError is finally ripe.  All
>> that's left of qerror.h after this series is a bunch of QERR_ macros.
>> Killing them is left for another day.
>
> Excellent!
>
> I did my best to review this series, but unfortunately my review is
> a bit weak because I'm not that familiar with some code paths
> (like QemuOpts) and I was unable to apply patches starting with patch 04/11.

Did you apply on top of my "[PATCH v2 0/7] qdev: Mostly wean off
QError"?

> But it does look good to me:
>
> Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>

Thanks!

  reply	other threads:[~2015-06-16 13:08 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-13 14:20 [Qemu-devel] [PATCH 00/11] Sprint to the finish: purge QError Markus Armbruster
2015-06-13 14:20 ` [Qemu-devel] [PATCH 01/11] QemuOpts: Wean off qerror_report_err() Markus Armbruster
2015-06-14  2:57   ` Eric Blake
2015-06-16 10:58     ` Markus Armbruster
2015-06-15 16:19   ` Stefan Hajnoczi
2015-06-13 14:20 ` [Qemu-devel] [PATCH 02/11] vl: Avoid qerror_report() outside QMP command handlers Markus Armbruster
2015-06-14  3:09   ` Eric Blake
2015-06-16 12:00     ` Markus Armbruster
2015-06-13 14:20 ` [Qemu-devel] [PATCH 03/11] vl: Use error_report() for --display errors Markus Armbruster
2015-06-15 12:49   ` Eric Blake
2015-06-13 14:20 ` [Qemu-devel] [PATCH 04/11] qerror: Eliminate QERR_DEVICE_NOT_FOUND Markus Armbruster
2015-06-15 13:59   ` Eric Blake
2015-06-16 12:26     ` Markus Armbruster
2015-06-15 15:13   ` Stefan Hajnoczi
2015-06-15 15:18   ` Luiz Capitulino
2015-06-15 20:33     ` Eric Blake
2015-06-16 12:28       ` Markus Armbruster
2015-06-15 20:41     ` Peter Maydell
2015-06-16 12:28       ` Markus Armbruster
2015-06-13 14:20 ` [Qemu-devel] [PATCH 05/11] qerror: Clean up QERR_ macros to expand into a single string Markus Armbruster
2015-06-15 15:12   ` Stefan Hajnoczi
2015-06-15 16:09   ` Eric Blake
2015-06-16 12:45     ` Markus Armbruster
2015-06-13 14:20 ` [Qemu-devel] [PATCH 06/11] tpm: Avoid qerror_report() outside QMP command handlers Markus Armbruster
2015-06-15 20:37   ` Eric Blake
2015-06-16 13:07     ` Markus Armbruster
2015-06-13 14:20 ` [Qemu-devel] [PATCH 07/11] qmp: Wean off qerror_report() Markus Armbruster
2015-06-15 15:08   ` Stefan Hajnoczi
2015-06-15 20:56   ` Eric Blake
2015-06-16 12:54     ` Markus Armbruster
2015-06-13 14:20 ` [Qemu-devel] [PATCH 08/11] qerror: Finally unused, clean up Markus Armbruster
2015-06-15 21:05   ` Eric Blake
2015-06-13 14:20 ` [Qemu-devel] [PATCH 09/11] qerror: Move #include out of qerror.h Markus Armbruster
2015-06-15 15:08   ` Stefan Hajnoczi
2015-06-15 21:37   ` Eric Blake
2015-06-13 14:20 ` [Qemu-devel] [PATCH 10/11] Include qapi/qmp/qerror.h exactly where needed Markus Armbruster
2015-06-15 15:09   ` Stefan Hajnoczi
2015-06-15 21:38   ` Eric Blake
2015-06-16 12:58     ` Markus Armbruster
2015-06-13 14:20 ` [Qemu-devel] [PATCH 11/11] Include monitor/monitor.h " Markus Armbruster
2015-06-15 15:09   ` Stefan Hajnoczi
2015-06-15 21:40   ` Eric Blake
2015-06-15 16:03 ` [Qemu-devel] [PATCH 00/11] Sprint to the finish: purge QError Luiz Capitulino
2015-06-16 13:08   ` Markus Armbruster [this message]
2015-06-16 13:35     ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877fr3g5ra.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.