All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Ohad Ben-Cohen <ohad@wizery.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	virtualization <virtualization@lists.linux-foundation.org>,
	"kvm\@vger.kernel.org" <kvm@vger.kernel.org>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] virtio_rpmsg: set DRIVER_OK before using device
Date: Thu, 12 Mar 2015 11:35:49 +1030	[thread overview]
Message-ID: <877funxbwy.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAK=WgbYuv+7LLk0z-fM1q5zCxPTSUNW9piHcBK3mYLzR=j--HA@mail.gmail.com>

Ohad Ben-Cohen <ohad@wizery.com> writes:
> On Mon, Mar 9, 2015 at 10:41 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
>> On Sat, Mar 07, 2015 at 08:06:56PM +0100, Michael S. Tsirkin wrote:
>>> virtio spec requires that all drivers set DRIVER_OK
>>> before using devices. While rpmsg isn't yet
>>> included in the virtio 1 spec, previous spec versions
>>> also required this.
>>>
>>> virtio rpmsg violates this rule: is calls kick
>>> before setting DRIVER_OK.
>>>
>>> The fix isn't trivial since simply calling virtio_device_ready earlier
>>> would mean we might get an interrupt in parallel with adding buffers.
>>>
>>> Instead, split kick out to prepare+notify calls.  prepare before
>>> virtio_device_ready - when we know we won't get interrupts. notify right
>>> afterwards.
>>>
>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>
>> Ohad, can you review and ack pls?
>
> Sure,
>
> Acked-by: Ohad Ben-Cohen <ohad@wizery.com>

Applied.

Thanks,
Rusty.

WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Ohad Ben-Cohen <ohad@wizery.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] virtio_rpmsg: set DRIVER_OK before using device
Date: Thu, 12 Mar 2015 11:35:49 +1030	[thread overview]
Message-ID: <877funxbwy.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAK=WgbYuv+7LLk0z-fM1q5zCxPTSUNW9piHcBK3mYLzR=j--HA@mail.gmail.com>

Ohad Ben-Cohen <ohad@wizery.com> writes:
> On Mon, Mar 9, 2015 at 10:41 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
>> On Sat, Mar 07, 2015 at 08:06:56PM +0100, Michael S. Tsirkin wrote:
>>> virtio spec requires that all drivers set DRIVER_OK
>>> before using devices. While rpmsg isn't yet
>>> included in the virtio 1 spec, previous spec versions
>>> also required this.
>>>
>>> virtio rpmsg violates this rule: is calls kick
>>> before setting DRIVER_OK.
>>>
>>> The fix isn't trivial since simply calling virtio_device_ready earlier
>>> would mean we might get an interrupt in parallel with adding buffers.
>>>
>>> Instead, split kick out to prepare+notify calls.  prepare before
>>> virtio_device_ready - when we know we won't get interrupts. notify right
>>> afterwards.
>>>
>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>
>> Ohad, can you review and ack pls?
>
> Sure,
>
> Acked-by: Ohad Ben-Cohen <ohad@wizery.com>

Applied.

Thanks,
Rusty.

WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Ohad Ben-Cohen <ohad@wizery.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	virtualization <virtualization@lists.linux-foundation.org>
Subject: Re: [Qemu-devel] [PATCH] virtio_rpmsg: set DRIVER_OK before using device
Date: Thu, 12 Mar 2015 11:35:49 +1030	[thread overview]
Message-ID: <877funxbwy.fsf@rustcorp.com.au> (raw)
In-Reply-To: <CAK=WgbYuv+7LLk0z-fM1q5zCxPTSUNW9piHcBK3mYLzR=j--HA@mail.gmail.com>

Ohad Ben-Cohen <ohad@wizery.com> writes:
> On Mon, Mar 9, 2015 at 10:41 AM, Michael S. Tsirkin <mst@redhat.com> wrote:
>> On Sat, Mar 07, 2015 at 08:06:56PM +0100, Michael S. Tsirkin wrote:
>>> virtio spec requires that all drivers set DRIVER_OK
>>> before using devices. While rpmsg isn't yet
>>> included in the virtio 1 spec, previous spec versions
>>> also required this.
>>>
>>> virtio rpmsg violates this rule: is calls kick
>>> before setting DRIVER_OK.
>>>
>>> The fix isn't trivial since simply calling virtio_device_ready earlier
>>> would mean we might get an interrupt in parallel with adding buffers.
>>>
>>> Instead, split kick out to prepare+notify calls.  prepare before
>>> virtio_device_ready - when we know we won't get interrupts. notify right
>>> afterwards.
>>>
>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>> ---
>>
>> Ohad, can you review and ack pls?
>
> Sure,
>
> Acked-by: Ohad Ben-Cohen <ohad@wizery.com>

Applied.

Thanks,
Rusty.

  reply	other threads:[~2015-03-12  1:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-07 19:06 [PATCH] virtio_rpmsg: set DRIVER_OK before using device Michael S. Tsirkin
2015-03-07 19:06 ` [Qemu-devel] " Michael S. Tsirkin
2015-03-07 19:06 ` Michael S. Tsirkin
2015-03-09  7:09 ` Rusty Russell
2015-03-09  7:09   ` [Qemu-devel] " Rusty Russell
2015-03-09  8:27   ` Michael S. Tsirkin
2015-03-09  8:27     ` [Qemu-devel] " Michael S. Tsirkin
2015-03-09  8:27     ` Michael S. Tsirkin
2015-03-09  7:09 ` Rusty Russell
2015-03-09  8:41 ` Michael S. Tsirkin
2015-03-09  8:41   ` [Qemu-devel] " Michael S. Tsirkin
2015-03-09  8:41   ` Michael S. Tsirkin
2015-03-11 12:45   ` Ohad Ben-Cohen
2015-03-11 12:45     ` [Qemu-devel] " Ohad Ben-Cohen
2015-03-11 12:45     ` Ohad Ben-Cohen
2015-03-12  1:05     ` Rusty Russell [this message]
2015-03-12  1:05       ` [Qemu-devel] " Rusty Russell
2015-03-12  1:05       ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877funxbwy.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=ohad@wizery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.