* Re: [PATCH 4/4] mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7790
@ 2014-04-03 15:01 Ben Dooks
2014-04-04 0:38 ` Kuninori Morimoto
0 siblings, 1 reply; 4+ messages in thread
From: Ben Dooks @ 2014-04-03 15:01 UTC (permalink / raw)
To: Linux MMC List, Kuninori Morimoto, linux-kernel, Rob Taylor,
William Towle
We tested this patch with our current kernel, and have a question
about the addition of the of_rcar_gen2_compatible area.
+static const struct sh_mobile_sdhi_of_data of_rcar_gen2_compatible = {
+ .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT |
TMIO_MMC_WRPROTECT_DISABLE,
+ .capabilities = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ,
+ .capabilities2 = MMC_CAP2_NO_MULTI_READ,
+};
We have been doing some speed tests and this is causing an order
of magnitude speed loss with a number of cards. We're seeing
1.2-1.6MB/sec instead of 10+MB/sec we would expect from a Class 10
or UHS-1 card.
Is there any reason to stop using the MULTI_READ as the system seems
to work without MMC_CAP2_NO_MULTI_READ.
Also, this series does not seem to be in any of the git trees I
would expect. Does it need re-sending?
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4/4] mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7790
2014-04-03 15:01 [PATCH 4/4] mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7790 Ben Dooks
@ 2014-04-04 0:38 ` Kuninori Morimoto
0 siblings, 0 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2014-04-04 0:38 UTC (permalink / raw)
To: Ben Dooks
Cc: Linux MMC List, Kuninori Morimoto, linux-kernel, Rob Taylor,
William Towle
Hi Ben
> We tested this patch with our current kernel, and have a question
> about the addition of the of_rcar_gen2_compatible area.
>
> +static const struct sh_mobile_sdhi_of_data of_rcar_gen2_compatible = {
> + .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT |
> TMIO_MMC_WRPROTECT_DISABLE,
> + .capabilities = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ,
> + .capabilities2 = MMC_CAP2_NO_MULTI_READ,
> +};
>
> We have been doing some speed tests and this is causing an order
> of magnitude speed loss with a number of cards. We're seeing
> 1.2-1.6MB/sec instead of 10+MB/sec we would expect from a Class 10
> or UHS-1 card.
>
> Is there any reason to stop using the MULTI_READ as the system seems
> to work without MMC_CAP2_NO_MULTI_READ.
I'm not sure detail, but, Renesas Chip has MULTI_READ bug
which happens under minor condition.
This driver is sharing code together with tmio driver,
but this bug is Renesas Chip only.
OTOH, original (?) code seems that it has similar issue (= MMC_CAP2_NO_MULTI_READ).
Maybe, this flag is over-kill for Renesas Chip,
but, I don't want to add Renesas minor flag to driver.
I'm not sure this is good or not.
> Also, this series does not seem to be in any of the git trees I
> would expect. Does it need re-sending?
Which git tree do you mean ??
I guess it will be merged to Linus tree when -rc1 was released
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 4/4] mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7790
2014-01-31 5:30 ` Kuninori Morimoto
@ 2014-01-31 5:32 ` Kuninori Morimoto
0 siblings, 0 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2014-01-31 5:32 UTC (permalink / raw)
To: Simon, Chris Ball; +Cc: Magnus, Linux-SH, linux-mmc
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
This patch updates r8a7790 DT data to have SoC specific settings.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/mmc/host/sh_mobile_sdhi.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c
index 322cd35..7498f5b 100644
--- a/drivers/mmc/host/sh_mobile_sdhi.c
+++ b/drivers/mmc/host/sh_mobile_sdhi.c
@@ -38,6 +38,7 @@
struct sh_mobile_sdhi_of_data {
unsigned long tmio_flags;
unsigned long capabilities;
+ unsigned long capabilities2;
};
static const struct sh_mobile_sdhi_of_data sh_mobile_sdhi_of_cfg[] = {
@@ -51,6 +52,12 @@ static const struct sh_mobile_sdhi_of_data of_rcar_gen1_compatible = {
.capabilities = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ,
};
+static const struct sh_mobile_sdhi_of_data of_rcar_gen2_compatible = {
+ .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_WRPROTECT_DISABLE,
+ .capabilities = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ,
+ .capabilities2 = MMC_CAP2_NO_MULTI_READ,
+};
+
static const struct of_device_id sh_mobile_sdhi_of_match[] = {
{ .compatible = "renesas,sdhi-shmobile" },
{ .compatible = "renesas,sdhi-sh7372" },
@@ -59,7 +66,7 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = {
{ .compatible = "renesas,sdhi-r8a7740", .data = &sh_mobile_sdhi_of_cfg[0], },
{ .compatible = "renesas,sdhi-r8a7778", .data = &of_rcar_gen1_compatible, },
{ .compatible = "renesas,sdhi-r8a7779", .data = &of_rcar_gen1_compatible, },
- { .compatible = "renesas,sdhi-r8a7790", .data = &sh_mobile_sdhi_of_cfg[0], },
+ { .compatible = "renesas,sdhi-r8a7790", .data = &of_rcar_gen2_compatible, },
{},
};
MODULE_DEVICE_TABLE(of, sh_mobile_sdhi_of_match);
@@ -219,6 +226,7 @@ static int sh_mobile_sdhi_probe(struct platform_device *pdev)
const struct sh_mobile_sdhi_of_data *of_data = of_id->data;
mmc_data->flags |= of_data->tmio_flags;
mmc_data->capabilities |= of_data->capabilities;
+ mmc_data->capabilities2 |= of_data->capabilities2;
}
/* SD control register space size is 0x100, 0x200 for bus_shift=1 */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 4/4] mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7790
@ 2014-01-31 5:32 ` Kuninori Morimoto
0 siblings, 0 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2014-01-31 5:32 UTC (permalink / raw)
To: Simon, Chris Ball; +Cc: Magnus, Linux-SH, linux-mmc
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
This patch updates r8a7790 DT data to have SoC specific settings.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
drivers/mmc/host/sh_mobile_sdhi.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c
index 322cd35..7498f5b 100644
--- a/drivers/mmc/host/sh_mobile_sdhi.c
+++ b/drivers/mmc/host/sh_mobile_sdhi.c
@@ -38,6 +38,7 @@
struct sh_mobile_sdhi_of_data {
unsigned long tmio_flags;
unsigned long capabilities;
+ unsigned long capabilities2;
};
static const struct sh_mobile_sdhi_of_data sh_mobile_sdhi_of_cfg[] = {
@@ -51,6 +52,12 @@ static const struct sh_mobile_sdhi_of_data of_rcar_gen1_compatible = {
.capabilities = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ,
};
+static const struct sh_mobile_sdhi_of_data of_rcar_gen2_compatible = {
+ .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_WRPROTECT_DISABLE,
+ .capabilities = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ,
+ .capabilities2 = MMC_CAP2_NO_MULTI_READ,
+};
+
static const struct of_device_id sh_mobile_sdhi_of_match[] = {
{ .compatible = "renesas,sdhi-shmobile" },
{ .compatible = "renesas,sdhi-sh7372" },
@@ -59,7 +66,7 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = {
{ .compatible = "renesas,sdhi-r8a7740", .data = &sh_mobile_sdhi_of_cfg[0], },
{ .compatible = "renesas,sdhi-r8a7778", .data = &of_rcar_gen1_compatible, },
{ .compatible = "renesas,sdhi-r8a7779", .data = &of_rcar_gen1_compatible, },
- { .compatible = "renesas,sdhi-r8a7790", .data = &sh_mobile_sdhi_of_cfg[0], },
+ { .compatible = "renesas,sdhi-r8a7790", .data = &of_rcar_gen2_compatible, },
{},
};
MODULE_DEVICE_TABLE(of, sh_mobile_sdhi_of_match);
@@ -219,6 +226,7 @@ static int sh_mobile_sdhi_probe(struct platform_device *pdev)
const struct sh_mobile_sdhi_of_data *of_data = of_id->data;
mmc_data->flags |= of_data->tmio_flags;
mmc_data->capabilities |= of_data->capabilities;
+ mmc_data->capabilities2 |= of_data->capabilities2;
}
/* SD control register space size is 0x100, 0x200 for bus_shift=1 */
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-04 0:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-03 15:01 [PATCH 4/4] mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7790 Ben Dooks
2014-04-04 0:38 ` Kuninori Morimoto
-- strict thread matches above, loose matches on Subject: below --
2014-01-28 4:44 mmc: sh_mobile_sdhi: DT update for R-Car Kuninori Morimoto
2014-01-31 5:30 ` Kuninori Morimoto
2014-01-31 5:32 ` [PATCH 4/4] mmc: SDHI: update sh_mobile_sdhi_of_data for r8a7790 Kuninori Morimoto
2014-01-31 5:32 ` Kuninori Morimoto
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.