From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, liam.r.girdwood@linux.intel.com,
detheridge@ti.com, peter.ujfalusi@ti.com, broonie@kernel.org,
bcousson@baylibre.com
Subject: Re: [alsa-devel] [PATCH RFC v2 0/2] Fix simple-card *-master DT parameter handling
Date: Tue, 11 Mar 2014 18:13:38 -0700 (PDT) [thread overview]
Message-ID: <877g80rzgg.wl%kuninori.morimoto.gx@gmail.com> (raw)
In-Reply-To: <cover.1394451329.git.jsarha@ti.com>
Hi Jyri
> Since RFC:
> - fixed commit msg typo
> - added include/sound/soc.h changes too
>
> The sematics of bitclock-master and frame-master DT parameters
> should depend on whether they are found from a cpu-dai or codec
> sub-node.
>
> - bitclock-master in cpu-dai node means Codec-Bitclock-Slave
> - frame-master in cpu-dai node means Codec-Frame-Slave
> - bitclock-master in codec node means Codec-Bitclock-Master
> - frame-master in codec node means Codec-Frame-Master
>
> For example in a cpu-dai mode bitclock-master parameter should produce
> SND_SOC_DAIFMT_CBS_* daifmt flags and a codec node
> SND_SOC_DAIFMT_CBM_* flags.
SND_SOC_DAIFMT_xxx comment indicates "codec clk/FRM" indeed.
but does this "codec" means "codec chip" ??
I'm not sure.
but anyway, if my understanding is correct,
simple-audio-card,cpu {
...
bitclock-master;
frame-master;
};
simple-audio-card,codec {
...
bitclock-master;
frame-master;
};
This will be
cpu : SND_SOC_DAIFMT_CBS_CFS
codec : SND_SOC_DAIFMT_CBM_CFM
but, it is un-understandable/confusable for me,
and it breaks our sound card.
${LINUX}/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
${LINUX}/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
I guess you want like this ?
codec-bitclock-master;
codec-frame-master;
simple-audio-card,cpu {
...
};
simple-audio-card,codec {
...
};
# And I guess [1/2] and [2/2] should be 1 patch.
# otherwise, it breaks git-bisect :P
Best regards
---
Kuninori Morimoto
next prev parent reply other threads:[~2014-03-12 1:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 11:41 [PATCH RFC v2 0/2] Fix simple-card *-master DT parameter handling Jyri Sarha
2014-03-10 11:41 ` [PATCH RFC v2 1/2] ASoC: core: Add is_cpu_dai_node-parameter to snd_soc_of_parse_daifmt() Jyri Sarha
2014-03-10 11:41 ` [PATCH RFC v2 2/2] ASoC: simple-card: Take snd_soc_of_parse_daifmt() change in to account Jyri Sarha
2014-03-11 10:50 ` [PATCH RFC v2 0/2] Fix simple-card *-master DT parameter handling Mark Brown
2014-03-12 1:13 ` Kuninori Morimoto [this message]
2014-03-12 4:07 ` [alsa-devel] " Kuninori Morimoto
2014-03-12 5:00 ` Richard Lee
2014-03-12 6:11 ` Kuninori Morimoto
2014-03-12 9:27 ` Jyri Sarha
2014-04-14 5:07 ` Kuninori Morimoto
2014-04-14 9:53 ` Jyri Sarha
2014-04-15 0:23 ` Kuninori Morimoto
2014-03-12 12:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877g80rzgg.wl%kuninori.morimoto.gx@gmail.com \
--to=kuninori.morimoto.gx@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=detheridge@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jsarha@ti.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.