All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] build: Fix installation of target-dependent files
@ 2014-01-20 11:21 Lluís Vilanova
  2014-02-10 20:00 ` Lluís Vilanova
  2014-03-08 12:17 ` Peter Maydell
  0 siblings, 2 replies; 6+ messages in thread
From: Lluís Vilanova @ 2014-01-20 11:21 UTC (permalink / raw)
  To: qemu-devel; +Cc: Anthony Liguori

Pass all the relevant sub-directory make variables.

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index bdff4e4..02ae76d 100644
--- a/Makefile
+++ b/Makefile
@@ -366,7 +366,7 @@ endif
 		$(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(qemu_datadir)/keymaps"; \
 	done
 	for d in $(TARGET_DIRS); do \
-	$(MAKE) -C $$d $@ || exit 1 ; \
+	$(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \
         done
 
 # various test targets

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] build: Fix installation of target-dependent files
  2014-01-20 11:21 [Qemu-devel] [PATCH] build: Fix installation of target-dependent files Lluís Vilanova
@ 2014-02-10 20:00 ` Lluís Vilanova
  2014-03-07  1:19   ` Lluís Vilanova
  2014-03-08 12:17 ` Peter Maydell
  1 sibling, 1 reply; 6+ messages in thread
From: Lluís Vilanova @ 2014-02-10 20:00 UTC (permalink / raw)
  To: qemu-devel; +Cc: Anthony Liguori

Lluís Vilanova writes:

> Pass all the relevant sub-directory make variables.

Ping.

Thanks,
  Lluis


> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
>  Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/Makefile b/Makefile
> index bdff4e4..02ae76d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -366,7 +366,7 @@ endif
>  		$(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(qemu_datadir)/keymaps"; \
>  	done
>  	for d in $(TARGET_DIRS); do \
> -	$(MAKE) -C $$d $@ || exit 1 ; \
> +	$(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \
>          done
 
>  # various test targets

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] build: Fix installation of target-dependent files
  2014-02-10 20:00 ` Lluís Vilanova
@ 2014-03-07  1:19   ` Lluís Vilanova
  2014-03-07  7:32     ` Paolo Bonzini
  0 siblings, 1 reply; 6+ messages in thread
From: Lluís Vilanova @ 2014-03-07  1:19 UTC (permalink / raw)
  To: qemu-devel; +Cc: Anthony Liguori

Lluís Vilanova writes:

> Lluís Vilanova writes:
>> Pass all the relevant sub-directory make variables.

> Ping.

Ping^2


> Thanks,
>   Lluis


>> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
>> ---
>> Makefile |    2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)

>> diff --git a/Makefile b/Makefile
>> index bdff4e4..02ae76d 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -366,7 +366,7 @@ endif
>> $(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(qemu_datadir)/keymaps"; \
>> done
>> for d in $(TARGET_DIRS); do \
>> -	$(MAKE) -C $$d $@ || exit 1 ; \
>> +	$(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \
>> done
 
>> # various test targets


-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] build: Fix installation of target-dependent files
  2014-03-07  1:19   ` Lluís Vilanova
@ 2014-03-07  7:32     ` Paolo Bonzini
  0 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2014-03-07  7:32 UTC (permalink / raw)
  To: qemu-devel, Anthony Liguori

Il 07/03/2014 02:19, Lluís Vilanova ha scritto:
> Lluís Vilanova writes:
>
>> Lluís Vilanova writes:
>>> Pass all the relevant sub-directory make variables.
>
>> Ping.
>
> Ping^2
>
>
>> Thanks,
>>   Lluis
>
>
>>> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
>>> ---
>>> Makefile |    2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>>> diff --git a/Makefile b/Makefile
>>> index bdff4e4..02ae76d 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -366,7 +366,7 @@ endif
>>> $(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(qemu_datadir)/keymaps"; \
>>> done
>>> for d in $(TARGET_DIRS); do \
>>> -	$(MAKE) -C $$d $@ || exit 1 ; \
>>> +	$(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \
>>> done
>
>>> # various test targets
>
>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Qemu-devel] [PATCH] build: Fix installation of target-dependent files
  2014-01-20 11:21 [Qemu-devel] [PATCH] build: Fix installation of target-dependent files Lluís Vilanova
  2014-02-10 20:00 ` Lluís Vilanova
@ 2014-03-08 12:17 ` Peter Maydell
  1 sibling, 0 replies; 6+ messages in thread
From: Peter Maydell @ 2014-03-08 12:17 UTC (permalink / raw)
  To: Lluís Vilanova; +Cc: QEMU Developers, Anthony Liguori

On 20 January 2014 11:21, Lluís Vilanova <vilanova@ac.upc.edu> wrote:
> Pass all the relevant sub-directory make variables.
>
> Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
> ---
>  Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master as a build fix of sorts.

thanks
-- PMM

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Qemu-devel] [PATCH] build: Fix installation of target-dependent files
@ 2014-01-09 10:54 Lluís Vilanova
  0 siblings, 0 replies; 6+ messages in thread
From: Lluís Vilanova @ 2014-01-09 10:54 UTC (permalink / raw)
  To: qemu-devel; +Cc: Anthony Liguori, Paul Brook

Pass all the relevant sub-directory make variables.

Signed-off-by: Lluís Vilanova <vilanova@ac.upc.edu>
---
Cc: Anthony Liguori <aliguori@us.ibm.com>
Cc: Paul Brook <paul@codesourcery.com>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index bdff4e4..02ae76d 100644
--- a/Makefile
+++ b/Makefile
@@ -366,7 +366,7 @@ endif
 		$(INSTALL_DATA) $(SRC_PATH)/pc-bios/keymaps/$$x "$(DESTDIR)$(qemu_datadir)/keymaps"; \
 	done
 	for d in $(TARGET_DIRS); do \
-	$(MAKE) -C $$d $@ || exit 1 ; \
+	$(MAKE) $(SUBDIR_MAKEFLAGS) TARGET_DIR=$$d/ -C $$d $@ || exit 1 ; \
         done
 
 # various test targets

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-03-08 12:18 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-20 11:21 [Qemu-devel] [PATCH] build: Fix installation of target-dependent files Lluís Vilanova
2014-02-10 20:00 ` Lluís Vilanova
2014-03-07  1:19   ` Lluís Vilanova
2014-03-07  7:32     ` Paolo Bonzini
2014-03-08 12:17 ` Peter Maydell
  -- strict thread matches above, loose matches on Subject: below --
2014-01-09 10:54 Lluís Vilanova

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.