* [PATCH] ALSA: hda/via: Delete does not require return
@ 2022-05-27 12:10 ` Xiang wangx
0 siblings, 0 replies; 4+ messages in thread
From: Xiang wangx @ 2022-05-27 12:10 UTC (permalink / raw)
To: perex; +Cc: tiwai, alsa-devel, linux-kernel, Xiang wangx
Void function return statements are not generally useful.
Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
---
sound/pci/hda/patch_via.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
index 773a136161f1..a05304f340df 100644
--- a/sound/pci/hda/patch_via.c
+++ b/sound/pci/hda/patch_via.c
@@ -449,8 +449,6 @@ static void vt1708_set_pinconfig_connect(struct hda_codec *codec, hda_nid_t nid)
def_conf = def_conf & (~(AC_JACK_PORT_BOTH << 30));
snd_hda_codec_set_pincfg(codec, nid, def_conf);
}
-
- return;
}
static int vt1708_jack_detect_get(struct snd_kcontrol *kcontrol,
--
2.36.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ALSA: hda/via: Delete does not require return
@ 2022-05-27 12:10 ` Xiang wangx
0 siblings, 0 replies; 4+ messages in thread
From: Xiang wangx @ 2022-05-27 12:10 UTC (permalink / raw)
To: perex; +Cc: alsa-devel, Xiang wangx, tiwai, linux-kernel
Void function return statements are not generally useful.
Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
---
sound/pci/hda/patch_via.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
index 773a136161f1..a05304f340df 100644
--- a/sound/pci/hda/patch_via.c
+++ b/sound/pci/hda/patch_via.c
@@ -449,8 +449,6 @@ static void vt1708_set_pinconfig_connect(struct hda_codec *codec, hda_nid_t nid)
def_conf = def_conf & (~(AC_JACK_PORT_BOTH << 30));
snd_hda_codec_set_pincfg(codec, nid, def_conf);
}
-
- return;
}
static int vt1708_jack_detect_get(struct snd_kcontrol *kcontrol,
--
2.36.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/via: Delete does not require return
2022-05-27 12:10 ` Xiang wangx
@ 2022-05-27 14:57 ` Takashi Iwai
-1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2022-05-27 14:57 UTC (permalink / raw)
To: Xiang wangx; +Cc: perex, tiwai, alsa-devel, linux-kernel
On Fri, 27 May 2022 14:10:59 +0200,
Xiang wangx wrote:
>
> Void function return statements are not generally useful.
>
> Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/via: Delete does not require return
@ 2022-05-27 14:57 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2022-05-27 14:57 UTC (permalink / raw)
To: Xiang wangx; +Cc: linux-kernel, alsa-devel, tiwai
On Fri, 27 May 2022 14:10:59 +0200,
Xiang wangx wrote:
>
> Void function return statements are not generally useful.
>
> Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
Thanks, applied.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-27 15:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-27 12:10 [PATCH] ALSA: hda/via: Delete does not require return Xiang wangx
2022-05-27 12:10 ` Xiang wangx
2022-05-27 14:57 ` Takashi Iwai
2022-05-27 14:57 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.