[Buildroot] [PATCH 1/1] package/imagemagick: SVG support needs host gcc >= 4.9

[Buildroot] [PATCH 1/1] package/imagemagick: SVG support needs host gcc >= 4.9

[Fabrice Fontaine]

SVG support needs host gcc >= 4.9 since bump of harfbuzz to version
3.1.2 in commit 6861933d22006fbe8c961a41506beac826881f33:

In file included from ../src/hb.hh:473:0,
                 from ../src/hb-buffer-serialize.cc:27:
../src/hb-vector.hh:206:20: error: 'is_trivially_copy_assignable' is not a member of 'std'
      hb_enable_if (std::is_trivially_copy_assignable<T>::value)>
                    ^

Fixes:
 - http://autobuild.buildroot.org/results/7b2430c5ae4eed51685ec12bf778c07a0a8b1701

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/imagemagick/Config.in.host | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/imagemagick/Config.in.host b/package/imagemagick/Config.in.host
index 671b0995dc..5055101e23 100644
--- a/package/imagemagick/Config.in.host
+++ b/package/imagemagick/Config.in.host
@@ -17,6 +17,7 @@ if BR2_PACKAGE_HOST_IMAGEMAGICK
 config BR2_PACKAGE_HOST_IMAGEMAGICK_SVG
 	bool "SVG support"
 	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS # host-librsvg
+	depends on BR2_HOST_GCC_AT_LEAST_4_9 # host-pango -> host-harfbuzz
 	help
 	  Say 'y' here is you need ImageMagick tools (like convert)
 	  to support SVG.
@@ -24,4 +25,8 @@ config BR2_PACKAGE_HOST_IMAGEMAGICK_SVG
 	  This is not enabled by default, as it brings quite a few
 	  extra dependencies, and thus extra build time.
 
+comment "SVG support needs host gcc >= 4.9"
+	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
+	depends on !BR2_HOST_GCC_AT_LEAST_4_9
+
 endif
-- 
2.35.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/imagemagick: SVG support needs host gcc >= 4.9

[Arnout Vandecappelle]

On 23/04/2022 00:04, Fabrice Fontaine wrote:
> SVG support needs host gcc >= 4.9 since bump of harfbuzz to version
> 3.1.2 in commit 6861933d22006fbe8c961a41506beac826881f33:
> 
> In file included from ../src/hb.hh:473:0,
>                   from ../src/hb-buffer-serialize.cc:27:
> ../src/hb-vector.hh:206:20: error: 'is_trivially_copy_assignable' is not a member of 'std'
>        hb_enable_if (std::is_trivially_copy_assignable<T>::value)>
>                      ^
> 
> Fixes:
>   - http://autobuild.buildroot.org/results/7b2430c5ae4eed51685ec12bf778c07a0a8b1701
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

  Applied to master, thanks.

  Regards,
  Arnout

> ---
>   package/imagemagick/Config.in.host | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/package/imagemagick/Config.in.host b/package/imagemagick/Config.in.host
> index 671b0995dc..5055101e23 100644
> --- a/package/imagemagick/Config.in.host
> +++ b/package/imagemagick/Config.in.host
> @@ -17,6 +17,7 @@ if BR2_PACKAGE_HOST_IMAGEMAGICK
>   config BR2_PACKAGE_HOST_IMAGEMAGICK_SVG
>   	bool "SVG support"
>   	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS # host-librsvg
> +	depends on BR2_HOST_GCC_AT_LEAST_4_9 # host-pango -> host-harfbuzz
>   	help
>   	  Say 'y' here is you need ImageMagick tools (like convert)
>   	  to support SVG.
> @@ -24,4 +25,8 @@ config BR2_PACKAGE_HOST_IMAGEMAGICK_SVG
>   	  This is not enabled by default, as it brings quite a few
>   	  extra dependencies, and thus extra build time.
>   
> +comment "SVG support needs host gcc >= 4.9"
> +	depends on BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
> +	depends on !BR2_HOST_GCC_AT_LEAST_4_9
> +
>   endif
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/imagemagick: SVG support needs host gcc >= 4.9

[Peter Korsgaard]

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > SVG support needs host gcc >= 4.9 since bump of harfbuzz to version
 > 3.1.2 in commit 6861933d22006fbe8c961a41506beac826881f33:

 > In file included from ../src/hb.hh:473:0,
 >                  from ../src/hb-buffer-serialize.cc:27:
 > ../src/hb-vector.hh:206:20: error: 'is_trivially_copy_assignable' is not a member of 'std'
 >       hb_enable_if (std::is_trivially_copy_assignable<T>::value)>
 >                     ^

 > Fixes:
 >  - http://autobuild.buildroot.org/results/7b2430c5ae4eed51685ec12bf778c07a0a8b1701

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Committed to 2022.02.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot