From: Markus Armbruster <armbru@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Andrew Melnichenko <andrew@daynix.com>,
Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Yuri Benditovich <yuri.benditovich@daynix.com>,
Yan Vugenfirer <yan@daynix.com>
Subject: Re: ebpf/rss.bpf.skeleton.h generated by what?
Date: Wed, 11 May 2022 14:46:49 +0200 [thread overview]
Message-ID: <878rr8grt2.fsf@pond.sub.org> (raw)
In-Reply-To: <CACGkMEvO3Q0vxy08eTVu4oXJqMV1Fyf3w-SBFGhrOLN_-ih8ng@mail.gmail.com> (Jason Wang's message of "Wed, 11 May 2022 16:53:23 +0800")
Jason Wang <jasowang@redhat.com> writes:
> On Tue, May 10, 2022 at 8:24 PM Andrew Melnichenko <andrew@daynix.com> wrote:
>>
>> Hi all,
>> The ebpf/rss.bpf.skeleton.h is generetad by bpftool from tools/ebpf/rss.bpf.c.
>> To generate the skeleton - would require dependencies of llvm and bpftool.
>> RSS eBPF solution, for now, is only for Linux hosts.
>>
>> > Andrew, want to post a patch to explain this?
>> I am all in for clarification. And will prepare a new patch if required.
>> Please advise, what those patches should be? Documentation update?
>
> It looks to me the doc are fine:
>
> """
> RSS eBPF program
> ----------------
>
> RSS program located in ebpf/rss.bpf.skeleton.h generated by bpftool.
> So the program is part of the qemu binary.
> Initially, the eBPF program was compiled by clang and source code
> located at tools/ebpf/rss.bpf.c.
> """
Agreed.
> It was too late to fix the changelog but we probably don't have anything to do.
Next time :)
> Or we can update ebpf/rss.bpf.skeleton.h by using the most recent
> bpftool where I've added the BPFTOOL as the generator name[1].
Won't hurt, but no rush.
> Thanks
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=56c3e749d08a
prev parent reply other threads:[~2022-05-11 12:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 12:25 ebpf/rss.bpf.skeleton.h generated by what? Markus Armbruster
2022-05-07 5:05 ` Jason Wang
2022-05-07 6:46 ` Paolo Bonzini
2022-05-07 6:53 ` Jason Wang
2022-05-07 6:58 ` Paolo Bonzini
2022-05-07 7:08 ` Jason Wang
2022-05-09 5:27 ` Markus Armbruster
2022-05-09 6:52 ` Jason Wang
2022-05-09 8:41 ` Peter Maydell
2022-05-09 9:35 ` Jason Wang
2022-05-10 12:15 ` Andrew Melnichenko
2022-05-11 8:53 ` Jason Wang
2022-05-11 12:46 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rr8grt2.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=andrew@daynix.com \
--cc=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.