All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Markus Armbruster <armbru@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Andrew Melnychenko <andrew@daynix.com>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: ebpf/rss.bpf.skeleton.h generated by what?
Date: Mon, 9 May 2022 17:35:34 +0800	[thread overview]
Message-ID: <CACGkMEuXM2YzFCGNgfZH5K1+Yvsvpdn103fcKGchjoh+VqFeRg@mail.gmail.com> (raw)
In-Reply-To: <CAFEAcA9QGSqx=e5CgsbyBwVH3wa_VW1i2c=5H5cKp5X-hHs71Q@mail.gmail.com>

On Mon, May 9, 2022 at 4:42 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Mon, 9 May 2022 at 06:30, Markus Armbruster <armbru@redhat.com> wrote:
> > Always, always, *always* document your reasons for doing stuff right in
> > the commit message, unless they are blindingly obvious.  I understand
> > reasons can be obvious enough to the author.  Document them anyway if
> > there is any chance they are not obvious to others.
>
> It's also nice for code-generators to say who they are
> in this kind of "this file is autogenerated" comment.
> For instance our own decodetree script's comments read
>   /* This file is autogenerated by scripts/decodetree.py.  */

Unfortunately, this is not what bpftool did right now.

Have posted a patch (with Markus and you cced).

Thanks

>
> -- PMM
>



  reply	other threads:[~2022-05-09  9:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06 12:25 ebpf/rss.bpf.skeleton.h generated by what? Markus Armbruster
2022-05-07  5:05 ` Jason Wang
2022-05-07  6:46   ` Paolo Bonzini
2022-05-07  6:53     ` Jason Wang
2022-05-07  6:58       ` Paolo Bonzini
2022-05-07  7:08         ` Jason Wang
2022-05-09  5:27           ` Markus Armbruster
2022-05-09  6:52             ` Jason Wang
2022-05-09  8:41             ` Peter Maydell
2022-05-09  9:35               ` Jason Wang [this message]
2022-05-10 12:15                 ` Andrew Melnichenko
2022-05-11  8:53                   ` Jason Wang
2022-05-11 12:46                     ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACGkMEuXM2YzFCGNgfZH5K1+Yvsvpdn103fcKGchjoh+VqFeRg@mail.gmail.com \
    --to=jasowang@redhat.com \
    --cc=andrew@daynix.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.