[PATCH] colo: Don't dump colo cache if dump-guest-core=off

* [PATCH] colo: Don't dump colo cache if dump-guest-core=off
@ 2021-07-04 16:14 Lukas Straub
  2021-11-02 16:26 ` Juan Quintela
  0 siblings, 1 reply; 2+ messages in thread
From: Lukas Straub @ 2021-07-04 16:14 UTC (permalink / raw)
  To: qemu-devel
  Cc: zhang.zhanghailiang, Dr. David Alan Gilbert, Rao, Lei, Juan Quintela

[-- Attachment #1: Type: text/plain, Size: 987 bytes --]

One might set dump-guest-core=off to make coredumps smaller and
still allow to debug many qemu bugs. Extend this option to the colo
cache.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
---
 migration/ram.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/migration/ram.c b/migration/ram.c
index 723af67c2e..0797d0d222 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -56,6 +56,8 @@
 #include "multifd.h"
 #include "sysemu/runstate.h"
 
+#include "hw/boards.h" /* for machine_dump_guest_core() */
+
 #if defined(__linux__)
 #include "qemu/userfaultfd.h"
 #endif /* defined(__linux__) */
@@ -3356,6 +3358,10 @@ int colo_init_ram_cache(void)
                 }
                 return -errno;
             }
+            if (!machine_dump_guest_core(current_machine)) {
+                qemu_madvise(block->colo_cache, block->used_length,
+                             QEMU_MADV_DONTDUMP);
+            }
         }
     }
 
-- 
2.20.1

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread