All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Greg Ungerer <gerg@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Sean Wang <sean.wang@kernel.org>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: net: mediatek: support MT7621 SoC
Date: Mon, 19 Apr 2021 08:24:09 +0200	[thread overview]
Message-ID: <878s5e94hi.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20210419034253.21322-1-ilya.lipnitskiy@gmail.com> (Ilya Lipnitskiy's message of "Sun, 18 Apr 2021 20:42:53 -0700")

Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com> writes:

> Add missing binding documentation for SoC support that has been in place
> since v5.1
>
> Fixes: 889bcbdeee57 ("net: ethernet: mediatek: support MT7621 SoC ethernet hardware")
> Cc: Bjørn Mork <bjorn@mork.no>
> Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
> ---
>  Documentation/devicetree/bindings/net/mediatek-net.txt | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt
> index 72d03e07cf7c..950ef6af20b1 100644
> --- a/Documentation/devicetree/bindings/net/mediatek-net.txt
> +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt
> @@ -10,6 +10,7 @@ Required properties:
>  - compatible: Should be
>  		"mediatek,mt2701-eth": for MT2701 SoC
>  		"mediatek,mt7623-eth", "mediatek,mt2701-eth": for MT7623 SoC
> +		"mediatek,mt7621-eth": for MT7621 SoC
>  		"mediatek,mt7622-eth": for MT7622 SoC
>  		"mediatek,mt7629-eth": for MT7629 SoC
>  		"ralink,rt5350-eth": for Ralink Rt5350F and MT7628/88 SoC


Thanks for taking care of this!

Note, however, that this compatible value is defined in
Documentation/devicetree/bindings/net/ralink,rt2880-net.txt

I believe that file should go away. These two files are both documenting
the same compatible property AFAICS.


Bjørn

WARNING: multiple messages have this Message-ID (diff)
From: "Bjørn Mork" <bjorn@mork.no>
To: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Greg Ungerer <gerg@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Sean Wang <sean.wang@kernel.org>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: net: mediatek: support MT7621 SoC
Date: Mon, 19 Apr 2021 08:24:09 +0200	[thread overview]
Message-ID: <878s5e94hi.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20210419034253.21322-1-ilya.lipnitskiy@gmail.com> (Ilya Lipnitskiy's message of "Sun, 18 Apr 2021 20:42:53 -0700")

Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com> writes:

> Add missing binding documentation for SoC support that has been in place
> since v5.1
>
> Fixes: 889bcbdeee57 ("net: ethernet: mediatek: support MT7621 SoC ethernet hardware")
> Cc: Bjørn Mork <bjorn@mork.no>
> Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
> ---
>  Documentation/devicetree/bindings/net/mediatek-net.txt | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt
> index 72d03e07cf7c..950ef6af20b1 100644
> --- a/Documentation/devicetree/bindings/net/mediatek-net.txt
> +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt
> @@ -10,6 +10,7 @@ Required properties:
>  - compatible: Should be
>  		"mediatek,mt2701-eth": for MT2701 SoC
>  		"mediatek,mt7623-eth", "mediatek,mt2701-eth": for MT7623 SoC
> +		"mediatek,mt7621-eth": for MT7621 SoC
>  		"mediatek,mt7622-eth": for MT7622 SoC
>  		"mediatek,mt7629-eth": for MT7629 SoC
>  		"ralink,rt5350-eth": for Ralink Rt5350F and MT7628/88 SoC


Thanks for taking care of this!

Note, however, that this compatible value is defined in
Documentation/devicetree/bindings/net/ralink,rt2880-net.txt

I believe that file should go away. These two files are both documenting
the same compatible property AFAICS.


Bjørn

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: "Bjørn Mork" <bjorn@mork.no>
To: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Greg Ungerer <gerg@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Sean Wang <sean.wang@kernel.org>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: net: mediatek: support MT7621 SoC
Date: Mon, 19 Apr 2021 08:24:09 +0200	[thread overview]
Message-ID: <878s5e94hi.fsf@miraculix.mork.no> (raw)
In-Reply-To: <20210419034253.21322-1-ilya.lipnitskiy@gmail.com> (Ilya Lipnitskiy's message of "Sun, 18 Apr 2021 20:42:53 -0700")

Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com> writes:

> Add missing binding documentation for SoC support that has been in place
> since v5.1
>
> Fixes: 889bcbdeee57 ("net: ethernet: mediatek: support MT7621 SoC ethernet hardware")
> Cc: Bjørn Mork <bjorn@mork.no>
> Signed-off-by: Ilya Lipnitskiy <ilya.lipnitskiy@gmail.com>
> ---
>  Documentation/devicetree/bindings/net/mediatek-net.txt | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/mediatek-net.txt b/Documentation/devicetree/bindings/net/mediatek-net.txt
> index 72d03e07cf7c..950ef6af20b1 100644
> --- a/Documentation/devicetree/bindings/net/mediatek-net.txt
> +++ b/Documentation/devicetree/bindings/net/mediatek-net.txt
> @@ -10,6 +10,7 @@ Required properties:
>  - compatible: Should be
>  		"mediatek,mt2701-eth": for MT2701 SoC
>  		"mediatek,mt7623-eth", "mediatek,mt2701-eth": for MT7623 SoC
> +		"mediatek,mt7621-eth": for MT7621 SoC
>  		"mediatek,mt7622-eth": for MT7622 SoC
>  		"mediatek,mt7629-eth": for MT7629 SoC
>  		"ralink,rt5350-eth": for Ralink Rt5350F and MT7628/88 SoC


Thanks for taking care of this!

Note, however, that this compatible value is defined in
Documentation/devicetree/bindings/net/ralink,rt2880-net.txt

I believe that file should go away. These two files are both documenting
the same compatible property AFAICS.


Bjørn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-19  6:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19  3:42 [PATCH] dt-bindings: net: mediatek: support MT7621 SoC Ilya Lipnitskiy
2021-04-19  3:42 ` Ilya Lipnitskiy
2021-04-19  3:42 ` Ilya Lipnitskiy
2021-04-19  6:24 ` Bjørn Mork [this message]
2021-04-19  6:24   ` Bjørn Mork
2021-04-19  6:24   ` Bjørn Mork
2021-04-19 15:12   ` Ilya Lipnitskiy
2021-04-19 15:12     ` Ilya Lipnitskiy
2021-04-19 15:12     ` Ilya Lipnitskiy
2021-04-20  2:44   ` Ilya Lipnitskiy
2021-04-20  2:44     ` Ilya Lipnitskiy
2021-04-20  2:44     ` Ilya Lipnitskiy
2021-04-21 21:19 ` Rob Herring
2021-04-21 21:19   ` Rob Herring
2021-04-21 21:19   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878s5e94hi.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=gerg@kernel.org \
    --cc=ilya.lipnitskiy@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sean.wang@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.