[Buildroot] [PATCH 1/1] package/exim: fix CC and LNCC initialization

[Buildroot] [PATCH 1/1] package/exim: fix CC and LNCC initialization

[Alejandro González]

When using ccache to build the exim package, the
HOSTCC value contains characters that are incorrectly
interpreted by exim's Makefile, presumably spaces. This
breaks the build with "unrecognized option" ccache errors.

Fix that by wrapping the HOSTCC variable in double quotes,
as it is done for other variables that follow.

Signed-off-by: Alejandro Gonz?lez <alejandro.gonzalez.correo@gmail.com>
---
 package/exim/exim.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/exim/exim.mk b/package/exim/exim.mk
index 6643abbf65..19a62f497d 100644
--- a/package/exim/exim.mk
+++ b/package/exim/exim.mk
@@ -123,8 +123,8 @@ endif
 define EXIM_BUILD_CMDS
 	$(TARGET_MAKE_ENV) build=br $(MAKE) -C $(@D) makefile
 	$(HOST_MAKE_ENV) $(MAKE) -C $(@D)/build-br macro_predef \
-		CC=$(HOSTCC) \
-		LNCC=$(HOSTCC) \
+		CC="$(HOSTCC)" \
+		LNCC="$(HOSTCC)" \
 		CFLAGS="-std=c99 $(HOST_CFLAGS)" \
 		LFLAGS="-fPIC $(HOST_LDFLAGS)"
 	$(TARGET_MAKE_ENV) build=br $(MAKE) -C $(@D) $(EXIM_STATIC_FLAGS) \
-- 
2.27.0

[Buildroot] [PATCH 1/1] package/exim: fix CC and LNCC initialization

[Yann E. MORIN]

Alejandro, All,

On 2020-07-19 12:29 +0200, Alejandro Gonz?lez spake thusly:
> When using ccache to build the exim package, the
> HOSTCC value contains characters that are incorrectly
> interpreted by exim's Makefile, presumably spaces. This
> breaks the build with "unrecognized option" ccache errors.
> 
> Fix that by wrapping the HOSTCC variable in double quotes,
> as it is done for other variables that follow.
> 
> Signed-off-by: Alejandro Gonz?lez <alejandro.gonzalez.correo@gmail.com>

Applied to master, after tweaking the commit log slightly. Thanks!

Regards,
Yann E. MORIN.

> ---
>  package/exim/exim.mk | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/package/exim/exim.mk b/package/exim/exim.mk
> index 6643abbf65..19a62f497d 100644
> --- a/package/exim/exim.mk
> +++ b/package/exim/exim.mk
> @@ -123,8 +123,8 @@ endif
>  define EXIM_BUILD_CMDS
>  	$(TARGET_MAKE_ENV) build=br $(MAKE) -C $(@D) makefile
>  	$(HOST_MAKE_ENV) $(MAKE) -C $(@D)/build-br macro_predef \
> -		CC=$(HOSTCC) \
> -		LNCC=$(HOSTCC) \
> +		CC="$(HOSTCC)" \
> +		LNCC="$(HOSTCC)" \
>  		CFLAGS="-std=c99 $(HOST_CFLAGS)" \
>  		LFLAGS="-fPIC $(HOST_LDFLAGS)"
>  	$(TARGET_MAKE_ENV) build=br $(MAKE) -C $(@D) $(EXIM_STATIC_FLAGS) \
> -- 
> 2.27.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] package/exim: fix CC and LNCC initialization

[Peter Korsgaard]

>>>>> "Alejandro" == Alejandro Gonz?lez <alejandro.gonzalez.correo@gmail.com> writes:

 > When using ccache to build the exim package, the
 > HOSTCC value contains characters that are incorrectly
 > interpreted by exim's Makefile, presumably spaces. This
 > breaks the build with "unrecognized option" ccache errors.

 > Fix that by wrapping the HOSTCC variable in double quotes,
 > as it is done for other variables that follow.

 > Signed-off-by: Alejandro Gonz?lez <alejandro.gonzalez.correo@gmail.com>

Committed to 2020.02.x and 2020.05.x, thanks.

-- 
Bye, Peter Korsgaard