All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] Revert "qemu-options.hx: Update for reboot-timeout parameter"
@ 2019-12-05  2:48 Han Han
  2019-12-05  8:25 ` Markus Armbruster
  2019-12-18 11:36 ` Laurent Vivier
  0 siblings, 2 replies; 3+ messages in thread
From: Han Han @ 2019-12-05  2:48 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial, Han Han, laurent, dgilbert

This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8.

In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc
accordingly.

Signed-off-by: Han Han <hhan@redhat.com>
---
 qemu-options.hx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 65c9473b..e14d88e9 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -327,8 +327,8 @@ format(true color). The resolution should be supported by the SVGA mode, so
 the recommended is 320x240, 640x480, 800x640.
 
 A timeout could be passed to bios, guest will pause for @var{rb_timeout} ms
-when boot failed, then reboot. If @option{reboot-timeout} is not set,
-guest will not reboot by default. Currently Seabios for X86
+when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will not
+reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
 system support it.
 
 Do strict boot via @option{strict=on} as far as firmware/BIOS
-- 
2.23.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] Revert "qemu-options.hx: Update for reboot-timeout parameter"
  2019-12-05  2:48 [PATCH v2] Revert "qemu-options.hx: Update for reboot-timeout parameter" Han Han
@ 2019-12-05  8:25 ` Markus Armbruster
  2019-12-18 11:36 ` Laurent Vivier
  1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2019-12-05  8:25 UTC (permalink / raw)
  To: Han Han; +Cc: qemu-trivial, qemu-devel, dgilbert, laurent

Han Han <hhan@redhat.com> writes:

> This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8.
>
> In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc
> accordingly.
>
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>  qemu-options.hx | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 65c9473b..e14d88e9 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -327,8 +327,8 @@ format(true color). The resolution should be supported by the SVGA mode, so
>  the recommended is 320x240, 640x480, 800x640.
>  
>  A timeout could be passed to bios, guest will pause for @var{rb_timeout} ms
> -when boot failed, then reboot. If @option{reboot-timeout} is not set,
> -guest will not reboot by default. Currently Seabios for X86
> +when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will not
> +reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
>  system support it.
>  
>  Do strict boot via @option{strict=on} as far as firmware/BIOS

Reviewed-by: Markus Armbruster <armbru@redhat.com>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] Revert "qemu-options.hx: Update for reboot-timeout parameter"
  2019-12-05  2:48 [PATCH v2] Revert "qemu-options.hx: Update for reboot-timeout parameter" Han Han
  2019-12-05  8:25 ` Markus Armbruster
@ 2019-12-18 11:36 ` Laurent Vivier
  1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2019-12-18 11:36 UTC (permalink / raw)
  To: Han Han, qemu-devel; +Cc: qemu-trivial, dgilbert

Le 05/12/2019 à 03:48, Han Han a écrit :
> This reverts commit bbd9e6985ff342cbe15b9cb7eb30e842796fbbe8.
> 
> In 20a1922032 we allowed reboot-timeout=-1 again, so update the doc
> accordingly.
> 
> Signed-off-by: Han Han <hhan@redhat.com>
> ---
>  qemu-options.hx | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 65c9473b..e14d88e9 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -327,8 +327,8 @@ format(true color). The resolution should be supported by the SVGA mode, so
>  the recommended is 320x240, 640x480, 800x640.
>  
>  A timeout could be passed to bios, guest will pause for @var{rb_timeout} ms
> -when boot failed, then reboot. If @option{reboot-timeout} is not set,
> -guest will not reboot by default. Currently Seabios for X86
> +when boot failed, then reboot. If @var{rb_timeout} is '-1', guest will not
> +reboot, qemu passes '-1' to bios by default. Currently Seabios for X86
>  system support it.
>  
>  Do strict boot via @option{strict=on} as far as firmware/BIOS
> 

Applied to my trivial-patches branch.

Thanks,
Laurent



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-12-18 11:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05  2:48 [PATCH v2] Revert "qemu-options.hx: Update for reboot-timeout parameter" Han Han
2019-12-05  8:25 ` Markus Armbruster
2019-12-18 11:36 ` Laurent Vivier

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.