* [Buildroot] [git commit] nasm: Fix compilation with GCC 8
@ 2018-05-05 9:21 Peter Korsgaard
2018-05-23 8:23 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2018-05-05 9:21 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=3aa64a0e828eca3669cbd1fa3fb9fef69dacf74e
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
host-nasm fails to compile with GCC 8:
In file included from ./include/nasm.h:46,
from asm/nasm.c:47:
./include/nasmlib.h:194:1: error: ???pure??? attribute on function returning ???void??? [-Werror=attributes]
void pure_func seg_init(void);
^~~~
Pull a patch from upstream that removes the stale declaration of
seg_init, which was eliminated a long time ago.
Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
.../nasm/0001-nasmlib-Drop-unused-seg_init.patch | 32 ++++++++++++++++++++++
1 file changed, 32 insertions(+)
diff --git a/package/nasm/0001-nasmlib-Drop-unused-seg_init.patch b/package/nasm/0001-nasmlib-Drop-unused-seg_init.patch
new file mode 100644
index 0000000000..a18d121bfb
--- /dev/null
+++ b/package/nasm/0001-nasmlib-Drop-unused-seg_init.patch
@@ -0,0 +1,32 @@
+From 5eb1838b4d3752fd863d19442943983a2a5ee87c Mon Sep 17 00:00:00 2001
+From: Cyrill Gorcunov <gorcunov@gmail.com>
+Date: Sat, 10 Feb 2018 00:33:41 +0300
+Subject: [PATCH] nasmlib: Drop unused seg_init
+
+The helper has been eliminated in 2c4a4d5810d0a59b033a07876a2648ef5d4c2859
+
+https://bugzilla.nasm.us/show_bug.cgi?id=3392461
+
+Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
+---
+ include/nasmlib.h | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/include/nasmlib.h b/include/nasmlib.h
+index 79e866b5..fee1b5ea 100644
+--- a/include/nasmlib.h
++++ b/include/nasmlib.h
+@@ -188,10 +188,8 @@ int64_t readnum(char *str, bool *error);
+ int64_t readstrnum(char *str, int length, bool *warn);
+
+ /*
+- * seg_init: Initialise the segment-number allocator.
+ * seg_alloc: allocate a hitherto unused segment number.
+ */
+-void pure_func seg_init(void);
+ int32_t pure_func seg_alloc(void);
+
+ /*
+--
+2.17.0
+
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [git commit] nasm: Fix compilation with GCC 8
2018-05-05 9:21 [Buildroot] [git commit] nasm: Fix compilation with GCC 8 Peter Korsgaard
@ 2018-05-23 8:23 ` Thomas Petazzoni
2018-05-23 10:19 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2018-05-23 8:23 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 5 May 2018 11:21:18 +0200, Peter Korsgaard wrote:
> commit: https://git.buildroot.net/buildroot/commit/?id=3aa64a0e828eca3669cbd1fa3fb9fef69dacf74e
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> host-nasm fails to compile with GCC 8:
>
> In file included from ./include/nasm.h:46,
> from asm/nasm.c:47:
> ./include/nasmlib.h:194:1: error: ?pure? attribute on function returning ?void? [-Werror=attributes]
> void pure_func seg_init(void);
> ^~~~
>
> Pull a patch from upstream that removes the stale declaration of
> seg_init, which was eliminated a long time ago.
>
> Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> .../nasm/0001-nasmlib-Drop-unused-seg_init.patch | 32 ++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/package/nasm/0001-nasmlib-Drop-unused-seg_init.patch b/package/nasm/0001-nasmlib-Drop-unused-seg_init.patch
> new file mode 100644
> index 0000000000..a18d121bfb
> --- /dev/null
> +++ b/package/nasm/0001-nasmlib-Drop-unused-seg_init.patch
> @@ -0,0 +1,32 @@
> +From 5eb1838b4d3752fd863d19442943983a2a5ee87c Mon Sep 17 00:00:00 2001
> +From: Cyrill Gorcunov <gorcunov@gmail.com>
> +Date: Sat, 10 Feb 2018 00:33:41 +0300
> +Subject: [PATCH] nasmlib: Drop unused seg_init
> +
> +The helper has been eliminated in 2c4a4d5810d0a59b033a07876a2648ef5d4c2859
> +
> +https://bugzilla.nasm.us/show_bug.cgi?id=3392461
> +
> +Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Peter, could you apply this one to 2018.02.x, to fix
http://autobuild.buildroot.net/results/98a/98a89f7203377d2c8b2f47bfdf00243a8837500e/build-end.log ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [git commit] nasm: Fix compilation with GCC 8
2018-05-23 8:23 ` Thomas Petazzoni
@ 2018-05-23 10:19 ` Peter Korsgaard
0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-05-23 10:19 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
Hi,
> Peter, could you apply this one to 2018.02.x, to fix
> http://autobuild.buildroot.net/results/98a/98a89f7203377d2c8b2f47bfdf00243a8837500e/build-end.log ?
Yes, I will run through the changes on master since -rc1 and backport
the applicable commits (including these host gcc8 fixes) tonight -
Thanks for the reminder.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-23 10:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-05 9:21 [Buildroot] [git commit] nasm: Fix compilation with GCC 8 Peter Korsgaard
2018-05-23 8:23 ` Thomas Petazzoni
2018-05-23 10:19 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.