* [Buildroot] [PATCH 1/1] gconf: add dependency on toolchain w/ dynamic lib
@ 2018-01-22 5:57 Joseph Kogut
2018-01-22 6:02 ` Baruch Siach
0 siblings, 1 reply; 6+ messages in thread
From: Joseph Kogut @ 2018-01-22 5:57 UTC (permalink / raw)
To: buildroot
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
This patch fixes some recent build issues caused by BR2_STATIC_LIBS=y.
package/gconf/Config.in | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/gconf/Config.in b/package/gconf/Config.in
index a68287525b..a967d61644 100644
--- a/package/gconf/Config.in
+++ b/package/gconf/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_GCONF
depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
depends on BR2_USE_MMU # dbus, libglib2
depends on BR2_USE_WCHAR # libglib2
+ depends on !BR2_STATIC_LIBS
select BR2_PACKAGE_DBUS
select BR2_PACKAGE_DBUS_GLIB
select BR2_PACKAGE_LIBGLIB2
@@ -14,6 +15,7 @@ config BR2_PACKAGE_GCONF
https://projects.gnome.org/gconf/
-comment "gconf needs a toolchain w/ threads, wchar"
+comment "gconf needs a toolchain w/ threads, wchar, dynamic library"
depends on BR2_USE_MMU
- depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
+ depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR \
+ || BR2_STATIC_LIBS
--
2.16.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] gconf: add dependency on toolchain w/ dynamic lib
2018-01-22 5:57 [Buildroot] [PATCH 1/1] gconf: add dependency on toolchain w/ dynamic lib Joseph Kogut
@ 2018-01-22 6:02 ` Baruch Siach
2018-01-22 6:11 ` Joseph Kogut
0 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2018-01-22 6:02 UTC (permalink / raw)
To: buildroot
Hi Josef,
On Sun, Jan 21, 2018 at 09:57:02PM -0800, Joseph Kogut wrote:
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> ---
>
> This patch fixes some recent build issues caused by BR2_STATIC_LIBS=y.
Please add a reference in the commit log to the fixed build failure. Here is
one:
http://autobuild.buildroot.net/results/153/153fd72832399e353d1db2c3adde68d45197ada5/
You can find more at
http://autobuild.buildroot.net/?reason=gconf-3.2.6
baruch
> package/gconf/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/gconf/Config.in b/package/gconf/Config.in
> index a68287525b..a967d61644 100644
> --- a/package/gconf/Config.in
> +++ b/package/gconf/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_GCONF
> depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
> depends on BR2_USE_MMU # dbus, libglib2
> depends on BR2_USE_WCHAR # libglib2
> + depends on !BR2_STATIC_LIBS
> select BR2_PACKAGE_DBUS
> select BR2_PACKAGE_DBUS_GLIB
> select BR2_PACKAGE_LIBGLIB2
> @@ -14,6 +15,7 @@ config BR2_PACKAGE_GCONF
>
> https://projects.gnome.org/gconf/
>
> -comment "gconf needs a toolchain w/ threads, wchar"
> +comment "gconf needs a toolchain w/ threads, wchar, dynamic library"
> depends on BR2_USE_MMU
> - depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
> + depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR \
> + || BR2_STATIC_LIBS
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] gconf: add dependency on toolchain w/ dynamic lib
2018-01-22 6:02 ` Baruch Siach
@ 2018-01-22 6:11 ` Joseph Kogut
2018-02-03 22:28 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Joseph Kogut @ 2018-01-22 6:11 UTC (permalink / raw)
To: buildroot
GConf fails to build when BR2_STATIC_LIBS=y.
Fixes:
http://autobuild.buildroot.net/results/ad8a9b082006f0334010c9c4dc5a90c2071df121/
Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
---
Thanks for the feedback, Baruch. I've updated the commit message.
package/gconf/Config.in | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/gconf/Config.in b/package/gconf/Config.in
index a68287525b..a967d61644 100644
--- a/package/gconf/Config.in
+++ b/package/gconf/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_GCONF
depends on BR2_TOOLCHAIN_HAS_THREADS # dbus, libglib2
depends on BR2_USE_MMU # dbus, libglib2
depends on BR2_USE_WCHAR # libglib2
+ depends on !BR2_STATIC_LIBS
select BR2_PACKAGE_DBUS
select BR2_PACKAGE_DBUS_GLIB
select BR2_PACKAGE_LIBGLIB2
@@ -14,6 +15,7 @@ config BR2_PACKAGE_GCONF
https://projects.gnome.org/gconf/
-comment "gconf needs a toolchain w/ threads, wchar"
+comment "gconf needs a toolchain w/ threads, wchar, dynamic library"
depends on BR2_USE_MMU
- depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
+ depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR \
+ || BR2_STATIC_LIBS
--
2.16.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] gconf: add dependency on toolchain w/ dynamic lib
2018-01-22 6:11 ` Joseph Kogut
@ 2018-02-03 22:28 ` Peter Korsgaard
2018-02-04 8:43 ` Baruch Siach
0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2018-02-03 22:28 UTC (permalink / raw)
To: buildroot
>>>>> "Joseph" == Joseph Kogut <joseph.kogut@gmail.com> writes:
> GConf fails to build when BR2_STATIC_LIBS=y.
> Fixes:
> http://autobuild.buildroot.net/results/ad8a9b082006f0334010c9c4dc5a90c2071df121/
> Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> ---
> Thanks for the feedback, Baruch. I've updated the commit message.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] gconf: add dependency on toolchain w/ dynamic lib
2018-02-03 22:28 ` Peter Korsgaard
@ 2018-02-04 8:43 ` Baruch Siach
2018-02-04 10:01 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2018-02-04 8:43 UTC (permalink / raw)
To: buildroot
Hi Peter,
On Sat, Feb 03, 2018 at 11:28:10PM +0100, Peter Korsgaard wrote:
> >>>>> "Joseph" == Joseph Kogut <joseph.kogut@gmail.com> writes:
>
> > GConf fails to build when BR2_STATIC_LIBS=y.
> > Fixes:
> > http://autobuild.buildroot.net/results/ad8a9b082006f0334010c9c4dc5a90c2071df121/
>
> > Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
> > ---
>
> > Thanks for the feedback, Baruch. I've updated the commit message.
>
> Committed, thanks.
Not in master as of 5f3246a1d69 (gdk-pixbuf: unbreak gdk-pixbuf
loaders.cache).
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] gconf: add dependency on toolchain w/ dynamic lib
2018-02-04 8:43 ` Baruch Siach
@ 2018-02-04 10:01 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2018-02-04 10:01 UTC (permalink / raw)
To: buildroot
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
> Hi Peter,
> On Sat, Feb 03, 2018 at 11:28:10PM +0100, Peter Korsgaard wrote:
>> >>>>> "Joseph" == Joseph Kogut <joseph.kogut@gmail.com> writes:
>>
>> > GConf fails to build when BR2_STATIC_LIBS=y.
>> > Fixes:
>> > http://autobuild.buildroot.net/results/ad8a9b082006f0334010c9c4dc5a90c2071df121/
>>
>> > Signed-off-by: Joseph Kogut <joseph.kogut@gmail.com>
>> > ---
>>
>> > Thanks for the feedback, Baruch. I've updated the commit message.
>>
>> Committed, thanks.
> Not in master as of 5f3246a1d69 (gdk-pixbuf: unbreak gdk-pixbuf
> loaders.cache).
Sorry, fixed now.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-04 10:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-22 5:57 [Buildroot] [PATCH 1/1] gconf: add dependency on toolchain w/ dynamic lib Joseph Kogut
2018-01-22 6:02 ` Baruch Siach
2018-01-22 6:11 ` Joseph Kogut
2018-02-03 22:28 ` Peter Korsgaard
2018-02-04 8:43 ` Baruch Siach
2018-02-04 10:01 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.