All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rt2800usb: Add Epson wireless adapter device-id
@ 2017-05-17 10:15 Tom Gaudasiński
  2017-05-18  5:47 ` Kalle Valo
  0 siblings, 1 reply; 5+ messages in thread
From: Tom Gaudasiński @ 2017-05-17 10:15 UTC (permalink / raw)
  To: linux-wireless; +Cc: sgruszka, helmut.schaa

Make Epson WN7512BEP work by adding its device-id to rt2800usb. Device
contains a Ralink RT3071L, registers as vendor Accton/Arcadyan.

Signed-off-by: Tom Gaudasinski <tomg@records.headdesk.com.au>

--- linux/drivers/net/wireless/ralink/rt2x00/rt2800usb.c.orig   
2017-05-17 19:49:44.893895819 +1000
+++ linux/drivers/net/wireless/ralink/rt2x00/rt2800usb.c    2017-05-17
19:49:32.906111192 +1000
@@ -1156,6 +1156,8 @@ static struct usb_device_id rt2800usb_de
     { USB_DEVICE(0x2001, 0x3c17) },
     /* Panasonic */
     { USB_DEVICE(0x083a, 0xb511) },
+    /* Accton/Arcadyan/Epson */
+    { USB_DEVICE(0x083a, 0xb512) },
     /* Philips */
     { USB_DEVICE(0x0471, 0x20dd) },
     /* Ralink */

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rt2800usb: Add Epson wireless adapter device-id
  2017-05-17 10:15 [PATCH] rt2800usb: Add Epson wireless adapter device-id Tom Gaudasiński
@ 2017-05-18  5:47 ` Kalle Valo
  2017-05-18  8:46   ` Tom Gaudasiński
  0 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2017-05-18  5:47 UTC (permalink / raw)
  To: Tom Gaudasiński; +Cc: linux-wireless, sgruszka, helmut.schaa

Tom Gaudasi=C5=84ski <tomg@records.headdesk.com.au> writes:

> Make Epson WN7512BEP work by adding its device-id to rt2800usb. Device
> contains a Ralink RT3071L, registers as vendor Accton/Arcadyan.
>
> Signed-off-by: Tom Gaudasinski <tomg@records.headdesk.com.au>

The prefix should be "rt2x00:".

> --- linux/drivers/net/wireless/ralink/rt2x00/rt2800usb.c.orig=20=20=20
> 2017-05-17 19:49:44.893895819 +1000
> +++ linux/drivers/net/wireless/ralink/rt2x00/rt2800usb.c    2017-05-17
> 19:49:32.906111192 +1000
> @@ -1156,6 +1156,8 @@ static struct usb_device_id rt2800usb_de
>      { USB_DEVICE(0x2001, 0x3c17) },
>      /* Panasonic */
>      { USB_DEVICE(0x083a, 0xb511) },
> +    /* Accton/Arcadyan/Epson */
> +    { USB_DEVICE(0x083a, 0xb512) },

The patch looks to be corrupted, didn't it test it though. Better use
'git send-email' to submit patches.

--=20
Kalle Valo

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rt2800usb: Add Epson wireless adapter device-id
  2017-05-18  5:47 ` Kalle Valo
@ 2017-05-18  8:46   ` Tom Gaudasiński
  2017-05-18  8:51     ` Kalle Valo
  0 siblings, 1 reply; 5+ messages in thread
From: Tom Gaudasiński @ 2017-05-18  8:46 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linux-wireless, sgruszka, helmut.schaa

Is it advisable to re-submit with the noted corrections fixed?


On 18/05/17 15:47, Kalle Valo wrote:
> Tom Gaudasiński <tomg@records.headdesk.com.au> writes:
>
>> Make Epson WN7512BEP work by adding its device-id to rt2800usb. Device
>> contains a Ralink RT3071L, registers as vendor Accton/Arcadyan.
>>
>> Signed-off-by: Tom Gaudasinski <tomg@records.headdesk.com.au>
> The prefix should be "rt2x00:".
>
>> --- linux/drivers/net/wireless/ralink/rt2x00/rt2800usb.c.orig   
>> 2017-05-17 19:49:44.893895819 +1000
>> +++ linux/drivers/net/wireless/ralink/rt2x00/rt2800usb.c    2017-05-17
>> 19:49:32.906111192 +1000
>> @@ -1156,6 +1156,8 @@ static struct usb_device_id rt2800usb_de
>>      { USB_DEVICE(0x2001, 0x3c17) },
>>      /* Panasonic */
>>      { USB_DEVICE(0x083a, 0xb511) },
>> +    /* Accton/Arcadyan/Epson */
>> +    { USB_DEVICE(0x083a, 0xb512) },
> The patch looks to be corrupted, didn't it test it though. Better use
> 'git send-email' to submit patches.
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rt2800usb: Add Epson wireless adapter device-id
  2017-05-18  8:46   ` Tom Gaudasiński
@ 2017-05-18  8:51     ` Kalle Valo
  2017-05-18  9:20       ` Kalle Valo
  0 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2017-05-18  8:51 UTC (permalink / raw)
  To: Tom Gaudasiński; +Cc: linux-wireless, sgruszka, helmut.schaa

Tom Gaudasi=C5=84ski <tomg@records.headdesk.com.au> writes:

> Is it advisable to re-submit with the noted corrections fixed?

Yes, please resend.

--=20
Kalle Valo

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] rt2800usb: Add Epson wireless adapter device-id
  2017-05-18  8:51     ` Kalle Valo
@ 2017-05-18  9:20       ` Kalle Valo
  0 siblings, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2017-05-18  9:20 UTC (permalink / raw)
  To: Tom Gaudasiński; +Cc: linux-wireless, sgruszka, helmut.schaa

Kalle Valo <kvalo@codeaurora.org> writes:

> Tom Gaudasi=C5=84ski <tomg@records.headdesk.com.au> writes:
>
>> Is it advisable to re-submit with the noted corrections fixed?
>
> Yes, please resend.

And remember to mark the new version as v2:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc=
hes#patch_version_missing

--=20
Kalle Valo

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-05-18  9:22 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-17 10:15 [PATCH] rt2800usb: Add Epson wireless adapter device-id Tom Gaudasiński
2017-05-18  5:47 ` Kalle Valo
2017-05-18  8:46   ` Tom Gaudasiński
2017-05-18  8:51     ` Kalle Valo
2017-05-18  9:20       ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.